Organize dirty work from apply-audit-remediation-protocol - #1338
Conversation
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:45 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:046cb38ad4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const timeout = setTimeout(() => { | ||
| setStage("unmounted"); | ||
| }, exitDurationMs); |
There was a problem hiding this comment.
When prefers-reduced-motion: reduce is active, the new motion-safe exit animations do not run, but this timeout keeps each closed overlay mounted for another 140 ms. The Sheet therefore remains fully visible and blocks the page, while the popovers remain visible and interactive, before disappearing abruptly. Use a zero delay or immediately hide/unmount the exiting surface when motion is reduced; a focused test can emulate reduced motion, close each surface, and assert it disappears without advancing the exit timer.
Useful? React with 👍 / 👎.
| defaultSheetUsesViewportSize | ||
| ? "min-h-[calc(100dvh-2rem)] max-h-[calc(100dvh-1rem)] sm:min-h-0" | ||
| : "max-h-[88dvh]", | ||
| stage === "exiting" ? "motion-safe:animate-sheet-down sm:motion-safe:animate-dialog-fall" : "motion-safe:animate-sheet-up sm:motion-safe:animate-dialog-rise" |
There was a problem hiding this comment.
When a bottom sheet is dismissed through the drag grip, handleGripPointerDown has set the panel's inline animation to none, and pointer-up never clears it. Inline style therefore overrides this new animate-sheet-down class: the transform is cleared, so the retained panel snaps back to its resting position and merely fades with the backdrop before unmounting instead of sliding out. Clear the inline animation before calling onClose, and cover a threshold/velocity swipe dismissal with a focused animation-state test.
Useful? React with 👍 / 👎.
Organizing dirty work from apply-audit-remediation-protocol.