Skip to content

issues: close #087 — the knip failure was a worktree-install false positive - #1340

Merged
BigSimmo merged 1 commit into
mainfrom
claude/close-knip-false-positive
Jul 28, 2026
Merged

issues: close #087 — the knip failure was a worktree-install false positive#1340
BigSimmo merged 1 commit into
mainfrom
claude/close-knip-false-positive

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Closes #087 in docs/outstanding-issues.md as not a defect.

The reported findings — unused devDependencies rimraf / tsx / @testing-library/dom, and playwright-core unlisted across scripts/capture-chrome-parity.ts and four tests/ui-*.spec.ts — only appeared because the worktree had no node_modules of its own, so tooling resolved from the parent checkout.

After npm ci in the same worktree, npm run check:knip exits 0 with no ignore-list change and no dependency edit.

The archived row keeps the durable lesson: never act on a knip finding from a worktree that has not been installed.

One row moved from Open items to Resolved / archive. No code, config, or dependency change.

🤖 Generated with Claude Code

…itive
check:knip exits 0 once the worktree has its own node_modules. The findings
only appeared because tooling was resolving from the parent checkout.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@supabase

supabaseBot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:34 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 566c6dab-e5b1-4087-b669-5baf4d600f2b

📥 Commits

Reviewing files that changed from the base of the PR and between 8917466 and 81ae7de.

📒 Files selected for processing (1)
  • docs/outstanding-issues.md

Comment @coderabbitai help to get the list of available commands.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@cursoragent Inspect the PR and repository state, identify the root cause of every failing CI check, unresolved review comment, merge conflict, and related defect. Apply the smallest robust fix using existing project patterns and best practices, without unrelated changes. Run Bugbot and all relevant lint, type-check, test, build, and CI-equivalent commands, fix any issues found, then resolve only the review comments that are fully addressed. Summarise the root causes, changes made, validation results, and any remaining blockers.

@BigSimmo
BigSimmo enabled auto-merge (squash) July 28, 2026 08:00
@BigSimmo
BigSimmo disabled auto-merge July 28, 2026 08:00
@cursor

cursorBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

PR #1340 was already healthy and landed while under inspection. No product defect, failing check, merge conflict, or review thread needed a fix.

Root causes

AreaFinding
Failing CINone. Early BLOCKED was pending Static PR checks; then PR required / Static / Semgrep / Gitleaks all SUCCESS. Unit/Build/UI correctly skipped (docs-only).
Review threadsNone. Bugbot/cursor[bot]: no findings.
Merge conflictsNone — 0 behind / 1 ahead; merge-tree clean.
Related defectAuto-merge race: #1340 squash-merged as f39ca98a mid-babysit, orphaning a late ledger append.

Changes made

Validation

Remaining blockers

Open in WebOpen in Cursor

@BigSimmo
BigSimmo enabled auto-merge (squash) July 28, 2026 08:01
@BigSimmo
BigSimmo merged commit f39ca98 into mainJul 28, 2026
18 checks passed
@BigSimmo
BigSimmo deleted the claude/close-knip-false-positive branch July 28, 2026 08:02
cursorBot pushed a commit that referenced this pull request Jul 28, 2026
Capture the pre-merge babysit outcome and confirm the squash land of #1340,
including the orphaned late ledger row from the auto-merge race.
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo