Organize dirty work from codex/task-ledger-final-bddceb - #1342
Conversation
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:18 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:a12718e90b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | 1 | **TL-01** · ingestion audit F1 | Block destructive bulk reindex while agent enrichment is active. Add `hasActiveAgentEnrichmentJob` to both reindex routes with denial and idle-path tests. | A2 | High — ingestion concurrency | **Ready; do first.** | 0.5–1 day | Local/offline; no provider action. | Both routes reject during an active job and preserve idle behavior. Run focused route tests, typecheck, and production-readiness. Stop before queue-semantic changes. | | ||
| | 2 | **TL-02** · `#026` prerequisite | Detect aged `queued` documents with no open ingestion job and add one idempotent, owner-scoped recovery path with a grace period and dry-run visibility. | A2 | Specialist — queue/database reliability | **After TL-01; before ingestion webhook activation.** | 0.5–1 day | Local replay if schema/scheduling changes; approval only for later deployment. | A controlled orphan receives exactly one job and active jobs are never duplicated. Run focused recovery/autopilot tests and production-readiness. Stop before live mutation. | |
There was a problem hiding this comment.
In a fresh session, TL-01 and TL-02 cannot be reconciled or closed because neither ingestion audit F1 nor the orphan-recovery task appears in docs/outstanding-issues.md (a repository-wide search finds only #26, which describes the separate trigger implementation). This leaves the two highest-priority tasks without the durable evidence and resolution history required by the new ledger contract, so the ledgers can silently diverge; add canonical issue records or reference existing records before presenting these rows as executable work.
AGENTS.md reference: AGENTS.md:L453-L461
Useful? React with 👍 / 👎.
| | ----: | ------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------- | ------------------------------------------------------ | ------------------------------------------------------------------------------ | --------------------------------------------- | ---------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | 1 | **TL-01** · ingestion audit F1 | Block destructive bulk reindex while agent enrichment is active. Add `hasActiveAgentEnrichmentJob` to both reindex routes with denial and idle-path tests. | A2 | High — ingestion concurrency | **Ready; do first.** | 0.5–1 day | Local/offline; no provider action. | Both routes reject during an active job and preserve idle behavior. Run focused route tests, typecheck, and production-readiness. Stop before queue-semantic changes. | | ||
| | 2 | **TL-02** · `#026` prerequisite | Detect aged `queued` documents with no open ingestion job and add one idempotent, owner-scoped recovery path with a grace period and dry-run visibility. | A2 | Specialist — queue/database reliability | **After TL-01; before ingestion webhook activation.** | 0.5–1 day | Local replay if schema/scheduling changes; approval only for later deployment. | A controlled orphan receives exactly one job and active jobs are never duplicated. Run focused recovery/autopilot tests and production-readiness. Stop before live mutation. | | ||
| | 3 | **TL-03** · `#026` trigger | Finish the existing isolated document-change trigger by resuming its worktree, replaying its migration, regenerating drift evidence, and running local gates. | A2 | Specialist — Supabase migrations/security | **After TL-02, when WSL/Docker and task ownership are available.** | 0.5–1 day remaining | WSL/Docker; protected-main PR. Vault/GUC/live activation needs approval. | Disposable replay, schema mirror, drift manifest, grants, rollback docs, `verify:cheap`, and production-readiness pass. Stop at PR-ready local evidence; never apply raw SQL live. | |
There was a problem hiding this comment.
When another checkout reaches TL-03, it cannot resume the claimed implementation: this commit contains no 20260723150000_document_change_ingestion_webhook.sql, and #26 says the work is uncommitted in a Windows-local worktree; in this checkout, git worktree list and git branch -a also contain no such worktree or branch. The shared queue therefore advertises only 0.5–1 day of remaining work while the implementation itself is not durably available; commit/archive the work or rewrite this as a reconstruction task with repository-backed evidence.
AGENTS.md reference: AGENTS.md:L453-L455
Useful? React with 👍 / 👎.
Organizes current dirty work collected on branch codex/task-ledger-final-bddceb.