test: update favourites auth gate assertion by BigSimmo · Pull Request #1357 · BigSimmo/Database

BigSimmo · 2026-07-28T09:02:08Z

Summary

Update favourites auth gate dom assertion to match current auth gating behavior.

RAG impact

RAG impact: no retrieval behaviour change

…ructure-b2bf # Conflicts: # src/components/clinical-dashboard/ClinicalSidebar.tsx

Land the six-item sidebar (Answer, Documents, Services, Medications, Factsheets, Tools) plus settings-guide flow and lazy sidebar dialogs on current main. Keep main's clinical-dashboard-lazy barrel and phone shell classes; replace main's Forms/Therapy rail composition with #66's set. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Assert the canonical sidebarToolItems list (Medications/Factsheets) instead of main's retired primarySidebarToolIds Forms/Therapy filter. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

…em-land-cfa0 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Tighten mobile menu assertions so Close Clinical Guide menu is not treated as a Guide affordance, and make openGuide reuse an already-open Settings dialog (tablet rail + restore path) instead of clicking through an overlay. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

…0' into cursor/sidebar-six-item-land-cfa0 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Record feature-branch proof on PR #1174 (focused suites, verify:pr-local, ensure spot-check, verify:ui). Remaining work is merge to main. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Cite d97c11e as the content-proof commit for the six-item sidebar land so later ledger-only tip moves do not churn the issue row. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

…em-land-cfa0 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

…em-land-cfa0

supabase · 2026-07-28T09:02:14Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2026-07-28T09:02:16Z

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:32 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5c906942-13ee-4256-86c4-2cea80223f07

📥 Commits

Reviewing files that changed from the base of the PR and between 5bcdc1d and 0c2e8e5.

📒 Files selected for processing (12)

docs/branch-review-ledger.md
docs/outstanding-issues.md
src/components/ClinicalDashboard.tsx
src/components/clinical-dashboard/ClinicalSidebar.tsx
src/components/clinical-dashboard/global-search-shell.tsx
src/components/clinical-dashboard/lazy-sidebar-dialogs.tsx
src/components/clinical-dashboard/settings-dialog.tsx
src/components/clinical-dashboard/use-settings-guide-flow.ts
tests/favourites-auth-gate.dom.test.tsx
tests/favourites-auth-gate.test.ts
tests/therapy-compass-mode-wiring.test.ts
tests/ui-smoke.spec.ts

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:0c2e8e5a09

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-28T09:06:42Z

 closeLabel="Close settings"
 labelledBy="account-settings-title"
- initialFocusRef={closeButtonRef}
+ initialFocusRef={initialFocus === "guide" ? guideButtonRef : closeButtonRef}


Scroll the restored Guide control into view
When Guide is opened from Settings and then closed, SidebarSettingsDialog has unmounted the settings surface, so it remounts with its scroll container at the Account section; this ref targets the Guide button near the bottom, but Sheet focuses it with preventScroll: true. The result is keyboard focus on an off-screen control with no visible focus indicator on both phone and shorter desktop viewports. Preserve/restore the prior scroll position or scroll the Help section into view before focusing; a focused browser check should assert that the Guide button's bounds are inside the settings scrollport after closing Guide.
Useful? React with 👍 / 👎.

BigSimmo · 2026-07-28T12:06:51Z

Reviewed at exact head 0c2e8e5. Superseded by #1361 only at the navigation family level. Stale routes, sidebar state, and tap-target assertions were rejected. Source branch and worktree are preserved; this PR is closed only to remove the superseded review queue entry.

BigSimmoand others added 22 commits July 22, 2026 17:36

feat(ui): streamline clinical sidebar navigation
cacaa3f

Merge remote-tracking branch 'origin/main' into codex/chat-sidebar-st…
1165f8e
…ructure-b2bf # Conflicts: # src/components/clinical-dashboard/ClinicalSidebar.tsx

test(ui): align therapy wiring with sidebar scope
cd54e68

test(ui): align favourites sidebar contract with six-item rail
db9e02c
Assert the canonical sidebarToolItems list (Medications/Factsheets) instead of main's retired primarySidebarToolIds Forms/Therapy filter. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

style: format favourites sidebar contract test
acb3f74
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into cursor/sidebar-six-it…
3fe0c14
…em-land-cfa0 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Merge remote-tracking branch 'origin/cursor/sidebar-six-item-land-cfa…
3a3f2b6
…0' into cursor/sidebar-six-item-land-cfa0 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

issues: update#66with sidebar land proof status
e72b201
Record feature-branch proof on PR #1174 (focused suites, verify:pr-local, ensure spot-check, verify:ui). Remaining work is merge to main. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

issues: pin#66proof SHA to ledger tip
3c28afe
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

issues: align#66tip SHA with branch HEAD
0ade13a
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

docs: pin#66proof to content SHA and record review ledger
0aaad37
Cite d97c11e as the content-proof commit for the six-item sidebar land so later ledger-only tip moves do not churn the issue row. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

issues: clean#66proof wording
6756b03
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into cursor/sidebar-six-it…
62eae1e
…em-land-cfa0 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into cursor/sidebar-six-it…
3fec0dd
…em-land-cfa0

Merge cursor/pr-queue-hygiene-72ec for postcss audit + PR branch sync
3a920cd

Merge remote-tracking branch 'origin/main' into cursor/sidebar-six-it…
1f09da1
…em-land-cfa0

Merge remote-tracking branch 'origin/main' into HEAD
6d1286a

fix(ci): format outstanding issues ledger
c44a5c5

docs: record PR 1174 maintenance
6f383ea

test: update favourites auth gate assertion
0c2e8e5

chatgpt-codex-connectorBot reviewed Jul 28, 2026
View reviewed changes

BigSimmo mentioned this pull request Jul 28, 2026
Sheets: preserve responsive height caps #1361
Merged

BigSimmo closed this Jul 28, 2026

BigSimmo deleted the codex/run-pr-resume-20260725-fav-auth branch July 30, 2026 09:10

Navigation Menu

test: update favourites auth gate assertion - #1357

test: update favourites auth gate assertion#1357
BigSimmo wants to merge 22 commits into
mainfrom
codex/run-pr-resume-20260725-fav-auth

BigSimmo commented Jul 28, 2026

Uh oh!

supabaseBot commented Jul 28, 2026

Uh oh!

coderabbitaiBot commented Jul 28, 2026

Review limit reached

Uh oh!

chatgpt-codex-connectorBot left a comment

Uh oh!

chatgpt-codex-connectorBotJul 28, 2026

Uh oh!

BigSimmo commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

BigSimmo commented Jul 28, 2026

Summary

RAG impact

Uh oh!

supabaseBot commented Jul 28, 2026

Uh oh!

coderabbitaiBot commented Jul 28, 2026

Review limit reached

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connectorBotJul 28, 2026

Choose a reason for hiding this comment

Uh oh!

BigSimmo commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants