chore: activate universal ledger ownership updates - #1358
Conversation
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:30 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
Comment |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:d43121de4d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /^## Recommended execution ledger/ { inrecommended=1; next } | ||
| /^## / { if (inrecommended) inrecommended=0 } | ||
| inrecommended && /^\|[[:space:]]*[0-9][0-9][[:space:]]*\|/ { | ||
| n=split($0, c, "|") | ||
| order=c[2]; id=c[3]; acuity=c[4]; timing=c[6]; estimate=c[7] |
There was a problem hiding this comment.
With the ledger introduced in this commit, the actual heading is ## Recommended execution queue, but this parser waits for ## Recommended execution ledger; consequently a session-start run reports 0 recommended and falls back to priority groups instead of surfacing the new queue. The row expression would also omit orders 1–9, and the selected columns map the outcome to id, effort to timing, and dependencies to estimate, so fixing only the heading is insufficient; exercise the hook against the committed ledger and parse its actual column layout.
AGENTS.md reference: AGENTS.md:L453-L458
Useful? React with 👍 / 👎.
| 2. State the **Recommended execution ledger** back in its recorded order, including ID, acuity, | ||
| intelligence, timing, estimate, and completion signal. |
There was a problem hiding this comment.
/issues instruction with the active queue
When a user invokes plain /issues, the repository-level instruction still requires stating open items grouped by priority, which conflicts with this skill's new requirement to return the recommended execution queue and can cause agents to omit the active task view. Update the root instruction in the same change so the higher-level rule and this skill prescribe the same behavior.
AGENTS.md reference: AGENTS.md:L460-L462
Useful? React with 👍 / 👎.
| | 2 | `#030` | Require distinct source identities for distinct expected comparison slots; begin with a red shared-title/two-expectation test. | A2 / High evaluation semantics | Ready; after 1 | 2–4 hours | Local/offline; protected-eval review | One source cannot satisfy both slots; existing cases stay green. Run focused matching, typecheck, `verify:cheap`. Stop before alias/retrieval/ranking changes. | | ||
| | 3 | `#019` | Prove admission evidence is lost at the comparison fallback boundary; scope the smallest correction without automatically shipping it. | A2 / Specialist RAG | Reproducer now; behavior after 9 | 0.5–1 day; fix separate | Protected review; approved baseline/post canary for behavior | Reproducer fails while packing retains both sources. Stop without behavior change if the boundary defect is not independently reproducible. | | ||
| | 4 | `#026` | Prove aged queued-without-job recovery, then activate the merged document trigger only through the approved Supabase path and configure Vault/GUC. | A2 / Specialist recovery + Operator | Recovery now; live steps in approved window | 0.5–1 day local; 1–2 hours operator | PR #1100 merged; live Supabase approval | Recovery is idempotent under crash/concurrency/repeat; migration state, controlled event, rollback, and production-readiness are recorded. Never apply raw SQL live. | | ||
| | 5 | Privacy/legal package | Execute OpenAI/Railway DPAs; decide ZDR/residency; obtain cache/subprocessor answers and APP 8 plus APP 5/1 counsel sign-off. | A2 / Operator legal/privacy | Start now; before real-patient use/privacy-approved release | 4–8 hours internal; 1–6 weeks elapsed | Signers, counsel, providers | Record countersigned evidence, IDs, dates, decisions, and approved wording in PIA/cross-border docs. Stop before public-copy changes without counsel. | |
There was a problem hiding this comment.
When work such as Privacy/legal package is completed or updated, it has no corresponding #ID or Open-items row, so the documented /issues done <id> and /issues update <id> workflows cannot address it and the open counts omit it; the same applies to six other named queue entries. Give every recommended task an Open-items ID so the universal ledger can track its status and resolution through the supported commands.
AGENTS.md reference: AGENTS.md:L453-L458
Useful? React with 👍 / 👎.
| | #024 | P3 | issue | WebKit e2e `_rsc`-prefetch access-control-checks errors | verify:release:offline on `main` ce32fe170 (2026-07-22) reproduced #023's webkit clause: **6/6 deterministic** failures in `tests/ui-route-coverage.spec.ts` (Therapy Compass; DSM home/comparison; Specifier comparison/map; Differential stream), each a `pageerror … ?_rsc=… due to access control checks` on Next.js RSC prefetch — Chromium + Firefox clean. Not merge-blocking (required gate `test:e2e:pr` is chromium-only; the full webkit matrix is advisory/release-time). Most likely a Playwright route-interception × WebKit interaction, not a Safari user defect. Next: decide (a) allow/mock the `_rsc` routes for the `webkit` e2e project, or (b) confirm real Safari impact — before trusting the full-matrix webkit gate at release. NB the 2 other webkit fails (`ui-stress:412`, `ui-universal-search:210`) passed on isolated re-run = true flake. | session 2026-07-22 (verify:release:offline, `main` ce32fe170); refines #023 | 2026-07-22 | | ||
| | #025 | P2 | task | Activate the three webhooks (operator secrets) | Merged (#968/#1100) + deployed but inert — verified live: `POST /api/webhooks/railway` returns `503 webhook_not_configured`; the Supabase document-change trigger exists but lacks both activation inputs. To turn on: (1) Railway → set `RAILWAY_WEBHOOK_SECRET` + add the `?token=…` webhook URL; (2) set `SLACK_WEBHOOK_URL`/`DISCORD_WEBHOOK_URL` in BOTH the Railway **app/server env** and **GitHub repo secrets**; (3) set one matching document-change secret in the Railway app env as `SUPABASE_INGESTION_WEBHOOK_SECRET` and in Supabase Vault as `ingestion_webhook_secret`, then set the per-environment database GUC `app.ingestion_webhook_base_url` to the deployed app origin. Each path fails closed until fully configured, so this is pure ops. See `docs/webhooks.md` for verification and rotation. | sessions 2026-07-22/24; PRs #968/#1100; docs/webhooks.md | 2026-07-22 | | ||
| | #025 | P2 | task | Activate the three webhooks (operator secrets) | Merged (#968) + deployed but inert — verified live: `POST /api/webhooks/railway` returns `503 webhook_not_configured`. To turn on: (1) Railway → set `RAILWAY_WEBHOOK_SECRET` + add the `?token=…` webhook URL; (2) the chat URLs `SLACK_WEBHOOK_URL`/`DISCORD_WEBHOOK_URL` must be set in BOTH places — the Railway **app/server env** (the receiver forwards deploy alerts via `postChatNotification`, which reads server env, so repo-secret-only leaves the Railway webhook authenticated but returning `delivered:false`) AND as **GitHub repo secrets** (the CI-failure workflow reads `secrets.*`); (3) `SUPABASE_INGESTION_WEBHOOK_SECRET`. Each fails closed until set, so this is pure ops. See docs/webhooks.md. | session 2026-07-22; PR #968; docs/webhooks.md | 2026-07-22 | | ||
| | #026 | P2 | task | Activate the merged Supabase document-change trigger safely | PR #1100 merged the forward migration, schema mirror, contract test, drift evidence and rollback docs to `main`. Before activation, add or prove idempotent recovery for sufficiently old `queued` documents with no open ingestion job. Then, only with explicit approval, verify hosted migration state, apply the committed migration through the normal Supabase path, configure the Vault secret and base-URL GUC, and verify one controlled event. The trigger remains inert until those steps complete. | PR #1100; `docs/webhooks.md` section 3; session 2026-07-24 | 2026-07-22 | |
There was a problem hiding this comment.
Reopening #026 here also deletes its prior resolved/archive row, including the recorded PR #1100 replay and production-state outcome, so the ledger no longer retains an auditable explanation of why the formerly completed item became active again. Preserve that historical resolution and record an explicit reopen/correction transition rather than silently replacing the archived state.
AGENTS.md reference: AGENTS.md:L453-L458
Useful? React with 👍 / 👎.
Summary
RAG impact