Skip to content

test: guard document section nav against Production UI drift - #1371

Merged
cursor[bot] merged 4 commits into
mainfrom
cursor/document-viewer-ci-guards-eac3
Jul 28, 2026
Merged

test: guard document section nav against Production UI drift#1371
cursor[bot] merged 4 commits into
mainfrom
cursor/document-viewer-ci-guards-eac3

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

PR #1311 already fixed and merged the Production UI failures (duplicate document-overview id + obsolete document-viewer section nav in ui-smoke). This follow-up adds cheap regression guards so the same class of drift fails in verify:cheap / unit CI before Production UI.

RAG impact: no retrieval behaviour change — tests and search-chrome contract docs only.

Root cause (already fixed on main via #1311)

  1. DocumentClinicalSummary and the DocumentViewer overview wrapper both claimed id="document-overview"expectDomIntegrity failed.
  2. ui-smoke still drove the retired in-flow “Document viewer sections” nav and required a “Tables and diagrams” sheet row for the lithium demo doc (image_count: 0), which omits that row from the section index.

Prevention in this PR

  • tests/document-section-nav-contract.test.ts — source contracts for single overview-id owner, phone sheet selectors, lithium image_count: 0, and ui-smoke wiring.
  • DOM assertion that DocumentClinicalSummary does not claim document-overview.
  • Document the invariants in docs/search-chrome-behaviour.md §22.

Validation

Clinical governance preflight

  • Not applicable: no ingestion, answer generation, search/ranking, source rendering, privacy, or clinical output behaviour changes.
Open in WebOpen in Cursor

PR #1311 red Production UI twice from duplicate document-overview ids and
smoke still targeting the retired in-flow section nav / missing Images row.
Add cheap ownership contracts and a DOM assertion so verify:cheap catches
that class of regression before the browser gate.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@supabase

supabaseBot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:54 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0cfeb131-6b43-489d-9ea4-29f176716a02

📥 Commits

Reviewing files that changed from the base of the PR and between 7581cfc and 42e6f83.

📒 Files selected for processing (3)
  • docs/search-chrome-behaviour.md
  • tests/document-clinical-summary.dom.test.tsx
  • tests/document-section-nav-contract.test.ts

Comment @coderabbitai help to get the list of available commands.

CircleCI format:check failed on the multi-line regex matcher.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor
cursorBot marked this pull request as ready for review July 28, 2026 16:05
cursoragentand others added 2 commits July 28, 2026 16:06
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor
cursorBot enabled auto-merge (squash) July 28, 2026 16:11
@cursor
cursorBot merged commit 64be97b into mainJul 28, 2026
19 checks passed
@cursor
cursorBot deleted the cursor/document-viewer-ci-guards-eac3 branch July 28, 2026 16:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@cursoragent