test: guard document section nav against Production UI drift - #1371
Conversation
PR #1311 red Production UI twice from duplicate document-overview ids and smoke still targeting the retired in-flow section nav / missing Images row. Add cheap ownership contracts and a DOM assertion so verify:cheap catches that class of regression before the browser gate. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:54 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
CircleCI format:check failed on the multi-line regex matcher. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Summary
PR #1311 already fixed and merged the Production UI failures (duplicate
document-overviewid + obsolete document-viewer section nav in ui-smoke). This follow-up adds cheap regression guards so the same class of drift fails inverify:cheap/ unit CI before Production UI.RAG impact: no retrieval behaviour change — tests and search-chrome contract docs only.
Root cause (already fixed on main via #1311)
DocumentClinicalSummaryand the DocumentViewer overview wrapper both claimedid="document-overview"→expectDomIntegrityfailed.image_count: 0), which omits that row from the section index.Prevention in this PR
tests/document-section-nav-contract.test.ts— source contracts for single overview-id owner, phone sheet selectors, lithiumimage_count: 0, and ui-smoke wiring.DocumentClinicalSummarydoes not claimdocument-overview.docs/search-chrome-behaviour.md§22.Validation
npm run test -- tests/document-section-nav-contract.test.ts tests/document-clinical-summary.dom.test.tsx tests/document-section-index.test.ts tests/header-scroll-hide-contract.test.ts→ 41 passedClinical governance preflight