Skip to content

Refine document top bar and actions sheet - #1381

Merged
BigSimmo merged 3 commits into
mainfrom
agent/document-topbar-actions
Jul 29, 2026
Merged

Refine document top bar and actions sheet#1381
BigSimmo merged 3 commits into
mainfrom
agent/document-topbar-actions

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • remove the redundant target/scope shortcut from the document viewer top bar
  • replace ambiguous plus icons with accessible three-dot document action controls
  • promote the document action sheet to a top-level portal so the floating search composer cannot cover it
  • enlarge and restyle the responsive action layout, with regression coverage for stacking and expanded-state semantics

Verification

  • npm run verify:pr-local
    • Verification not run: the repository's exclusive full/browser lane remained owned by other worktrees during this handoff.
  • npm run verify:ui
    • UI verification not run: the exact 320px Chromium journey was queued behind other repository browser owners and did not start before the bounded local runner timed out.
  • npm run verify:release
    • Not run: this is a draft PR, not a release-confidence claim.
  • node scripts/run-vitest.mjs run tests/document-viewer-shell.dom.test.tsx --reporter=dot — 1 file passed, 4 tests passed
  • npm run check:installed-lock-parity — Next 16.2.12, React 19.2.8, Playwright 1.62.0 match the lockfile
  • npm run check:runtime
  • npm run check:icon-scale
  • npm run check:design-system-contract
  • focused Prettier check and git diff --check

Risk and rollout

  • Risk: Low, page-local document viewer chrome and modal presentation only.
  • Rollback: Revert commit 9233dede9.
  • Provider or production effects: GitHub branch and draft PR only; no deployment or production/provider workflow was run.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded
  • Supabase target and environment configuration are unchanged
  • Service-role keys and private document access remain server-only and unchanged
  • Demo/synthetic content separation is unchanged
  • Source metadata, review status, and outdated/unknown-source behavior are unchanged
  • No clinical decision-support or TGA SaMD behavior changed

Notes

RAG impact: no retrieval behaviour change — this PR only changes document action chrome, responsive styling, and modal stacking.

@coderabbitai

coderabbitaiBot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:40 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d8fa0597-9c51-4c94-a3c0-d9c5cff13894

📥 Commits

Reviewing files that changed from the base of the PR and between f4a3f50 and 9da8ccf.

📒 Files selected for processing (3)
  • src/components/DocumentViewer.tsx
  • tests/document-viewer-shell.dom.test.tsx
  • tests/ui-smoke.spec.ts
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@supabase

supabaseBot commented Jul 29, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo marked this pull request as ready for review July 29, 2026 11:23
@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

@cursoragent Inspect the PR and repository state, identify the root cause of every failing CI check, unresolved review comment, merge conflict, and related defect. Apply the smallest robust fix using existing project patterns and best practices, without unrelated changes. Run Bugbot and all relevant lint, type-check, test, build, and CI-equivalent commands, fix any issues found, then resolve only the review comments that are fully addressed. Summarise the root causes, changes made, validation results, and any remaining blockers.

@BigSimmo
BigSimmo enabled auto-merge (squash) July 29, 2026 11:23
@cursor

cursorBot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

PR #1381 is merged. The earlier red pr-required was not a product defect — Build was cancelled when main was merged into the branch. After a clean main sync, all required checks went green and squash auto-merge landed.

Root causes

ItemCause
Prior CI failure (pr-required)BUILD_RESULT: cancelled after the first main merge cancelled an in-flight Build job — not a code failure
Merge blocked after green CIBranch fell behind main again (BEHIND); git merge-tree was clean
Review threadsNone
BugbotNo cursor[bot] findings
Merge conflictsNone

Changes made

  • Merged origin/main into agent/document-topbar-actions and pushed (9da8ccfb)
  • No DocumentViewer/product code changes — Bugbot + self-review found nothing actionable
  • Opened docs follow-up #1386 so the ledger row lands on main (the post-merge ledger commit missed the squash)

Validation

  • Local: lint, typecheck, Prettier, runtime, lock parity, icon-scale, design-system, document-viewer-shell.dom (4/4)
  • Hosted on synced head: PR required pass, Production UI pass (13m17s), CircleCI pass, Build/Static/Coverage/Safety all pass
  • Bugbot: no findings; no threads to resolve

Remaining

Open in WebOpen in Cursor

Keep the document actions PR current with main so squash auto-merge is not blocked by branch staleness.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo
BigSimmo merged commit b274048 into mainJul 29, 2026
19 checks passed
@BigSimmo
BigSimmo deleted the agent/document-topbar-actions branch July 29, 2026 11:55
BigSimmo added a commit that referenced this pull request Jul 29, 2026
Append one append-only branch-review-ledger row for the completed PR #1381 CI triage after squash-merge. Docs-only; no product, test, or config change.
RAG impact: no retrieval behaviour change - ledger documentation only.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@cursoragent