Skip to content

Fix document phone header reveal without layout shifts - #1389

Merged
BigSimmo merged 4 commits into
mainfrom
codex/chat-document-header-overlay-document-header-overlay-20260729
Jul 29, 2026
Merged

Fix document phone header reveal without layout shifts#1389
BigSimmo merged 4 commits into
mainfrom
codex/chat-document-header-overlay-document-header-overlay-20260729

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • add backward-compatible phoneMotion: "collapse" | "overlay" support to the shared header
  • select overlay motion only for document-viewer-owned routes so returning phone chrome covers the PDF without changing reader geometry
  • keep document browser/PWA scroll owners and composer behavior intact, and add static plus focused Playwright contracts
  • document the document-route exception and no-layout-shift contract

Verification

  • npm run verify:pr-local
    • runtime, installed-lock parity, Prettier, lint, typecheck, and full Vitest passed: 424 passed files; 4373 passed | 3 skipped tests
    • the composite exited at build admission with local EPERM creating the heavyweight gate.lock; isolated npm run build retry passed, including 1,694 static pages and client-bundle secret scan
    • npm run check:rag:fixtures passed: 36 golden cases, 21 suites
  • npm run verify:ui
    • focused current-base Playwright passed: 2 passed (26.0s) for browser-document and compiled standalone-PWA document scroll owners
    • npm run verify:phone-chrome was attempted; runtime and lock parity passed, then focused-test admission was blocked by another worktree's Playwright owner before contracts/browser stages
  • npm run verify:release — not run; provider-backed/release-wide gate was outside the approved scope
  • npm run workflow:design-sweep -- --write-evidence passed
  • project identity confirmed through /api/local-project-id: Clinical KB, clinical-kb:9aa67aafc0d0
  • physical iPhone Safari and cold-launched installed-PWA checks were not run; device access is still required

Risk and rollout

  • Risk: phone-only document header positioning and animation; residual risk is physical iOS Safari/Home Screen paint behavior and broad-UI flakiness not reproduced by the focused journeys
  • Rollback: revert the overlay implementation commit to restore universal collapse motion
  • Provider or production effects: GitHub branch/PR/CI and merge were explicitly requested; no Supabase, OpenAI, Railway CLI, or other provider calls were made

RAG impact: no retrieval behaviour change — phone document chrome and browser tests only.

Clinical Governance Preflight

Not applicable: no ingestion, retrieval/ranking, source rendering, document access, privacy, production environment, or clinical output behavior changed.

Notes

  • Review ledger: no high-confidence findings at reviewed head; physical iPhone acceptance remains outstanding.

@coderabbitai

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:52 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6e26d388-4629-4e69-a87c-e16baf748f3a

📥 Commits

Reviewing files that changed from the base of the PR and between 855aa29 and d23091c.

📒 Files selected for processing (12)
  • docs/branch-review-ledger.md
  • docs/search-chrome-behaviour.md
  • scripts/phone-chrome-plan.mjs
  • src/app/globals.css
  • src/components/clinical-dashboard/global-search-shell.tsx
  • src/components/clinical-dashboard/master-search-header.tsx
  • src/components/clinical-dashboard/use-hide-on-scroll.ts
  • tests/header-scroll-hide-contract.test.ts
  • tests/ui-overlay-css-contract.test.ts
  • tests/ui-phone-scroll.spec.ts
  • tests/ui-smoke.spec.ts
  • tests/verify-phone-chrome.test.ts

Comment @coderabbitai help to get the list of available commands.

@supabase

supabaseBot commented Jul 29, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo merged commit 7422900 into mainJul 29, 2026
19 checks passed
@BigSimmo
BigSimmo deleted the codex/chat-document-header-overlay-document-header-overlay-20260729 branch July 29, 2026 13:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo