Skip to content

Clean stale frontend identity and CSS - #14

Merged
BigSimmo merged 1 commit into
mainfrom
codex/stale-css-code-cleanup
Jun 4, 2026
Merged

Clean stale frontend identity and CSS#14
BigSimmo merged 1 commit into
mainfrom
codex/stale-css-code-cleanup

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • Removes duplicated local-project identity helpers from the dashboard and document viewer by sharing one browser-safe helper.
  • Replaces a non-functional Tailwind arbitrary border utility that referenced undefined --accent with the existing --border token.
  • Makes no dependency, env, Supabase data, or deployment changes.

Verification

Local verification under Node 22:

  • npm run lint passed
  • npm run typecheck passed
  • npm run test passed: 39 files, 240 tests
  • npm run build passed
  • npm run test:e2e:chromium passed; Playwright last-run marker reports passed with no failed tests
  • git diff --check HEAD -- passed

Known deferrals

  • npm run format:check is still a known repo-wide baseline issue and will be fixed in a separate format-only branch.
  • npm ls --depth=0 reports transitive optional native/wasm packages as extraneous even after npm ci; this is deferred to a separate npm tree-noise investigation.
  • Larger architecture cleanup for ClinicalDashboard.tsx, DocumentViewer.tsx, rag.ts, and oversized tests is intentionally out of scope.

Risk notes

  • The branch touches client UI paths, so Chromium e2e was run.
  • No ignored files, env files, logs, caches, private data, or generated artifacts were staged.

@BigSimmo
BigSimmo merged commit a57ca27 into mainJun 4, 2026
4 checks passed
@BigSimmo
BigSimmo deleted the codex/stale-css-code-cleanup branch June 4, 2026 03:56
BigSimmo added a commit that referenced this pull request Jul 22, 2026
)
- #8 "dead href builders" is NOT dead code: documentReaderHref /
documentEvidenceHref are live via the mock wrappers
(mockDocumentReaderHref / mockDocumentEvidenceHref) used by the rendered
/mockups/document-search/* routes, and are covered by
tests/document-flow-routes.test.ts. Removing them breaks the build. Moved
to Resolved/archive as a false positive (only the production non-mock
hrefs are unlinked from prod UI — a wiring gap, not dead code).
- Fix#14 Source path document-viewer/signed-image.tsx ->
clinical-dashboard/signed-image.tsx (the document-viewer/ path never
existed; it was failing docs:check-links on main).
Docs-only. No code/protected-surface edits, no provider/CI/dashboard action.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
BigSimmo pushed a commit that referenced this pull request Jul 22, 2026
…ed (#14)
The 44-case eval:quality report printed 'Estimated cost USD: n/a' even with
the RAG_EVAL_*_USD_PER_MILLION rates set (PR #1017): every extractive or
unsupported case makes no provider call, its per-case estimate was null, and
the all-or-nothing total nulled on any null case. A no-usage case costs
exactly $0 when rates are configured — null stays reserved for
rates-unconfigured, so the total keeps meaning 'cannot estimate'. Aggregation
pin added.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EXsJcLrbZUXwnBeG91cVo9
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo