Skip to content

docs(issues): capture CI/merge findings and a merged-PR gate gap from PR babysitting - #1421

Merged
BigSimmo merged 8 commits into
mainfrom
claude/pr-bundling-rules-churn-fuaw5a
Jul 30, 2026
Merged

docs(issues): capture CI/merge findings and a merged-PR gate gap from PR babysitting#1421
BigSimmo merged 8 commits into
mainfrom
claude/pr-bundling-rules-churn-fuaw5a

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm run check:outstanding-issues — self-test passed; guard passed: 123 rows (61 open, 62 archived), unique ids, next-id=129 above the highest
  • npx prettier --check docs/outstanding-issues.md — clean
  • Verification not run: npm run verify:ui / eval:* / check:production-readiness — no UI, retrieval, ranking, ingestion, privacy, or Supabase behavior changed; this is a ledger-only docs append.

RAG impact: no retrieval behaviour change — no file under src/lib/rag/**, clinical-search, retrieval-selection, ranking-config, the eval harness, the golden fixture, or the retrieval RPCs is touched.

Risk and rollout

  • Risk: none to runtime or CI. Documentation/memory-ledger change only; no script, workflow, or gate behavior changed.
  • Rollback: revert the commit; nothing depends on it. The ledger is not strictly append-only like docs/branch-review-ledger.md, but no existing row was edited — only new rows appended and the next-id marker bumped.
  • Provider or production effects: None. No provider-backed command was run.

Clinical Governance Preflight

Not applicable — the diff touches only docs/outstanding-issues.md. No ingestion, answer generation, search/ranking, source rendering, document access, privacy, production environment, or clinical output behavior is touched.

Notes

  • Checked for a next-id allocation race before pushing (per the repo's own #112 finding about exactly this race): confirmed origin/main's marker was still 117 immediately before the first push, so #117/#118 were free at that time. A concurrently-open draft PR (#1420) also claimed #117 for an unrelated finding and landed first on main — exactly the race this row's own #112 predicted. Codex flagged this PR's #117/#118 wording separately (both fixed and resolved — see thread history); a follow-up commit from another session then renumbered this PR's rows to #126/#127 and bumped the marker to 128 once the collision materialized, verified clean (check:outstanding-issues passed, no duplicate ids). #128 was added afterward while re-checking PR fix(chrome): overlay the phone header so hiding it never moves content #1396 during the same babysitting pass.

Generated by Claude Code

#117: this repo's CI (on: pull_request with default types) doesn't
retrigger on the draft-to-ready transition, only on
opened/synchronize/reopened — a marked-ready PR can sit with a
minimal check set until an actual new commit lands. #118: GitHub's
update-branch API doesn't honor the merge=union .gitattributes driver
on docs/branch-review-ledger.md, so it can 422 with a false conflict
that a local git merge resolves cleanly. Both observed today on PR
#1406.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Re9ERtQwJ82ErbAnahAhsa
@supabase

supabaseBot commented Jul 30, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • docs/outstanding-issues.md
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9cb2264e-58d2-48de-8bc9-6d4d6934cda3

📥 Commits

Reviewing files that changed from the base of the PR and between c0ceee2 and d2568ce.

📒 Files selected for processing (1)
  • docs/outstanding-issues.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The outstanding-issues ledger advances its next-ID marker to 119 and adds open items #117 and #118 covering draft-to-ready CI triggering and update-branch merge conflicts.

Changes

Outstanding issues ledger

Layer / File(s)Summary
Update issue tracking ledger
docs/outstanding-issues.md
Advances the issues:next-id marker to 119 and adds open items #117 and #118 with their respective remediation details.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers:claude, cursoragent

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Title check✅ PassedThe title matches the doc-only change and highlights the CI/merge findings and gate gap.
Description check✅ PassedThe description follows the template and includes summary, verification, risk/rollout, governance, and notes with the required details.

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo marked this pull request as ready for review July 30, 2026 06:50

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:c0ceee291d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threaddocs/outstanding-issues.md Outdated
Comment threaddocs/outstanding-issues.md Outdated
claudeand others added 4 commits July 30, 2026 06:59
#125: spell out that ready_for_review must be added alongside the
existing pull_request.types defaults, not replace them.
#126: qualify the update-branch fallback push with the same
explicit user confirmation the provider boundary already requires.
Keep main's #125 (therapy-nav stale spec) and renumber this PR's
captured findings to #126/#127 so next-id stays unique.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
PR #1396 repeatedly declared physical-device Safari/PWA acceptance
(docs/phone-chrome-physical-acceptance.md) as required before merge
because headless Chromium cannot certify Safari chrome minimisation
or cold-launch PWA paint, then merged with the checklist still blank.
Also notes a related missing pre-paint/cold-load hydration test the
same PR's review flagged but never filed.
@BigSimmoBigSimmo changed the title docs(issues): capture two CI/merge findings from PR babysittingdocs(issues): capture CI/merge findings and a merged-PR gate gap from PR babysittingJul 30, 2026
BigSimmoand others added 3 commits July 30, 2026 16:29
# Conflicts:
#	docs/outstanding-issues.md
npx prettier --write after merging main (9e2fe44) — a table cell
width shifted during the merge and format:check would have caught it.
@BigSimmo
BigSimmo merged commit 018673f into mainJul 30, 2026
23 checks passed
@BigSimmo
BigSimmo deleted the claude/pr-bundling-rules-churn-fuaw5a branch July 30, 2026 09:10
BigSimmo pushed a commit that referenced this pull request Jul 30, 2026
Sixth conflict today, and the first that auto-merged *wrongly*: git's text
merge concatenated both tables, duplicating all 63 open rows. PR #1421 had
landed on main using #128/#129/#130 — the exact id collision #112 describes —
so both sides had those ids with different content and the merge kept both.
`npm run check:outstanding-issues` caught it and stated the correct resolution
verbatim: renumber the incoming rows above the marker and bump it, rather than
taking one side wholesale and dropping the other's rows. Done exactly that —
main's table is authoritative, this branch's four rows renumber to
#131/#132/#133/#134, marker to 135. Verified both sides' rows survive:
main's #128-#130 and mine are all present and distinct.
Worth noting main's new #129 (`update-branch` API does not honour the
`merge=ledger` driver) is the server-side twin of my #134 (the driver is absent
wherever `npm install` was skipped). Same root cause from two directions.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Akwz3Sdms8uJ5AkDt3CduY
BigSimmo added a commit that referenced this pull request Jul 30, 2026
…indings (#1424)
* docs(ledger): record PR #1400 closeout and capture three unrecorded findings
Documentation only — two ledger files, no code.
**Review closeout for PR #1400** appended with `ledger:append` (never
hand-written), recording the 17 findings fixed, the verification behind each,
and the post-merge check that all 8 commits are ancestors of main with the 4
changed files byte-identical.
**Three findings from that session that nothing else records:**
- `#125` — `@codex fix` produced 11 commits across a branch named `work`,
none fetchable, the same finding rewritten four times. It reads as success
while the branch is unchanged, which is the actual hazard.
- `#126` — both client-side push guards are inert for agent pushes:
`gh` absent makes the auto-merge sentinel fail open, and `core.hooksPath`
is set only by a local install. They protect the environment least likely to
need them.
- `#127` — this ledger's fixed-width padding makes one row's edit re-pad all
59, so it conflicts on nearly every main advance; each conflict silently
stopped all CI on #1400 via `#116`. Records that `merge=union` is the wrong
fix, with the evidence.
CircleCI was deliberately not filed — already captured as `#122`. Checked
before writing rather than after.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Akwz3Sdms8uJ5AkDt3CduY
* docs(issues): correct unsafe pull_request_target advice in #129
Review caught a real problem in the guidance I filed, not in code: #129's
next-action suggested moving *both* push guards server-side into a
`pull_request_target` job. That context carries secrets and a write token, and
a format check must execute PR-head code — including the dynamic
`prettier.config.*` this very PR taught the guard to load. That is the classic
privileged-context vector, and `.github/workflows/pr-policy.yml` already avoids
it deliberately by checking out only `github.workflow_sha`.
Corrected, and the row now records why the whole idea was unnecessary:
formatting is already enforced server-side by `Static PR checks` running
`format:check` on ordinary `pull_request` CI, so the guard's only unique value
is failing fast before the push. Only the metadata-only auto-merge sentinel
could safely live in a target job.
Bad advice in a durable ledger is worse than no advice — someone would have
acted on it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Akwz3Sdms8uJ5AkDt3CduY
* fix(issues): repair the duplicated table from the sixth main merge
Sixth conflict today, and the first that auto-merged *wrongly*: git's text
merge concatenated both tables, duplicating all 63 open rows. PR #1421 had
landed on main using #128/#129/#130 — the exact id collision #112 describes —
so both sides had those ids with different content and the merge kept both.
`npm run check:outstanding-issues` caught it and stated the correct resolution
verbatim: renumber the incoming rows above the marker and bump it, rather than
taking one side wholesale and dropping the other's rows. Done exactly that —
main's table is authoritative, this branch's four rows renumber to
#131/#132/#133/#134, marker to 135. Verified both sides' rows survive:
main's #128-#130 and mine are all present and distinct.
Worth noting main's new #129 (`update-branch` API does not honour the
`merge=ledger` driver) is the server-side twin of my #134 (the driver is absent
wherever `npm install` was skipped). Same root cause from two directions.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Akwz3Sdms8uJ5AkDt3CduY
* docs: record PR 1424 review
---------
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@BigSimmo@claude@cursoragent