Skip to content

test(ui): add jsdom coverage for ModeActionPopup and DocumentSearchResultsPanel state matrix - #1469

Merged
BigSimmo merged 7 commits into
mainfrom
codex/add-coverage-for-loading-and-error-states
Jul 30, 2026
Merged

test(ui): add jsdom coverage for ModeActionPopup and DocumentSearchResultsPanel state matrix#1469
BigSimmo merged 7 commits into
mainfrom
codex/add-coverage-for-loading-and-error-states

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Motivation

  • Close outstanding recommendation Add risk labels to document classification #107 by exercising component state matrices (loading, empty, error, disabled, and transition behaviour) in the jsdom/unit tier rather than relying only on Playwright smoke paths.

Description

  • Add tests/mode-action-popup.dom.test.tsx to cover ModeActionPopup open/close, keyboard navigation, action execution, focus restoration, mode selection and disabled-mode behaviour.
  • Extend tests/document-search-record-fault.dom.test.tsx with jsdom cases that assert the DocumentSearchResultsPanel loading → settled-empty transition, empty-query home actions, and unavailable/error reporting.
  • Archive the ledger task by updating docs/outstanding-issues.md to mark #107 as resolved with the executing coverage as the disposition.
  • Commit made on branch work with message test(ui): cover component state transitions.

Testing

  • Ran the focused tests with npm test -- --run tests/mode-action-popup.dom.test.tsx tests/document-search-record-fault.dom.test.tsx and the added tests passed locally (2 files, 10 tests; all green).
  • Ran repository verification gates: npm run verify:cheap (full cheap gate) completed successfully; Vitest run: 437 test files / 4,580 tests passed with 4 skipped.
  • Ran supporting checks: npm run check:outstanding-issues (guard validated and Add risk labels to document classification #107 archived), npm run format -- --write and npm run format:changed (formatting clean), and npm run check:rag:fixtures (offline RAG fixtures passed).
  • Per-PR dry-run npm run verify:pr-local -- --dry-run --files ... produced the expected verification plan with no blocking provider-backed checks.
  • No provider-backed or live-hosted services were called during verification.

Codex Task

@supabase

supabaseBot commented Jul 30, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:59 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5127299d-74d8-4eb1-b30c-2a503c0b9c14

📥 Commits

Reviewing files that changed from the base of the PR and between 936ec07 and 0784c15.

📒 Files selected for processing (4)
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md
  • tests/document-search-record-fault.dom.test.tsx
  • tests/mode-action-popup.dom.test.tsx

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:d6f190207f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadtests/mode-action-popup.dom.test.tsx
@BigSimmoBigSimmo added the skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR label Jul 30, 2026
@BigSimmo
BigSimmo merged commit 447b104 into mainJul 30, 2026
23 checks passed
@BigSimmo
BigSimmo deleted the codex/add-coverage-for-loading-and-error-states branch July 30, 2026 18:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codexskip-branch-syncOpt out of hosted pr-branch-sync / update-branch on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo