perf: reduce Therapy startup and sidebar layout work

[BigSimmo]

Summary

• Add opt-in, privacy-first server-side Sentry error tracking that is inert without SENTRY_DSN and scrubs request, user, body, breadcrumb, and clinical content before export.
• Surface conservative, normalized source-governance metadata in the RAG prompt so generation can see provenance state without inventing adverse unverified status for empty, index-only, or partial-sibling documents.metadata.
• Document the privacy envelope, operator approval checklist, and rollback path in docs/error-tracking.md.

RAG impact: no retrieval behaviour change — prompt presentation only adds conservative normalized source-governance metadata; retrieval, ranking, and source selection are unchanged.

Verification

• npm run verify:pr-local
• Focused Vitest for tests/error-tracking.test.ts, tests/rag-source-governance-prompt.test.ts, and tests/source-metadata.test.ts
• npm run eval:rag:offline — 36/36 golden retrieval cases
• npm run check:production-readiness:ci returned READY (offline; expected missing-env warnings)
• npm run build succeeded for production instrumentation wiring
• Merged origin/main and resolved Codex Cloud git-remote helper conflicts; git merge-tree vs origin/main is clean
• UI verification not run: no UI, routing, styling, or browser-behavior changes
• Live answer-generation quality evaluation not run — OpenAI/provider interaction requires explicit owner approval

Risk and rollout

• Risk: medium; optional Sentry path is disabled unless configured, but prompt wording changes answer-generation context and should land only with owner acceptance of offline evidence or an approved live answer-quality check.
• Rollback: revert the squash-merge commit on main, remove SENTRY_DSN and restart services if observability was enabled, and confirm prompts no longer emit the Source governance line.
• Provider or production effects: None unless an operator explicitly sets SENTRY_DSN; no browser DSN, tracing, or source-map upload is configured.

Clinical Governance Preflight

• Source-backed claims still require linked source verification before clinical use
• No patient-identifiable document workflow was introduced or expanded without explicit governance approval
• Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
• Service-role keys and private document access remain server-only
• Demo/synthetic content remains clearly separated from real clinical sources
• Source metadata, review status, and outdated/unknown-source behavior remain conservative
• Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

• Empty/{}/index-only governance metadata remains unrecorded in prompts; partial sibling fields use neutral unknown rather than inventing adverse unverified; explicit stored clinical_validation_status: "unverified" from upload is preserved.
• Optional Sentry init failures are swallowed so observability cannot block production boot.
• Merge remains gated on approved live answer-quality verification or an explicit owner decision to accept the offline-only evidence.

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:39 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e7dea63b-ba13-47cc-8d50-becf952f4964

📥 Commits

Reviewing files that changed from the base of the PR and between 2cdb950 and 67d5cb9.

📒 Files selected for processing (19)

• .github/workflows/ci.yml
• docs/branch-review-ledger.md
• docs/outstanding-issues.md
• docs/scripts-index.md
• public/therapy-compass-data/therapies-home.211dab554c4ec62d.json
• public/therapy-compass-data/therapies-home.json
• public/therapy-compass-data/therapies-index.4b4ee988e0ff84e2.json
• public/therapy-compass-data/therapies-index.json
• scripts/build-therapies-index.mjs
• scripts/check-bundle-budget.mjs
• scripts/lib/escape-false-openai-key-signatures.mjs
• src/components/clinical-dashboard/use-hide-on-scroll.ts
• src/components/therapy-compass/data/generated-assets.ts
• src/data/therapies-index.json
• tests/escape-false-openai-key-signatures.test.ts
• tests/header-scroll-hide-contract.test.ts
• tests/therapy-compass-mode-wiring.test.ts
• tests/ui-phone-scroll-page-owned.spec.ts
• tests/use-hide-on-scroll.test.ts

📝 Walkthrough

Walkthrough

This PR splits the Therapy Compass dataset into content-addressed home, index, and full catalogue assets with legacy aliases, updates the build script, bindings, and data hook to select the correct catalogue per route, and adds caching rules. It also hardens the bundle-budget script and CI/Docker install steps, removes sidebar transition logic, adds viewport-resize handling to scroll-hide behavior, and updates review documentation.

Changes

Therapy catalogue assets

Layer / File(s)	Summary
Catalogue generation and asset validation scripts/build-therapies-index.mjs, public/therapy-compass-data/therapies-home.json, public/therapy-compass-data/therapies-home.f68f0bb9623bc42a.json, public/therapy-compass-data/therapies-index.7cd59ff6765d15f8.json, src/components/therapy-compass/data/generated-assets.ts, next.config.ts	The build script resolves the source dataset via manifest fallback, generates a compact home projection, produces content-addressed full/index/home assets plus legacy aliases, writes generated-assets.ts, and validates hashes and aliases in check mode. Caching rules add immutable caching for hashed filenames and revalidation for aliases.
Route-specific catalogue loading src/components/therapy-compass/bindings.tsx, src/components/therapy-compass/data/use-therapy-data.ts	TcProvider selects "home", "index", or "full" per screen; the data hook resolves catalogue files through THERAPY_CATALOGUE_ASSETS instead of hardcoded filenames.
Catalogue wiring and route validation tests/therapy-compass-data-recovery.dom.test.tsx, tests/therapy-compass-pathways.test.ts, tests/therapy-compass-mode-wiring.test.ts, tests/ui-route-coverage.spec.ts, tests/ui-therapy-nav-scroll.spec.ts	Tests use generated asset constants, verify legacy alias byte-equality, check immutable/revalidation caching, and update fixture filename allowlists to accept hashed therapy filenames.

Build and CI hardening

Layer / File(s)	Summary
Bundle budget script refactor and tests scripts/check-bundle-budget.mjs, tests/bundle-budget.test.ts	Adds BUNDLE_BUDGET_ROOT override, EXIT_FAILSAFE_MS, measureChunkPaths, exitProcess, and runBundleBudgetCheck, returning status codes instead of exiting directly; tests cover streaming measurement, exit behavior, and an end-to-end CLI run.
CI timeout and Docker install retries .github/workflows/ci.yml, Dockerfile, Dockerfile.worker	CI invokes the checker script directly with a three-minute step timeout. Both Dockerfiles retry npm ci up to three attempts with fetch retries and backoff delays.

Sidebar transition removal

Layer / File(s)	Summary
Remove sidebar transition wiring src/components/ClinicalDashboard.tsx, src/components/clinical-dashboard/global-search-shell.tsx, src/components/clinical-dashboard/use-sidebar-column-transition.ts	Removes useSidebarColumnTransitionReady and its usages, deleting the hook file and conditional grid-transition classes; sidebar sizing remains static.

Viewport-resize scroll-hide handling

Layer / File(s)	Summary
Viewport-height detection and rebasing src/components/clinical-dashboard/use-hide-on-scroll.ts, tests/use-hide-on-scroll.test.ts, tests/ui-phone-scroll-page-owned.spec.ts	computeScrollHideUpdate accepts a viewport-height-changed flag and preserves hidden state on geometry changes. The hook tracks previous viewport height, resets it on deactivation, and registers resize listeners for both reporters. Tests cover viewport-shrink/grow scenarios and a "settled" status assertion.

Review documentation

Layer / File(s)	Summary
Record review and issue status docs/branch-review-ledger.md, docs/outstanding-issues.md	Adds branch-review ledger records for reopen prep, reconciliation, and PR #1489 outcomes. Issue #117 documentation records the home/pathways/search payload split.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
participant TcProvider
participant useTherapyData
participant THERAPY_CATALOGUE_ASSETS
participant TherapyCatalogueJSON
TcProvider->>useTherapyData: Select home, index, or full catalogue
useTherapyData->>THERAPY_CATALOGUE_ASSETS: Resolve hashed asset filename
useTherapyData->>TherapyCatalogueJSON: Request selected JSON asset

Loading

sequenceDiagram
participant CI
participant CheckBundleBudgetScript
participant runBundleBudgetCheck
participant exitProcess
CI->>CheckBundleBudgetScript: Run script directly with timeout
CheckBundleBudgetScript->>runBundleBudgetCheck: Measure chunks and validate budget
runBundleBudgetCheck->>exitProcess: Return status code
exitProcess->>CI: Terminate process with code

Loading

Possibly related PRs

• BigSimmo/Database#912: Directly extends the same Therapy Compass catalogue generation, bindings, and hashed-asset selection logic.
• BigSimmo/Database#608: Introduces the bundle-budget script this PR refactors with runBundleBudgetCheck, exitProcess, and measureChunkPaths.
• BigSimmo/Database#1270: Modifies the same use-hide-on-scroll.ts geometry-rebase and phone scroll-hide logic extended here for viewport resize.

Suggested reviewers:claude

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main performance changes to Therapy startup and sidebar layout work.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:835a66af0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[BigSimmo]

@codex review PR

[BigSimmo]

@cursoragent run bugbot review for PR and resolve merge conflict

[cursor]

Merge conflict cleared and Bugbot triage finished on PR #1489. Tip is f7f24dbf (mergeable; CI still settling).

Merge conflict

Only conflict was docs/outstanding-issues.md vs origin/main.

• Kept main’s open queue (HEAD-only open rows were already archived on main).
• Preserved this PR’s #117 hashed catalogue filename note.
• git merge-tree vs origin/main is clean; check:outstanding-issues passed.

Bugbot review

No unresolved cursor[bot] Bugbot threads on the PR. Ran a Bugbot-style pass on the product delta:

Severity	Location	Finding	Disposition	Evidence
—	PR product tip	No P0–P2 product defects in payload split, loader wiring, cache headers, or sidebar transition removal	no issue	Vitest therapy suites 20/20; build-therapies-index.mjs --check current (205 records)
P2 (prior Codex)	scripts/build-therapies-index.mjs	Unversioned catalogue URLs 404 for deployment-straddling clients	already fixed (ff270e957)	Aliases present and byte-identical; --check fails on alias drift
Residual	Future hashed-asset regen	Prior content-hashed files need retention for open tabs after later data bumps	leave open	Process risk only; aliases cover pre-PR clients

Checks

• Ran: conflict resolution, check:outstanding-issues, build-therapies-index --check, therapy Vitest 20/20, merge-tree clean, push.
• Not run: full verify:cheap / Playwright / Lighthouse (provider/production).

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit:ff270e9576

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

This PR optimizes Therapy Compass startup and sidebar layout work by introducing content-addressed (hashed) therapy catalogue assets with a generated manifest, loading smaller route-appropriate payloads (home vs search vs detail), and removing a costly grid-template-columns transition during sidebar toggles.

Changes:

• Generate and consume a manifest-driven set of hashed Therapy Compass catalogue JSON assets (plus a compact home projection) to reduce client parse/work and enable immutable caching.
• Route-select the appropriate therapy dataset (home / index / full) via useTherapyData + Therapy Compass bindings, and update tests/fixtures accordingly.
• Remove the sidebar grid-column transition wiring from the main shell owners to avoid layout animation jank.

Reviewed changes

Copilot reviewed 13 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/ui-therapy-nav-scroll.spec.ts	Updates offline fixture allowlist to accept hashed therapy catalogue asset filenames.
tests/ui-route-coverage.spec.ts	Same fixture allowlist update for route-coverage Playwright runs.
tests/therapy-compass-pathways.test.ts	Switches pathway integrity test to read the manifest-provided full catalogue asset.
tests/therapy-compass-mode-wiring.test.ts	Asserts hashed assets exist, verifies legacy aliases match, and updates loader expectations to manifest usage.
tests/therapy-compass-data-recovery.dom.test.tsx	Updates fetch mocks/assertions to use manifest-driven asset names (home/full).
src/components/therapy-compass/data/use-therapy-data.ts	Adds home catalogue option and loads catalogue JSON via THERAPY_CATALOGUE_ASSETS[...] (manifest).
src/components/therapy-compass/data/generated-assets.ts	New generated manifest exporting hashed therapy asset filenames.
src/components/therapy-compass/bindings.tsx	Selects home vs index vs full catalogue based on Therapy Compass route/screen.
src/components/ClinicalDashboard.tsx	Removes sidebar grid-column transition gating (drops useSidebarColumnTransitionReady).
src/components/clinical-dashboard/global-search-shell.tsx	Same: removes grid-column transition gating for the standalone search shell.
scripts/build-therapies-index.mjs	Generates compact home projection, writes hashed assets + TS manifest, and validates assets via --check.
public/therapy-compass-data/therapies-home.json	Adds the compact home projection dataset.
next.config.ts	Adds immutable caching headers for content-addressed therapy catalogue assets.
docs/outstanding-issues.md	Updates the Therapy Compass perf tracking entry to reference the hashed asset name.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[BigSimmo]

Temporarily paused during the owner-authorized ordered merge sweep so main cannot move between exact-head review and merge. The branch and all commits are preserved; this PR will be reopened at its verified place in the queue.

[BigSimmo]

@cursoragent this PR will be re-opened soon. Please resolve any failing CI, run bugbot and resolve any bugbot comments against current repo and fix any merge conflicts and also fix any errors and address and fix all comments or suggestions that are likely to improve the PR and Codebase. Please implement smallest required fix according to best code practices. Check your work. Leave this PR closed for now but still make all these changes and run the review. I want it ready to go for when I re-open it.

[cursor]

PR #1489 is ready to reopen and still closed. Branch tip is 5c85e6ff on codex/address-performance-issues-in-package.

Done

• Merge conflict cleared against current origin/main (docs/outstanding-issues.md only). Kept main’s open queue; kept this PR’s #117 home/index note. git merge-tree is clean (0 behind / 8 ahead).
• Bugbot / review threads: none unresolved. Fresh product pass found no P0–P2 defects.
• Small fixes landed:
  • Deleted dead use-sidebar-column-transition.ts (imports were already gone)
  • Added must-revalidate cache headers for unversioned therapy aliases
  • Added a wiring test for hashed-immutable vs alias-revalidate headers

Checks

• Therapy Vitest 21/21, build-therapies-index --check (205), check:outstanding-issues, format:check, typecheck
• Not run: full verify:cheap / Playwright / Lighthouse

Note

GitHub may still show the closed PR head as b4e0b60d until you reopen; the branch itself is already at 5c85e6ff. After reopen, mergeability/CI should evaluate the synced tip.

[cursor]

PR #1489 reopen prep is done on codex/address-performance-issues-in-package tip 5c85e6ff. Left closed as requested.

Merge conflict

• Synced origin/main (was 9 behind / CONFLICTING on docs/outstanding-issues.md).
• Kept main’s open queue; preserved this PR’s #117 home/index split note.
• git merge-tree --write-tree origin/main HEAD is clean; branch is 0 behind / 8 ahead.

Bugbot / review threads

• No unresolved review threads (Codex P2 aliases + Copilot comment/docs notes already fixed earlier).
• Fresh Bugbot-style product pass: no P0–P2 product defects.

Severity	Location	Finding	Disposition
—	Product tip	Payload split, loader wiring, aliases, cache headers, sidebar transition removal	clear
P3 cleanup	use-sidebar-column-transition.ts	Dead helper left after import removal	deleted
Hardening	next.config.ts	Unversioned aliases lacked explicit revalidation	must-revalidate headers added + wiring test

Checks run

• check:outstanding-issues passed
• build-therapies-index.mjs --check current (205 records)
• Therapy Vitest 21/21 (incl. new cache-header contract)
• format:check clean; typecheck clean
• Not run: full verify:cheap / Playwright / Lighthouse (provider/production)

On reopen

GitHub’s closed-PR head may still show b4e0b60d until reopen; the branch tip is already 5c85e6ff. After reopen, mergeability/CI should evaluate the synced tip.

[BigSimmo]

@CodeRabbit please review PR

[coderabbitai]

@BigSimmo: I’ll review the changes in #1489, focusing on the Therapy asset generation/loading contract, cache headers, route-mode behavior, and sidebar transition removal.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[BigSimmo]

@coderabbitai please run a new review of this closed PR for me

[coderabbitai]

@BigSimmo: Starting a new full review of #1489, including the previously reviewed changes.

✅ Action performed

Full review finished.

---

Your included review limit is currently reached under our Fair Usage Limits Policy. Your recent PR review activity is in the 95th percentile or higher among CodeRabbit users, so adaptive limits apply. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 41 minutes.

[cursor]

Deep fix: Build bundle-budget hang (why “re-run” kept failing)

Root cause:Build was not failing tests. npm run build succeeded, then check:bundle-budget printed success (within tolerance / fixture assertion passed) and never exited. The job hit timeout-minutes: 25 → Build = cancelled (orphan MainThread), and PR required stayed red.

Why re-run kept failing: “Re-run failed jobs” skips cancelled jobs. Only PR required re-ran, saw Build still cancelled, and failed again (attempt 3 on the same tip).

Durable fix (caced05a):

1. Script: stream chunk measurement (no retained multi‑MiB buffers); every exit path uses exitProcess (stdout drain + 1s hard failsafe); print [bundle-budget] done.
2. CI: run node scripts/check-bundle-budget.mjs directly with timeout-minutes: 3 on the step — a stuck exit fails the step as failure (re-runnable), instead of cancelling the whole Build job
3. Tests: exitProcess unit coverage + CLI subprocess must exit 0 with done. within 5s

Verified locally: vitest bundle-budget 14/14; check:bundle-budget → done.; check:github-actions passed.

Tip will move with ledger append. Let the new CI run finish — do not push again mid-run. Merge left to you.

[cursor]

Review + stress test — bundle-budget hang fix

Verdict: Fix is sound. No P0–P2 remaining in this delta. Tip 2cdb950c (product 7ecc4e18 + ledger).

What was wrong (confirmed)

Build printed bundle-budget success, then never exited → 25m job timeout → cancelled. “Re-run failed jobs” skipped cancelled Build → PR required loop.

Fix review

Layer	Assessment
Streamed measureChunkPaths	Correct; avoids retaining all chunk buffers
exitProcess drain + 1s failsafe	Correct; covers stuck stdio drain
CI timeout-minutes: 3 on step + direct node	Correct; stuck exit becomes failure (re-runnable), not job cancelled
[bundle-budget] done. marker	Good observability
Review follow-up (7ecc4e18)	Unexpected throws now always hit exitProcess; buffer clear only after fixture check

Stress evidence (local)

• Vitest bundle-budget 14/14
• Real .next CLI ×40: p95 ~113ms, max ~118ms, all printed done. and exited 0
• Concurrent ×10: max ~338ms, all exit 0
• Failsafe ×100 stuck-drain: 0 misses
• Blocked/paused stdout, npm run, over-budget (exit 1), 800-file synthetic tree: all OK
• check:github-actions passed; merge-tree clean vs main after sync

Residual risk

If console.log itself blocked on a full pipe beforeexitProcess runs, the 1s failsafe would not start — the 3m step timeout is the backstop for that case. Observed CI hang was after logs flushed, which this fix targets.

Synced origin/main (behind-but-clean / GitHub DIRTY). Let the new required CI finish; don’t push mid-run. Merge left to you.

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@public/therapy-compass-data/therapies-home.f68f0bb9623bc42a.json`:
- Around line 3928-3929: Update the upstream therapy catalogue record that
generates the task-centred-practice entry so its slug and name use plain “k”
rather than the \u006b escape; ensure the generated therapies-home asset emits
task-centred-practice and Task-centred practice, and verify existing hard-coded
routes, tests, or links continue resolving that slug.
In `@public/therapy-compass-data/therapies-index.7cd59ff6765d15f8.json`:
- Around line 720-724: Stop deriving modality from tags in the therapy index
generator, and inspect all route, filter, and facet consumers before choosing
removal versus curated values. Update the generator and affected records so
clinically unsupported modality values are omitted or replaced only with
source-backed values, including the ECT, rTMS, cognitive stimulation, MBT, TFP,
psychoanalysis, and psychodynamic entries; preserve conservative behavior when
no curated value exists.
In `@tests/bundle-budget.test.ts`:
- Around line 50-84: Update both exitProcess calls in the exitProcess tests to
cast their mock exitImpl and stdout objects to the inferred option types,
matching the existing setTimer cast where needed. Keep the test behavior and
mock implementations unchanged while ensuring both strict TypeScript call sites
compile.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e0e1ffd9-2289-4342-b08b-7ec6f34a4baf

📥 Commits

Reviewing files that changed from the base of the PR and between fe0d7e0 and 2cdb950.

📒 Files selected for processing (20)

• .github/workflows/ci.yml
• Dockerfile
• Dockerfile.worker
• docs/branch-review-ledger.md
• docs/outstanding-issues.md
• public/therapy-compass-data/therapies-home.f68f0bb9623bc42a.json
• public/therapy-compass-data/therapies-home.json
• public/therapy-compass-data/therapies-index.7cd59ff6765d15f8.json
• scripts/build-therapies-index.mjs
• scripts/check-bundle-budget.mjs
• src/components/clinical-dashboard/global-search-shell.tsx
• src/components/clinical-dashboard/use-hide-on-scroll.ts
• src/components/therapy-compass/bindings.tsx
• src/components/therapy-compass/data/generated-assets.ts
• src/components/therapy-compass/data/use-therapy-data.ts
• tests/bundle-budget.test.ts
• tests/therapy-compass-data-recovery.dom.test.tsx
• tests/therapy-compass-mode-wiring.test.ts
• tests/ui-phone-scroll-page-owned.spec.ts
• tests/use-hide-on-scroll.test.ts

🚧 Files skipped from review as they are similar to previous changes (7)

• src/components/therapy-compass/data/generated-assets.ts
• src/components/clinical-dashboard/global-search-shell.tsx
• tests/therapy-compass-mode-wiring.test.ts
• src/components/therapy-compass/bindings.tsx
• src/components/therapy-compass/data/use-therapy-data.ts
• scripts/build-therapies-index.mjs
• tests/therapy-compass-data-recovery.dom.test.tsx

[BigSimmo]

@cursoragent please thoroughly review these failing CI so they don't occur again and address all comments logically

[cursor]

Fixed the CI-blocking issue and cleared the open review threads on PR #1489 (tip ac2d0ec5; product fix 3e56dd91).

CI failure (won’t recur)

Static PR typecheck failed on tests/bundle-budget.test.ts: exitProcess defaults made TS infer exitImpl as (value) => never and stdout as WriteStream, so Vitest mocks failed.

Fix:ExitProcessOptions JSDoc + options = {} in scripts/check-bundle-budget.mjs.
Proof:npm run typecheck clean; vitest 34/34.

Comments addressed

Comment	Action
Critical: exitProcess mocks	Fixed (above)
Minor: \u006b in task-centred	Fixed — generator was rewriting every mid-word sk- (including task-); now only key-shaped \bsk-[A-Za-z0-9]{16,}; home/index regenerated
Major: modality from tags	No change — pre-existing on main; out of scope for this perf PR

All three threads resolved (inline replies 403; dispositions in the PR summary comment).

Left alone

Clinical catalogue modality/settings cleanup, auto-merge, merge to main. Hosted CI is re-running on the new tip.

[cursor]

CI + review-comment pass (3e56dd91)

Failing CI root cause (will not recur)

Static PR / typecheck was red on tests/bundle-budget.test.ts because exitProcess defaults inferred exitImpl as (value) => never and stdout as WriteStream, so Vitest mocks failed strict tsc.

Fix:ExitProcessOptions JSDoc + options = {} in scripts/check-bundle-budget.mjs. Local proof: npm run typecheck clean; vitest bundle-budget + escape + therapy wiring/pathways 34/34.

Open CodeRabbit threads

Thread	Disposition
exitProcess mocks (Critical)	Fixed in 3e56dd91
\u006b in task-centred	Fixed — generator mid-word sk- rewrite mangled task-centred; now only key-shaped \bsk-[A-Za-z0-9]{16,} is escaped; home/index regenerated (211dab55 / 4b4ee988)
modality derived from tags (Major)	No change — pre-existing on main catalogue source; out of scope for this perf PR

Inline replies are 403 for the agent token; threads were resolved via GraphQL. Dispositions recorded here.

Not changed

• Clinical modality/settings/tag cleanup (catalogue-data PR)
• Provider-backed gates / auto-merge / merge to main

Merge left to you once required CI on 3e56dd91 is green.

[BigSimmo]

@cursoragent this keeps failing... please do a thorough deep dive to ensure no more failures with CI

[cursor]

Taking a look!

[cursor]

CI deep-dive unblock (f5e57e64)

Why CI kept “failing”

GitHub PR mergeability reported a real conflict, which prevents refs/pull/1489/merge from building — so CI / Gitleaks / Semgrep look missing or red even when the branch tip itself is fine.

Local git merge-tree --write-tree origin/main <tip> was clean. The branch was only 1 commit behindmain (#1478 Sentry + source-governance). That is the repo’s behind-but-clean false-conflict case, not a content fight.

What I fixed this pass

1. Merged origin/main (ef0feef3) so the PR merge ref can build again.
2. docs:check-inventory — refreshed docs/scripts-index.md for the new escape helper (would have failed Static PR after the last push).
3. docs:check-links — #117 still pointed at deleted hashed assets (…7cd59ff… / …f68f0bb…); retargeted to durable/current paths.
4. Prior tip fixes already on the branch: exitProcess JSDoc typing (Static PR typecheck), task-centred sk-escape mangling, #146 hide-on-scroll, bundle-budget hang exit.

Local proof (decisive lines)

• verify:cheap: 448 files / 4683 passed
• verify:pr-local: Client bundle secret surface check passed + Offline RAG fixture validation passed (36 golden cases)
• check:bundle-budget: within tolerance + done (process exits; no hang)
• format:check: All matched files use Prettier code style!
• merge-tree origin/main: clean

Threads / scope

• No new product defects found in this pass.
• Clinical modality catalogue debt remains out of scope (pre-existing on main).
• Did not merge the PR, force-push, rebase, or arm auto-merge.

Hosted required CI should now be able to run on tip f5e57e64. Merge left to you once pr-required is green.

[cursor]

CI deep-dive — unblocked (67036ed0)

Root cause of the “keeps failing” loop

1. PR mergeability DIRTY blocked refs/pull/1489/merge, so required CI never ran (or looked missing).
2. First sync of main was clean; main then moved again (#1524) and created a real conflict in docs/scripts-index.md.
3. Earlier Static PR reds (already fixed on this branch): exitProcess mock typing; docs inventory / stale hashed #117 paths; task-centred sk-escape; bundle-budget hang; Services hide-on-scroll.

What I did

• Merged origin/main through #1478 and #1524
• Regenerated docs/scripts-index.md (198 scripts / 212 npm scripts) to resolve the content conflict
• Kept prior typecheck / asset / chrome / bundle-budget fixes

State now

• GitHub: MERGEABLE / BLOCKED only while checks run
• Local: merge-treeCLEAN, 0 behind
• Tip pushed for CI: 67036ed0
• Ledger append kept local-only for the moment so this push does not cancel the in-flight required run

Local proof

• format:check: All matched files use Prettier code style!
• typecheck: clean
• Prior full gates on the pre-feat(issues): give docs/outstanding-issues.md a writer, not just a gate #1524 tip: verify:cheap 4683 passed; verify:pr-local build + client-bundle + RAG fixtures; check:bundle-budget within tolerance + done

Merge left to you once pr-required is green on 67036ed0.