issues: archive validated #146 and capture duplicated-list guard - #1518
Merged
Conversation
…plicated-list rule as #159 Two gaps that existed only in a chat session after PR #1466 merged. #146 — the root cause is now in the row, read from the failure trace rather than inferred. anchorTop -138 -> -7 with documentScrollTop 504 on BOTH sides: the scroll never moved, the content shifted 131px, and 131 = collapseHeight 72 + the 59px --safe-area-top that gotoPhoneSurface injects. A fixed waitForTimeout(100) after setViewportSize measured mid-transient while the header briefly reclaimed both bands. The row stays OPEN on purpose, and says why: every CI run on a head carrying the fix was cancelled by a supersede at ~3m45, so shard 1 has never completed against it. The only proof is local, which does not exercise the CI-load condition that triggers the flake. Recording a fix as verified when no completed run has seen it is exactly the kind of claim this ledger exists to prevent. It closes when one finished Production UI shard 1 on main carries it. #159 — new. Four instances on one day of a list naming test files kept in two places, each failing by RUNNING NOTHING rather than going red: mockup component patterns, phone-chrome ownership journeys, tests/helpers/** absent from uiPatterns (pre-existing, and it had been silently skipping Production UI for six required specs), and the phone-scroll helper's consumer list. Each is guarded individually now; the class is enforced nowhere. Its stop rule is the one worth keeping: "CI would still have caught it" is not a defence. In the tests/helpers case CI did not catch it, and in two others the local gate the repo tells you to run before pushing reported green. Docs-only. Marker 159 -> 160, allocated from main at be8c9ff. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JHLPEV4o1rzipPDqshCSHY
Contributor
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes update review and issue ledgers. They record PR ChangesLedger maintenance
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
BigSimmo
commented
Jul 31, 2026
OwnerAuthor
Temporarily closing to preserve the serialized merge queue while #1485 exact-head CI runs. This PR will be reviewed in a later queue slot. |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
BigSimmo
marked this pull request as ready for review
July 31, 2026 02:02
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BigSimmo
enabled auto-merge (squash)
July 31, 2026 02:02
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The original PR wording said #146 was not CI-validated. That became stale after PR #1515 inherited #1466 and exact-head CI run
30597076992completedProduction UI (1)successfully. The issue ledger now records the completed evidence instead of keeping a resolved flake open.Verification
npm run check:installed-lock-parity— passednpm run check:outstanding-issues— passed: 157 rows, 44 open, 113 archived,next-id=160npm run check:branch-review-ledger— passedgit diff --check— passedRisk and rollback
Documentation-only. No product, clinical, retrieval, provider, or deployment behavior changes. Revert the squash commit if either disposition needs correction.
Summary by CodeRabbit