Privacy page: fix notched back control + three redesign directions - #1582
Privacy page: fix notched back control + three redesign directions#1582BigSimmo wants to merge 1 commit into
Conversation
Pad /privacy for notched-phone safe-area so the back control no longer sits under the status bar, and add a design-system study with Quiet ledger, Trust map, and Indexed brief comps (desktop + phone). Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #7808 (cancelled). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
BigSimmo
commented
Aug 5, 2026
Closing as part of an open-PR review sweep, with the production fix preserved. What was salvaged: the Why the rest is being closed rather than revived:
The three redesign directions themselves are not being judged here — if you want to take one forward, it is cleaner to open it fresh against current Related: #1580 is closed in the same sweep for the same staleness reason (its blocker was bundle budget, Generated by Claude Code |
* fix(privacy): keep the back control clear of the notch on phones /privacy sits outside the search shell, so it owns the OS top inset itself. searchPageShell's py-3 top pad is not enough under a status bar or Dynamic Island when apple-mobile-web-app-status-bar-style=black-translucent, leaving the back control partly behind the notch. Replaces the top pad with max(0.75rem, var(--safe-area-top)) (1.25rem at sm) and gives the back control a min-h-12 row, matching this repo's 48px production tap-target rule rather than the generic 44px guidance. Split out of the stale draft PR #1582, which mixed this production fix with three redesign mockups and 4.2 MB of PNG screenshots and has been red since 2026-08-02 on an unrelated type-scale violation (text-[10px]) in one of those mockup components. The fix is independent of that work and does not need to wait for it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T97Kqdj9Xh1Cubv5ms3KVy * fix(ui): share standalone shell with safe-area top pad Extract searchPageShellStandalone so /privacy and /reference/colour-coding own the OS top inset without py-/pt- override ordering, use min-h-tap for the back row, and pin the contract with a static render test. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record PR #1621 babysit closeout Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * chore(ledger): supersede unresolvable PR #1621 review HEAD Addresses Devin — the prior babysit closeout row pointed at a SHA that does not exist in the repo, so ledger lookup could never match it. * chore(ledger): point PR #1621 babysit supersede at pushed tip * chore(ledger): refresh PR #1621 Run PR sweep tip --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Summary
/privacyback-control safe-area bug: the page sits outside the search shell and was painting the back arrow under the status bar / Dynamic Island on notched phones. The page now ownsmax(safe-area-top)top padding with a 48px back row./mockups/privacy-page-directionspublic/mockups/privacy-page-redesign-2026-08/01 Quiet ledger
02 Trust map
03 Indexed brief
Verification
npx vitest run tests/privacy-ui.test.ts tests/navigation-back-button.dom.test.tsx— 7 passedverify:pr-local—Test Files 475 passed (475)/Tests 4971 passed | 4 skipped (4975)ALLOW_BUILD_WITH_DEV_SERVER=1 npm run build— passed (/privacyand/mockups/privacy-page-directionspresent; client bundle secret surface check passed)npm run ensure— Clinical KB at http://localhost:4461;/privacyand/mockups/privacy-page-directionsreturn 200/privacyheader safe-area rowRisk and rollout
/privacyonly; redesign directions are mockup/design-scratch until a direction is chosen. Governance wording is unchanged.Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
/privacy./mockups/privacy-page-directionsafternpm run ensure.To show artifacts inline, enable in settings.