fix(cloud): prove connected auth and runtime readiness - #1600
Conversation
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:17 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughCodex Cloud setup now restricts Supabase MCP access, defaults connected mode to offline RAG, validates browsers, Python dependencies, environment variables, and Git ancestry, and enforces operator-only PAT branch deletion. Documentation and tests reflect these changes. ChangesCodex Cloud hardening
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Setup as setup-codex-cloud.sh
participant Checker as check-codex-cloud-setup.mjs
participant Environment as check-codex-cloud-raw-env.sh
participant Runtime as Cloud runtime
Setup->>Runtime: Configure offline mode and MCP servers
Checker->>Environment: Scan inherited provider variables
Environment-->>Checker: Return names without values
Checker->>Runtime: Validate browsers, Python dependencies, and Git ancestry
Runtime-->>Checker: Return validation results
Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:473861f8d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #7908 (cancelled). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/check-codex-cloud-setup.mjs`:
- Line 288: Update sanitizedCloudCapabilityLines and its approvedModeValue
inputs so both Cloud profiles use RAG_PROVIDER_MODE=offline, matching the Cloud
profile contract. Remove the auto/openai values from this capability-reporting
path so invalid modes are not marked approved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5b57bdc6-49fd-4cb1-bec4-1113f3578d84
📒 Files selected for processing (9)
.codex/config.toml.mcp.jsondocs/codex-cloud.mddocs/scripts-index.mdscripts/check-codex-cloud-raw-env.shscripts/check-codex-cloud-setup.mjsscripts/delete-codex-cloud-branch-with-pat.shscripts/setup-codex-cloud.shtests/codex-cloud-setup.test.ts
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/check-codex-cloud-setup.mjs`:
- Line 440: Update the capability output construction around
checkout.expectedBase so CODEX_CLOUD_EXPECTED_BASE_SHA is validated and
normalized to a full commit ID before being assigned to git.expected_base. Emit
invalid for malformed or newline-containing values and unset when no value is
provided, and add coverage for arbitrary and newline-containing inputs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 40526c99-bc51-44db-a18d-9ae3773706b9
📒 Files selected for processing (6)
AGENTS.mddocs/codex-cloud.mdscripts/check-codex-cloud-setup.mjsscripts/maintain-codex-cloud.shscripts/setup-codex-cloud.shtests/codex-cloud-setup.test.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- scripts/setup-codex-cloud.sh
- docs/codex-cloud.md
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
CODEX_CLOUD_GITHUB_PATfrom every agent shellpip check, and report medspaCy/spaCy versions.codex/config.tomlas the disabled project template, activate audited Railway/Supabase entries in the connected host config, and keep.mcp.jsonas configuration-only evidenceSecurity boundary
No provider secret is added to the repository or agent environment. Hosted Railway/Supabase access still requires the corresponding OAuth plugin/connector to be installed in the host and proven in a fresh task with read-only identity calls.
Local validation
bash -nfor modified shell scriptsnode --check scripts/check-codex-cloud-setup.mjsOPENAI_API_KEYname with a synthetic valueFull repository tests are delegated to this PR's CI because the active workspace is connector-backed rather than a local checkout.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation