Skip to content

Privacy Live Signal: polish sticky obligation style - #1628

Merged
cursor[bot] merged 19 commits into
mainfrom
cursor/privacy-page-mockups-2ff6
Aug 5, 2026
Merged

Privacy Live Signal: polish sticky obligation style#1628
cursor[bot] merged 19 commits into
mainfrom
cursor/privacy-page-mockups-2ff6

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix /privacy back-control safe-area so the control sits below the notch
  • Elevate privacy redesign studies; selected direction is Live Signal
  • Style-polish Live Signal: full-bleed sticky Important, phone jump chips locked into sticky chrome, index gists, one-open desktop default, quieter processing map
  • Dedicated review route: /mockups/privacy-live-signal-perfected
  • Combined desktop+phone comps under public/mockups/privacy-page-redesign-2026-08/
  • Review follow-ups: unique per-frame accordion useId prefixes (fixes SR aria-controls collisions), Important notice panel stays mounted when collapsed, jump-scroll clears sticky chrome and waits for accordion layout commit, frame layouts key off the phone prop (not viewport sm:/lg:), named type-scale steps replace arbitrary font sizes that failed Static PR

Verification

  • Live route 200 at /mockups/privacy-live-signal-perfected
  • Browser proof of fused sticky Important + phone chips + index gists
  • npm run format before push
  • npm run check:type-scale -- --strict — clean (✓ type-scale: no arbitrary text-[<n>px|rem|em] font sizes in src.)
  • Focused mockup tests + tests/privacy-ui.test.ts — 2 passed
  • Provider gates not run: mockup/chrome only; governance wording unchanged

Risk and rollout

  • Risk: Low. Production /privacy change is safe-area padding; redesign is mockup-only until adopted.
  • Rollback: Revert the branch commits.
  • Provider or production effects: None
  • Note: fix(privacy): keep the back control clear of the notch on phones #1621 ships the same /privacy safe-area hunk in isolation. Once that lands, drop the duplicate padding change from this branch rather than content-merging it.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed — no CDS behaviour change; layout/chrome and design-scratch mockups only

Notes

  • Governance section headings and bodies remain production-identical.
  • Amber reserved for Important only.
Open in WebOpen in Cursor

Summary by CodeRabbit

  • New Features
    • Added privacy page mockups at two new routes.
    • Added three redesign directions: Statement Theatre, Data Passport, and Live Signal.
    • Added responsive desktop and mobile previews with expandable sections, navigation, processing-region indicators, and privacy notices.
    • Added a recommended perfected Live Signal preview with sticky privacy controls and interactive content.
  • Documentation
    • Documented available mockup routes, design directions, implementation guidance, and selected direction details.
    • Updated the site map with the new privacy mockup pages.

cursoragentand others added 2 commits August 2, 2026 12:09
Pad /privacy for notched-phone safe-area so the back control no longer
sits under the status bar, and add a design-system study with Quiet
ledger, Trust map, and Indexed brief comps (desktop + phone).
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Elevate direction 03: full-bleed sticky Important, phone jump chips
locked into the sticky stack, index gists, one-open desktop default,
and quieter processing map — plus dedicated perfected mockup comps.
@supabase

supabaseBot commented Aug 5, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:24 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 64d5527c-bf8b-4fac-91b6-85ad400bb234

📥 Commits

Reviewing files that changed from the base of the PR and between 7b244cb and 7a8ce79.

📒 Files selected for processing (2)
  • docs/branch-review-ledger.md
  • src/components/privacy-live-signal-perfected-mockups.tsx
📝 Walkthrough

Walkthrough

Added two privacy mockup routes. Added a three-direction redesign study and a perfected Live Signal mockup with responsive desktop and phone previews. Updated mockup navigation, shared chrome handling, sitemap entries, documentation, and the branch review ledger.

Changes

Privacy redesign study

Layer / File(s)Summary
Live Signal mockup implementation
src/components/privacy-live-signal-perfected-mockups.tsx
Added governance content, processing-region indicators, sticky privacy controls, responsive section navigation, accordions, device framing, and desktop and phone previews.
Three-direction redesign study
src/components/privacy-page-directions-mockups.tsx
Added Statement Theatre, Data Passport, and Live Signal layouts with responsive previews, comparisons, and a Live Signal recommendation.
Route integration and documentation
src/app/mockups/..., src/app/mockups/mockups-layout-client.tsx, docs/site-map.md, mockups/README.md, public/mockups/privacy-page-redesign-2026-08/README.md, docs/branch-review-ledger.md
Added route modules and metadata, hid shared search and chrome on both routes, registered the routes in documentation, and appended the review ledger record.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
participant Browser
participant PrivacyPageDirectionsMockups
participant PrivacyLiveSignalPerfectedMockups
participant LiveSignalPerfectedFrame
participant Accordion
Browser->>PrivacyPageDirectionsMockups: Open privacy-page directions route
PrivacyPageDirectionsMockups->>PrivacyLiveSignalPerfectedMockups: Render Live Signal previews
PrivacyLiveSignalPerfectedMockups->>LiveSignalPerfectedFrame: Create desktop and phone frames
LiveSignalPerfectedFrame->>Accordion: Render privacy sections
Accordion-->>LiveSignalPerfectedFrame: Update section expansion and navigation
Loading

Possibly related PRs

Suggested labels:skip-branch-sync

Suggested reviewers:cursoragent

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the Live Signal mockup and its sticky obligation styling polish, which are central changes in the pull request.
Description check✅ PassedThe description covers the summary, verification evidence, risks, rollback, production effects, governance preflight, and notes with relevant details.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Static PR checksneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #8193 (cancelled).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

@BigSimmo
BigSimmo marked this pull request as ready for review August 5, 2026 15:18
devin-ai-integration[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@BigSimmoClaude

Copy link
Copy Markdown
OwnerAuthor

Flagging a duplicate-content issue found during a cross-PR review sweep (not editing this branch directly, since it's not mine):

This branch's src/app/privacy/page.tsx change (the notch/safe-area padding + min-h-12 back-control row) is byte-for-byte identical to what #1621 already ships in isolation — confirmed by diffing both branches against current main after each one's latest push. #1621 is small (1 file, 19 lines), already has full CI evidence (Chromium: 0 failed of 17), and is queued to merge ahead of this PR specifically so this doesn't compound.

Once #1621 merges, this branch will hit a real conflict on that hunk. Recommend dropping the duplicate padding/back-control change from this branch (keep everything else — the Live Signal redesign mockups, the dedicated review route, the desktop+phone comps) and rebasing on top of what #1621 lands, rather than resolving it as a content merge.

No action needed until #1621 lands — just flagging so the conflict is expected rather than surprising.


Generated by Claude Code

Prefix accordion panel ids with per-frame useId so desktop/phone comps
do not collide; keep the Important notice panel mounted for aria-controls;
clear sticky chrome on jump-scroll; key frame layout off the phone prop
instead of viewport breakpoints; replace arbitrary font sizes with named
type-scale steps to unblock Static PR checks.
Defer jump-chip / index scrollIntoView until useLayoutEffect so the
previous panel collapse (and expand-all exit) has already updated
heights before measuring the sticky-cleared target.
When the selected section is already open, React bails on identical
state and the deferred layout effect never fires — scroll immediately
on that path so re-tapping a chip or index row still recenters it.
@cursor

cursorBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Acknowledged on the #1621 overlap: left the /privacy safe-area hunk in place while #1621 is still open. Once #1621 merges, we'll drop the duplicate padding/back-control change from this branch and keep the Live Signal mockup work.

Union the mockup registry conflicts so privacy Live Signal routes and the
newly landed phone/pin mockups both remain discoverable.
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

BigSimmoand others added 3 commits August 6, 2026 04:00
- Keep main's searchPageShellStandalone + min-h-tap on /privacy after #1621.
- Jump chips scroll only the device frame (not the review page) and use a
single scroll-mt clearance so targets land under sticky chrome, not mid-frame.
devin-ai-integration[bot]

This comment was marked as resolved.

When the Important notice is expanded, fixed scroll-mt clearance is too
short. Measure StickySignalChrome height at jump time instead.
@cursor
cursorBot enabled auto-merge (squash) August 5, 2026 20:42
coderabbitai[bot]

This comment was marked as resolved.

cursoragentand others added 3 commits August 5, 2026 20:49
CodeRabbit: fixed top-[13.5rem] lets expanded Important / text-zoom cover
the signal index. Measure StickySignalChrome via ResizeObserver and use
that height for the aside sticky offset.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…ecks
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor
cursorBot merged commit 909b34a into mainAug 5, 2026
26 checks passed
@cursor
cursorBot deleted the cursor/privacy-page-mockups-2ff6 branch August 5, 2026 21:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@cursoragent