fix(test): settle visible search-query-ribbon in ui-tools composer check

[BigSimmo]

Summary

• Follow-up from PR fix(privacy): keep the back control clear of the notch on phones #1621 Production UI (3): getByTestId("search-query-ribbon") can match two nodes when Next leaves a hidden streaming #S:1 clone beside the live favourites band (outstanding chore(deps): bump actions/checkout from 4 to 7 #93).
• Use visibleByTestId already imported in tests/ui-tools.spec.ts, matching the settlement helpers used elsewhere in that file.

Verification

• Verification not run: test locator settlement only; no product path change. CI Production UI / pr-required will prove the hotspot.
• UI verification not run locally: Playwright Chromium will run in CI for this path-scoped change.

Risk and rollout

• Risk: Low — test-only locator settlement for a known CI streaming clone.
• Rollback: Revert the squash commit.
• Provider or production effects: None

Notes

• fix(privacy): keep the back control clear of the notch on phones #1621 squash-merged while this tip was blocked by auto-merge; the flake did not reproduce on the final green run, but the hotspot remains unmigrated without this change.

Summary by CodeRabbit

• Tests
  • Improved search-route test reliability by selecting the visible status ribbon when multiple hidden or streaming versions are present.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 124205a7-9d5a-446e-b6c3-bb83781db1d7

📥 Commits

Reviewing files that changed from the base of the PR and between abf5858 and cd8c942.

📒 Files selected for processing (1)

• tests/ui-tools.spec.ts

---

📝 Walkthrough

Walkthrough

The search-route UI test now uses visibleByTestId to select the settled visible search-query-ribbon when hidden streaming clones exist.

Changes

Search-route ribbon selection

Layer / File(s)	Summary
Visible ribbon assertion tests/ui-tools.spec.ts	The test scopes the search-query-ribbon lookup to the visible element.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• BigSimmo/Database#421: Updates the same UI test file for mobile search-route element targeting.
• BigSimmo/Database#944: Addresses UI-test flakiness from multiple search and header instances.
• BigSimmo/Database#1184: Refines search-query-ribbon assertions in the same UI test file.

Suggested reviewers:cursoragent, claude, copilot

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the test fix for settling the visible search-query ribbon locator.
Description check	✅ Passed	The description explains the change, verification status, low risk, rollback, and lack of production effects; omitted governance sections are not applicable to this test-only change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.