Skip to content

docs: record PR #1649 ledger row and capture its cross-tool enforcement gap#1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 7 commits into from
Aug 7, 2026
Merged

docs: record PR #1649 ledger row and capture its cross-tool enforcement gap #1670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
015ffdc
docs: record PR #1649 ledger row and capture its cross-tool enforceme…
claude Aug 7, 2026
2fa5c66
merge origin/main into PR #1670 to clear behind-but-clean DIRTY state
cursoragent Aug 7, 2026
dfe2946
docs(ledger): name exact #1649 verification gates in late review row
cursoragent Aug 7, 2026
7115bc0
issues: capture the owed #1670 ledger row, the stranded Sentry commit…
claude Aug 7, 2026
f6f6f51
docs(ledger): record PR #1670 heavy review-and-fix
cursoragent Aug 7, 2026
0095e79
merge: reconcile issues capture with the PR #1670 review sweep
claude Aug 7, 2026
a43be6f
issues: close #259, its ledger row was appended by the PR #1670 revie…
claude Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions docs/branch-review-ledger.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -672,27 +672,29 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie
| 2026-08-06 | a24f74fdf0134487a03dce37dd9f1e9bd18502f5 | a24f74fdf0134487a03dce37dd9f1e9bd18502f5 | PR #1614 post-merge RAG index restoration audit | Pass - guard-only migration, no DDL, no ranking/RPC change; pr-policy ragRanking=false so no eval-canary required; 1 P3 doc nit (#248 renumber note says 237->246, row is #248) | check:migration-role; npx vitest run tests/supabase-schema.test.ts (74 passed); check:outstanding-issues |
| 2026-08-06 | PR #1614 / codex/restore-rag-indexes-20260804 | a24f74fdf0134487a03dce37dd9f1e9bd18502f5 | PR #1614 post-merge RAG index restoration audit | Pass - guard-only migration, no DDL, no ranking/RPC change; pr-policy ragRanking=false so no eval-canary required; 1 P3 doc nit (#248 renumber note says 237->246, row is #248); supersedes 2026-08-06 row (ref column mistakenly held commit SHA instead of PR ref, breaking ledger:lookup per Devin/Sentry review on PR #1636) | check:migration-role; npx vitest run tests/supabase-schema.test.ts (74 passed); check:outstanding-issues |
| 2026-08-06 | claude/implement-97vpz7 | 00ab7bfd34684bc854d15a3f28987674098a7130 | PR #1646 soft-tail answer-cache skip + soft-tail test hardening | fixed — answer-path soft-tail skip via rag-query-guard helpers; soft-tail fixture pins; duplicate memo test removed; in-corpus assert narrowed; budget 4362 | test:rag-query-guard+unsupported-cache+classifier-memo 22/22,check:maintainability-budgets 4362/4362 |
| 2026-08-06 | cursor/grok-quick-wins-a2c0 (PR #1651) | 49f82b831342e4666f76e307d5c61cba8db2a029 | Run PR sweep: CI fix + threads + drift | before: Sentry+Devin threads (double-zoom, issues:done, TOKENS px) + stale queue renumber after deletes; after: fixed+pushed; 5 threads resolved; CI queued awaiting runners; merge-tree clean; no provider-backed checks | vitest gestures+hide-on-scroll 35 passed; outstanding-issues gate+writer self-test (incl. multi-queue prune) passed; no provider-backed checks run |
| 2026-08-06 | cursor/grok-quick-wins-a2c0 (PR #1651) | 5d625d3e64752df0655c071b061642cfbbe4ea5f | Run PR sweep: CI fix + threads + drift | before: Sentry+Devin threads (double-zoom, issues:done, TOKENS px) + stale queue renumber; after: fixed in 38b7f8e4+5d625d3e; 5 threads resolved; CI queued on runners; merge-tree clean | vitest gestures+hide-on-scroll 35 passed; outstanding-issues gate+writer self-test passed; no provider-backed checks run |
| 2026-08-06 | temp-rebase | 868a8a2800351ce85a2ad13e14d80550cbc3e668 | Merge conflict resolution and CI fixes | Verified and ready for PR | verify:pr-local |
| 2026-08-06 | claude/pr-handoff-stop-hook (PR #1649) | fff524d73ebfafeef7bdc50752a6d14f253ebc2e | Run PR sweep: CI fix + threads + drift | before: 5 unresolved threads (Devin create-from-output + 4 CodeRabbit), mergeable/BLOCKED, Actions major outage leaving CI pending; after: hardened jq-less input/output separation + session fail-open + prefix unlock + tests (9 passed) in fff524d73ebfafeef7bdc50752a6d14f253ebc2e, threads replied+resolved, branch current with main, CI re-triggered (Actions outage — not babysat) | npx vitest run tests/pr-handoff-stop.test.ts (9 passed); bash -n hook OK; no provider-backed checks run |
| 2026-08-06 | claude/pr-handoff-stop-hook (PR #1649) | f67e5c9103c3e1483ad8e034fe7a6757c2362d74 | Run PR sweep: CI fix + threads + drift | before: 5 unresolved threads (Devin create-from-output + 4 CodeRabbit), mergeable/BLOCKED, Actions major outage leaving CI pending; after: hardened jq-less input/output separation + session fail-open + prefix unlock + tests (9 passed) in f67e5c9103c3e1483ad8e034fe7a6757c2362d74, threads replied+resolved, branch current with main, CI re-triggered (Actions outage — not babysat) | npx vitest run tests/pr-handoff-stop.test.ts (9 passed); bash -n hook OK; no provider-backed checks run |
| 2026-08-06 | claude/pr-handoff-stop-hook (PR #1649) | 36c1bccd89f976bcae3dabf8f5787198db5df078 | Run PR sweep: CI fix + threads + drift | before: 5 unresolved threads (Devin create-from-output + 4 CodeRabbit), mergeable/BLOCKED, Actions major outage leaving CI pending; after: hardened jq-less input/output separation + session fail-open + prefix unlock + tests (9 passed) in 36c1bccd89f976bcae3dabf8f5787198db5df078, threads replied+resolved, branch current with main, CI re-triggered (Actions outage — not babysat) | npx vitest run tests/pr-handoff-stop.test.ts (9 passed); bash -n hook OK; no provider-backed checks run |
| 2026-08-06 | claude/pr-handoff-stop-hook (PR #1649) | 3403126bc6cd86145d6921a3fe4d081181e8a113 | Run PR sweep: CI fix + threads + drift | before: 5 unresolved threads (Devin create-from-output + 4 CodeRabbit), mergeable/BLOCKED, Actions major outage leaving CI pending; after: hardened jq-less input/output separation + session fail-open + prefix unlock + tests (9 passed) in 3403126bc6cd86145d6921a3fe4d081181e8a113, threads replied+resolved, branch current with main, CI re-triggered (Actions outage — not babysat) | npx vitest run tests/pr-handoff-stop.test.ts (9 passed); bash -n hook OK; no provider-backed checks run |
| 2026-08-06 | claude/pr-handoff-stop-hook (PR #1649) | 057a5579e538fcacc15feb8a0ac7fa580b3decb4 | PR #1649 review-and-fix | fixed: Bugbot cross-session prune disarm + marker-write fail-open context + deny gh pr comment/review; superseded dead Run PR ledger HEADs; merge-tree clean vs main; threads cleared; CI re-trigger on push | vitest:pr-handoff-stop 11/11; verify:cheap 516 files/5457 tests; verify:pr-local pass (format+lint+typecheck+test+rag-fixtures); bash -n hook OK; security-review: no P0/P1; no provider gates |
| 2026-08-06 | claude/pr-handoff-stop-hook (PR #1649) | 057a5579e538fcacc15feb8a0ac7fa580b3decb4 | Run PR sweep: CI fix + threads + drift | supersede: prior stacked Run PR rows used unresolvable HEADs (fff524d7/f67e5c91/3403126b); reviewed product tip is this SHA (ledger bookkeeping may sit one commit above); Bugbot prune+context+comment/review fixes landed | vitest:pr-handoff-stop 11/11; verify:cheap pass; verify:pr-local pass |
| 2026-08-06 | temp-rebase | 868a8a2800351ce85a2ad13e14d80550cbc3e668 | Merge conflict resolution and CI fixes | Verified and ready for PR | verify:pr-local |
| 2026-08-07 | codex/docker-delivery-hardening (PR #1656) | fe339678ca23fc794238f458f0537a33f1b76c2c | prlanded | MERGED; tip tree empty vs squash fe339678; remote branch deleted | prlanded content verify; no provider-backed checks |
| 2026-08-06 | claude/settings-nav-freeze-desktop-tdzh7z (PR #1641) | d4ecd2b5fc48a8d8f37f081cac2d80beb749df01 | Run PR sweep: CI fix + threads + drift | before: mergeable/BLOCKED, 0 unresolved threads, 0 behind main; prior CI reds were infra (npm ECONNRESET on Unit coverage; e7f380f3 cancelled at Set up job). after: pushed d4ecd2b5 ResizeObserver pin-clamp distance reset; all review threads remain resolved; CI re-triggered but GitHub Actions major_outage — runs pending/queued, no product failure to fix; merge tree clean | local typecheck PASS; local lint (settings-dialog) PASS; format unchanged; no provider-backed checks run; hosted CI awaiting Actions recovery (run 31120931239) |
| 2026-08-06 | claude/settings-nav-freeze-desktop-tdzh7z (PR #1641) | c31827e63c20788c5dabb22b96ddbf239c65f893 | Run PR sweep: CI fix + threads + drift | before: mergeable/BLOCKED, 0 unresolved threads, 0 behind main; prior CI reds were infra (npm ECONNRESET; cancelled Set up job). after: product fix d4ecd2b5 (ResizeObserver pin-clamp distance reset) + ledger row; all review threads resolved; merge tree clean; hosted CI pending on GitHub Actions major_outage (no product failure) | local typecheck PASS; local lint (settings-dialog) PASS; no provider-backed checks run; hosted CI awaiting Actions recovery |
| 2026-08-06 | cursor/mode-nav-pr-1647-a5eb | 4c8d70612f3be4a1267ed16b81e926a9f2e1ef50 | PR #1647 mode-nav | no high-confidence defects; medium: record pages lose mode destinations after Subnav removal (section-nav early return); addon-slot guard still coincidence-tested not runtime; includes() activeId fragile for future slugs | read mode-nav/*, page-secondary-navigation, mode-secondary-navigation, specifier/formulation record anchors + tests; catalog slug collision scan (0 hits); test:focused blocked (test paths changed) |
| 2026-08-06 | claude/ds-truth-fixes | 7a9c41a971aa9111f050cd39d4429ada1b3f4409 | PR #1655 heavy review-and-fix | fixed DownloadLink tone DOM leak + stale ToggleSwitch/Links §9 docs; merge-tree clean; verify:cheap+verify:pr-local green; CI re-queued after push | bugbot+deep-review; vitest ui-primitives+ui-v2 60p; verify:cheap 5448p; verify:pr-local format+lint+typecheck+test+build+rag-fixtures; no provider gates |
| 2026-08-07 | claude/pr-handoff-stop-hook (PR #1649) | 76169ebcea48ca5efd9859b9a1f8c579dcc8b834 | PR #1649 pr-handoff-stop hook + AGENTS.md/handoff docs | shipped and squash-merged as 76169eb; hook denies post-handoff PR/CI polling (shell gh, GitHub MCP pull_request/workflow/check/job_log/update_branch, Monitor/ScheduleWakeup/CronCreate) while leaving commit, push, ledger:append and PR create/merge allowed; anchored exemption keeps create_pull_request_review denied; known limit: .claude/settings.json binds Claude Code only, Codex/Cursor get AGENTS.md prose with no enforcement (captured as an outstanding issue). Row recorded late and against the merged squash commit because the branch tip 2ad32de9b is unreachable after branch deletion | named #1649 gates: check-docs-links PASS (1629 refs); ci-change-scope --self-test PASS; check-gate-manifest PASS; check-codex-cloud-setup PASS (static); check-branch-review-ledger PASS; check-outstanding-issues PASS; Prettier clean on AGENTS.md/.claude/settings.json/handoff SKILL; bash -n hook clean; classifyPullRequestFiles all risk flags false; ~20 hook payloads exercised; incomplete vs full handoff: verify:pr-local NOT run (no node_modules); verify:ui NOT run (no UI delta); no provider-backed checks run |
| 2026-08-07 | codex/docker-delivery-hardening (PR #1656) | fe339678ca23fc794238f458f0537a33f1b76c2c | prlanded | MERGED; tip tree empty vs squash fe339678; remote branch deleted | prlanded content verify; no provider-backed checks |
| 2026-08-07 | claude/settings-nav-freeze-desktop-tdzh7z (PR #1641) | 7d3e62677ae178952aeca82048b492c4b84eaf05 | prlanded | MERGED; tip tree empty vs squash 7d3e6267; remote branch deleted | prlanded content verify; no provider-backed checks |
| 2026-08-07 | cursor/viewer-phase1-shell-extract-1db8 (PR #1665) | bd46a39ac02e604eb45178b5ed38d39f06cc6830 | prlanded | MERGED; remote branch deleted; squash tip on main | prlanded; no provider-backed checks |
| 2026-08-06 | cursor/mode-nav-pr-1647-a5eb | 4c8d70612f3be4a1267ed16b81e926a9f2e1ef50 | PR #1647 mode-nav | no high-confidence defects; medium: record pages lose mode destinations after Subnav removal (section-nav early return); addon-slot guard still coincidence-tested not runtime; includes() activeId fragile for future slugs | read mode-nav/*, page-secondary-navigation, mode-secondary-navigation, specifier/formulation record anchors + tests; catalog slug collision scan (0 hits); test:focused blocked (test paths changed) |
| 2026-08-07 | claude/new-session-6fz57i (PR #1647) | 47cffe5f65d9e1d74e4b97b8bb13fecd6b73aebc | prlanded | MERGED: mode-nav roll-out to DSM/Specifiers/Formulation/Differentials; tip 71edf468 empty vs squash 47cffe5f; remote branch deleted | content tree empty vs squash; no provider-backed checks run |
| 2026-08-07 | claude/ds-token-tracking-scale (PR #1663) | 82b6f5a4c02c163aba4391e7ca5a1ab77780e7ae | prlanded | MERGED: name letterspacing scale and ratio tokens; tip ec0b03c3 empty vs squash 82b6f5a4; remote branch deleted | content tree empty vs squash; no provider-backed checks run |
| 2026-08-07 | claude/sidebar-closed-default-i6n2fk (PR #1637) | 2f881abf8524742984ece90cb631f78658c87a19 | prlanded | MERGED: desktop sidebar defaults collapsed; tip empty vs squash; remote branch deleted | content tree empty vs squash; no provider-backed checks run |
| 2026-08-07 | claude/answer-shell-ds-adoption (PR #1658) | d9221389c5b11123e7d7bc882bda342a6fd9e11d | prlanded | MERGED: AnswerCard on live answer shell; tip empty vs squash; remote branch deleted | content tree empty vs squash; no provider-backed checks run |
| 2026-08-06 | claude/ds-truth-fixes | 7a9c41a971aa9111f050cd39d4429ada1b3f4409 | PR #1655 heavy review-and-fix | fixed DownloadLink tone DOM leak + stale ToggleSwitch/Links §9 docs; merge-tree clean; verify:cheap+verify:pr-local green; CI re-queued after push | bugbot+deep-review; vitest ui-primitives+ui-v2 60p; verify:cheap 5448p; verify:pr-local format+lint+typecheck+test+build+rag-fixtures; no provider gates |
| 2026-08-07 | claude/ds-truth-fixes (PR #1655) | cc349d1305df7cc0619d73a9487d8eb04d65acff | prlanded | MERGED; squash tip empty vs branch tip 1ffa4be19ea91e4da686082aec832cba5eddb47f; design-system truth fixes + retire left/right knob | content tree empty vs squash; no provider-backed checks run |
| 2026-08-07 | cursor/document-cover-thumbnails-b74c (PR #1661) | 096ba3138fe4dda182d98cc2f9c4e0fe9a09132b | prlanded | MERGED; squash tip empty vs branch tip 04934971711f2f7d346bbe6e0b9c0c8cd9776e43; first-page PDF cover thumbnails on document search cards | content tree empty vs squash; no provider-backed checks run |
| 2026-08-06 | cursor/grok-quick-wins-a2c0 (PR #1651) | 49f82b831342e4666f76e307d5c61cba8db2a029 | Run PR sweep: CI fix + threads + drift | before: Sentry+Devin threads (double-zoom, issues:done, TOKENS px) + stale queue renumber after deletes; after: fixed+pushed; 5 threads resolved; CI queued awaiting runners; merge-tree clean; no provider-backed checks | vitest gestures+hide-on-scroll 35 passed; outstanding-issues gate+writer self-test (incl. multi-queue prune) passed; no provider-backed checks run |
| 2026-08-06 | cursor/grok-quick-wins-a2c0 (PR #1651) | 5d625d3e64752df0655c071b061642cfbbe4ea5f | Run PR sweep: CI fix + threads + drift | before: Sentry+Devin threads (double-zoom, issues:done, TOKENS px) + stale queue renumber; after: fixed in 38b7f8e4+5d625d3e; 5 threads resolved; CI queued on runners; merge-tree clean | vitest gestures+hide-on-scroll 35 passed; outstanding-issues gate+writer self-test passed; no provider-backed checks run |
| 2026-08-07 | cursor/grok-quick-wins-a2c0 (PR #1651) | 2563b4adf4f0c0580ca371acfee94f9ae1ca3d0f | prlanded | MERGED; squash tip empty vs branch tip 4655643770dba7ca4078f1586c0461fd91657bf9; Grok-safe quick wins (tokens, a11y, perf, gates) | content tree empty vs squash; no provider-backed checks run |
| 2026-08-07 | cursor/viewer-phase0-gesture-a11y-1db8 (PR #1660) | 097dfd245f798f8105eeb6c1cf4fc077f969496f | prlanded | MERGED; squash tip empty vs branch tip 810cfc9b4a1c476a0dcc995bffb00d7329a85686; Phase 0 gesture INP, preview a11y, image decode | content tree empty vs squash; no provider-backed checks run |
| 2026-08-07 | claude/pr-handoff-loop-prevention-54y5zr (PR #1670) | dfe2946110e0ff93bd4acc571ae79c26b79a7a85 | PR #1670 heavy review-and-fix | synced origin/main (behind-but-clean DIRTY cleared); fixed CodeRabbit checks-cell to name exact #1649 gates + incomplete verify:pr-local/ui + no provider checks; Bugbot none; no P0/P1; #258/#ledger delta accurate; merge-tree clean; threads cleared | verify:cheap 519 files/5493 passed; verify:pr-local docs scope (format+docs+ledger+outstanding-issues); check:branch-review-ledger; check:outstanding-issues; no provider gates |

@coderabbitaicoderabbitaiBotAug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Record the skipped test and decisive verification output.

Line 700 reports 519 files/5493 passed, but the verification result also included one skipped test. Replace this shorthand with the exact captured gate output, or record 519 test files passed; 5,493 tests passed; 1 skipped. This prevents the ledger from appearing to record a complete pass.

As per coding guidelines, verification records must include the decisive gate output line. The PR verification summary records one skipped test.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/branch-review-ledger.md` at line 700, Update the verification summary in
the ledger entry for PR `#1670` to record the skipped test explicitly, replacing
the shorthand “519 files/5493 passed” with the exact captured gate output or
“519 test files passed; 5,493 tests passed; 1 skipped.”

Source: Coding guidelines

Loading
Loading