Skip to content

feat(mockups): Live Signal privacy variants without phone number chips - #1676

Closed
BigSimmo wants to merge 17 commits into
mainfrom
cursor/privacy-live-signal-variants-bc81
Closed

feat(mockups): Live Signal privacy variants without phone number chips#1676
BigSimmo wants to merge 17 commits into
mainfrom
cursor/privacy-live-signal-variants-bc81

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add /mockups/privacy-live-signal-variants with three perfected Live Signal forks for /privacy
  • A Quiet scroll — sticky chrome is header + Important only; accordion is the map
  • B Region-fused — compact Sydney / Singapore / External strip locks under Important (still no number chips)
  • C Contents card — in-flow “On this page” text labels only; no sticky chip rail
  • All three remove the phone top number navigation (01 Tool / 02 Collected chips)
  • Suppress shared mockup shell chrome for the new route; update mockups/README.md + site map

Verification

  • npm run ensurehttp://localhost:4461
  • Route 200 at /mockups/privacy-live-signal-variants
  • Browser screenshots of A / B / C (phone frames have no top number chips)
  • npm run format before push
  • npm run test:focused -- --files src/components/privacy-live-signal-variants-mockups.tsx,src/app/mockups/mockups-layout-client.tsx — no matching unit tests (exit 0)
  • UI verification not run: design-scratch mockup-only; no production /privacy adoption in this PR
  • Verification not run: verify:pr-local — design-scratch mockup-only; no production /privacy adoption in this PR

Risk and rollout

  • Risk: Low. Mockup-only route; production /privacy unchanged. Path names contain privacy, so the clinical-risk classifier fires; no privacy/auth/document-access behavior change.
  • Rollback: Revert the branch / close the PR.
  • Provider or production effects: None

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

  • Governance section headings and bodies match the existing Live Signal perfected copy.
  • Amber remains reserved for Important only.
  • Desktop signal index (with section numbers) is retained; only the phone top chip rail was removed per review feedback.
Open in WebOpen in Cursor

…hips
Keep the selected Live Signal craft (sticky Important, gists, processing map,
desktop signal index) and remove the phone top number chip row. Quiet scroll,
region-fused sticky strip, and in-flow contents card are three perfected forks
for review at /mockups/privacy-live-signal-variants.
@coderabbitai

coderabbitaiBot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:55 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: babced5f-f971-4d93-994c-a3e8d0f3c962

📥 Commits

Reviewing files that changed from the base of the PR and between 1797ba3 and f596f64.

📒 Files selected for processing (31)
  • docs/branch-review-ledger.md
  • docs/design-system/COMPONENTS.md
  • docs/design-system/adoption-manifest.json
  • docs/outstanding-issues.md
  • docs/search-chrome-behaviour.md
  • docs/search-results-bar-decisions.md
  • docs/site-map.md
  • mockups/README.md
  • src/app/mockups/mockups-layout-client.tsx
  • src/app/mockups/privacy-live-signal-variants/page.tsx
  • src/components/applications-launcher-page.tsx
  • src/components/clinical-dashboard/differentials-home.tsx
  • src/components/clinical-dashboard/image-lightbox.tsx
  • src/components/clinical-dashboard/medication-prescribing-workspace.tsx
  • src/components/clinical-dashboard/result-filter-control.tsx
  • src/components/clinical-dashboard/search-results-header-band.tsx
  • src/components/document-viewer/non-pdf-source-preview.tsx
  • src/components/factsheets/factsheets-search-page.tsx
  • src/components/formulation/formulation-home-page.tsx
  • src/components/privacy-live-signal-variants-mockups.tsx
  • src/components/services/services-navigator-page.tsx
  • src/components/specifiers/specifiers-home-page.tsx
  • tests/document-viewer-non-pdf-preview.dom.test.tsx
  • tests/image-lightbox-url-mode.dom.test.tsx
  • tests/search-results-header-band.dom.test.tsx
  • tests/ui-accessibility.spec.ts
  • tests/ui-formulation.spec.ts
  • tests/ui-smoke.spec.ts
  • tests/ui-specifiers.spec.ts
  • tests/ui-stress.spec.ts
  • tests/ui-tools.spec.ts

Comment @coderabbitai help to get the list of available commands.

@supabase

supabaseBot commented Aug 7, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo marked this pull request as ready for review August 7, 2026 10:57
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@cursor

cursorBot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Unblock summary — PR #1676

Tip:f63eba10f5e9b6db047302c34412ea5261cd410b on cursor/privacy-live-signal-variants-bc81
Sync / merge-tree:0 behind origin/main, merge-tree clean (behind-but-clean earlier; tip already includes merge from main). Auto-merge not armed.

What blocked

  1. PR policy (required)clinicalRisk: true because paths contain privacy (privacy-live-signal-variants*). Body lacked ## Clinical Governance Preflight.
  2. Stale/cancelled CI on prior tip after main moved — not a product failure.

What I fixed / dispositioned

  • Updated the PR body with a complete Clinical Governance Preflight (all 7 boxes checked) + explicit UI/verify:pr-local not-run reasons. Local evaluatePullRequestPolicyok: true.
  • PR policy re-ran green (31172327100 / prior 31172248093).
  • No code push from this session (remote already had the main sync at f63eba10). Discarded a duplicate local merge. No unresolved review threads.
  • No provider-backed gates run.

Required CI status (current tip)

  • PR policy: pass
  • PR mergeability: pass
  • Change scope: pass
  • Static PR / Build / Unit coverage / Safety / Production UI critical: in progress on run 31172328185

Residual risks

  • Mockup-only change; production /privacy untouched. Classifier still flags privacy* paths as clinical-risk (preflight required, not a behavior change).
  • Advisory jobs (if red) ignored unless they reveal a required failure.

Merge left to you once required checks settle green.

@BigSimmo
BigSimmo enabled auto-merge (squash) August 7, 2026 14:44
@BigSimmo
BigSimmo disabled auto-merge August 7, 2026 14:57
@BigSimmo
BigSimmo enabled auto-merge August 7, 2026 14:57
@BigSimmo
BigSimmo disabled auto-merge August 7, 2026 15:20
BigSimmo added a commit that referenced this pull request Aug 7, 2026
* docs(ledger): record PR #1676 unblock at f63eba1
Body-only Clinical Governance Preflight fix plus main sync; no product delta.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* docs(ledger): record PR #1677 review-and-fix after main sync
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* docs(ledger): supersede PR #1677 review-and-fix after late main sync
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
* docs(ledger): supersede PR #1677 review-and-fix after main sync
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

Autopilot + Bugbot summary — PR #1676

Final tip:4f02ca3983d50a7a7318ac981a3cbd3d9781c60f on cursor/privacy-live-signal-variants-bc81
Base:main · Mergeable: MERGEABLE · Merge-tree: clean · Behind: 0

Snapshot

ItemResult
ConflictsNone (behind-but-clean earlier; tip already includes origin/main sync)
Unresolved review threadsNone (including Bugbot/Codex inline)
Required CI at review timeBuild, Static PR checks, PR policy, Safety green; Unit coverage / Production UI / Lighthouse were still in flight on the synced tip
Product deltaMockup-only Live Signal privacy variants (no phone top number chips) under /mockups/privacy-live-signal-variants

Actions

  1. Confirmed GitHub head; isolated worktree Database-wt-pr-1676 (main-checkout WIP preserved).
  2. Behind-but-clean → merged origin/main once; tip advanced to 4f02ca3 (already on GitHub).
  3. High-confidence delta review: no P0/P1. Accordion 01/02 markers are section labels, not sticky phone chip nav. Layout suppresses shared chrome. Buttons wired (Back is intentional mockup noop).
  4. Bugbot subagent could not run (Cursor usage limit). Manual review substituted.
  5. Prettier on PR files: unchanged. No product fix commit.
  6. verify:cheap / local typecheckblocked by DATABASE_HEAVY_RUN_ADMISSION_BUSY (exclusive vitest lock held by pr-1662-autopilot). Not a product failure.
  7. Ledger: local-only no-change row at this HEAD (not pushed — avoids ledger-only tip churn).

Blockers

  • Local heavy verify admission lock (other worktree). Re-run npm run verify:cheap / npm run verify:pr-local when free if you want offline proof beyond CI.
  • Wait for remaining required CI (PR required) on 4f02ca3 before merge.
  • Never merged / no auto-merge.

Bugbot findings

Bugbot unavailable this pass — no automated findings table. Manual review: no high-confidence defects.

@BigSimmo

Copy link
Copy Markdown
OwnerAuthor

Autopilot + Bugbot — tip correction

Correct final tip:971eb9e28a2fe5b0d7f86fa912c4f6ac43a7b19b (prior summary cited 4f02ca3, which moved during the pass via another behind-but-clean main sync including #1702).

ItemResult
MergeableMERGEABLE
Merge-tree vs origin/mainclean
Behind / ahead0 / 16
Unresolved threadsnone
Product fixes this passnone (no P0/P1 on mockup delta)
Bugbotunavailable (usage limit); manual review only
Local verify:cheap / typecheckblocked by DATABASE_HEAVY_RUN_ADMISSION_BUSY (pr-1662-autopilot vitest)
Ledgerlocal-only no-change at 971eb9e (not pushed)

Blockers: wait for required CI on 971eb9e (merge state UNSTABLE while checks settle). Never merged.

@BigSimmo
BigSimmo marked this pull request as draft August 8, 2026 05:00
@cursor

cursorBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Closing as low-yield design-scratch: Live Signal privacy mockup variants only; production /privacy unchanged. Tip was CONFLICTING with heavy main-sync noise (31 files). Branch left in place for recovery — not deleted.

@BigSimmoBigSimmo closed this Aug 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@BigSimmo@cursoragent@claude