docs: default in-page navigation to DocumentViewer chrome - #1688
Conversation
Codify DocumentViewer header layout and PhoneHeaderCollapsePortal scroll attachment as the canonical template when adding or suggesting in-page navigation on any mode page.
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:22 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Record the docs-only in-page navigation default review at the pushed head after verify:pr-local.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR documents the DocumentViewer header as the canonical/default template for in-page navigation on mode pages, aligning future UI suggestions with the existing “one collapse owner” phone-header contract.
Changes:
- Adds a “Default in-page navigation template” section to
docs/search-chrome-behaviour.md, including required slots andPhoneHeaderCollapsePortalattachment guidance. - Adds an agent-facing reminder in
AGENTS.mdthat in-page nav should follow the DocumentViewer header pattern (and not introduce a second sticky/fixed phone header or separate scroll-hide owner). - Appends a review record row to
docs/branch-review-ledger.mdfor this branch head.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/search-chrome-behaviour.md | Documents the default in-page navigation template and required phone header attachment behavior. |
| AGENTS.md | Adds a concise agent rule pointing to the new contract section and reinforcing the “single collapse owner” pattern. |
| docs/branch-review-ledger.md | Adds a ledger row recording the docs-only review and the verification selector used. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
PhoneHeaderCollapsePortal(hides/reveals with the universal phone header).docs/search-chrome-behaviour.md.ModeNavor Differential headers, and does not extract a shared component.docs/branch-review-ledger.mdreview row for this branch head.Verification
npm run verify:pr-local(scoped toAGENTS.md,docs/search-chrome-behaviour.md— recognised low-risk docs scope; lint/typecheck/unit/build skipped by selector)Risk and rollout
Notes
DocumentViewer.tsx+document-viewer/section-nav.tsx(invariant 22 unchanged).