fix(ui): keep burger menu in universal phone header

[BigSimmo]

Summary

• Restore the usual burger menu (Open Clinical Guide menu) as the universal phone header’s top-left control on nested information pages and differentials submitted-search views.
• Remove the temporary back-arrow override (mobileLeadingAction="back") plus unused infoPageBackHref / mobileBackHref helpers.
• Leave page-owned back controls unchanged (differentials detail header, DocumentViewer, information-page breadcrumbs).
• Sync with origin/main so a fresh CI head replaces the stale cancelled PR required from the draft→ready retrigger.

Verification

• npm run verify:pr-local
• Hosted PR required green on head 6bff4b2f (run 31208494525)
• UI verification not run locally: leading-icon swap in existing chrome only; hosted Production UI (1)/(2)/(3) + critical passed on the synced head.
• npm run verify:release before release or handoff confidence claims

Risk and rollout

• Risk: Low. Universal leading control always opens the Clinical Guide menu; users still navigate up via page-owned back chrome.
• Rollback: Revert this commit.
• Provider or production effects: None

Notes

• Aligns with docs/search-chrome-behaviour.md: universal top bar is mode, new chat, menu; back belongs in page-owned chrome.
• Remaining red check is advisory only: Lighthouse budget (advisory) fails closed on Chrome 151 vs baseline Chrome 150 UA drift (evidence incomplete — refresh baselines with --update in a dedicated change). Not caused by this header icon swap.

Summary by CodeRabbit

• Changes
  • Simplified mobile navigation in the clinical dashboard.
  • Mobile headers now consistently display the sidebar menu button instead of a contextual back button.
  • Removed mobile back-navigation behavior for search and information pages.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change removes mobile back-navigation helpers and props from the clinical dashboard search components. The mobile header always opens the Clinical Guide menu. Related back-navigation tests are deleted.

Changes

Mobile search navigation removal

Layer / File(s)	Summary
Remove back-navigation contracts and wiring src/components/clinical-dashboard/global-search-shell.tsx, src/components/clinical-dashboard/master-search-header.tsx	The shell no longer exports mobile back-navigation helpers. MasterSearchHeader no longer accepts or derives mobile back-navigation props.
Use the menu as the mobile leading control src/components/clinical-dashboard/master-search-header.tsx	The mobile leading control always opens the Clinical Guide menu and renders the Menu icon.
Remove obsolete back-navigation tests tests/global-search-shell-back-href.test.ts	The back-navigation test file is deleted.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• BigSimmo/Database#473: Both changes simplify mobile search navigation in MasterSearchHeader.

Suggested reviewers:claude, cursoragent, copilot

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the UI change to keep the burger menu in the universal phone header.
Description check	✅ Passed	The description covers the change, verification, UI verification rationale, risk, rollback, effects, and notes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/universal-header-burger-menu-545b

---

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/components/clinical-dashboard/master-search-header.tsx (1)

199-199: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Gate the mobile menu trigger when no handler exists. Both production callers pass onOpenMobileSidebar, and no removed props remain. Test callers omit the callback, so the button renders with onClick={undefined}. Make the callback required or render the button only when it exists.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/clinical-dashboard/master-search-header.tsx` at line 199,
Update the master search header component’s mobile menu trigger to require and
validate onOpenMobileSidebar before rendering or wiring the button; preserve the
existing behavior for production callers while preventing a trigger with an
undefined onClick in test callers.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/components/clinical-dashboard/master-search-header.tsx`:
- Line 199: Update the master search header component’s mobile menu trigger to
require and validate onOpenMobileSidebar before rendering or wiring the button;
preserve the existing behavior for production callers while preventing a trigger
with an undefined onClick in test callers.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ac5f047b-8d54-4589-8ca1-6ae444ee68ac

📥 Commits

Reviewing files that changed from the base of the PR and between 0847adc and 6bff4b2.

📒 Files selected for processing (3)

• src/components/clinical-dashboard/global-search-shell.tsx
• src/components/clinical-dashboard/master-search-header.tsx
• tests/global-search-shell-back-href.test.ts

💤 Files with no reviewable changes (2)

• tests/global-search-shell-back-href.test.ts
• src/components/clinical-dashboard/global-search-shell.tsx