Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/branch-review-ledger.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -712,3 +712,17 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie
| 2026-08-07 | claude/handover-review-nlhuln | de8b74e2fb94d1ec9b1982c15a2dea43421c3eee | outstanding-issues ledger capture after the mode-nav rollout (PR #1685) | Confirmed #256's two remaining suspected section sets are dead (/forms/<slug> and /differentials/presentations/<slug> draw no section nav; form-decision-context-mobile is a testId not an id; ruled out sectionId indirection in both files). Added #261 (delete-or-keep the consumer-less action kind) and #262 (addon-slot single-owner rule held by two lists agreeing by coincidence). #207/#226/#231 reviewed and deliberately left untouched as existing P1 rows. | check:outstanding-issues passed (260 rows, 119 open, unique ids, no ids deleted from base 1ff9ed206456); prettier --check clean on the changed file; rows written via scripts/outstanding-issues.mjs, never hand-edited; no code gates run - docs-only diff |
| 2026-08-07 | claude/handover-review-nlhuln | de8b74e2fb94d1ec9b1982c15a2dea43421c3eee | outstanding-issues ledger capture after the mode-nav rollout (PR #1685) (supersedes 2026-08-07) | Confirmed #256's two remaining suspected section sets are dead (/forms/<slug> and /differentials/presentations/<slug> draw no section nav; form-decision-context-mobile is a testId not an id; ruled out sectionId indirection in both files). Added #271 (delete-or-keep the consumer-less action kind) and #272 (addon-slot single-owner rule held by two lists agreeing by coincidence) — renumbered from this PR's original #261/#262 because main claimed #261-#270 via PR #1678 design-system tracks in the interim. #207/#226/#231 reviewed and deliberately left untouched as existing P1 rows. | check:outstanding-issues passed (270 rows, 129 open, 141 archived, unique ids, next-id=273 above the highest, no ids deleted from base d32dd549a3dd); prettier --check clean on the changed file; rows written via scripts/outstanding-issues.mjs, never hand-edited; no code gates run - docs-only diff |
| 2026-08-07 | claude/search-bar-mobile-layout-buu0io | 9d64388c0ce530d0c20bb7efe8ffb32cd928319c | phone results-filter idiom: 7 modes off MobileResultFilterControl onto ResultFilterTrigger + ResultFilterSheet; band, docs, tests | changes-shipped | typecheck; lint; test 5538 passed (1 pre-existing pr-handoff-stop failure, baselined on unmodified tree); build; check:rag:fixtures; check:bundle-budget +6.3% within tolerance; targeted Playwright: ui-accessibility 16, ui-specifiers+ui-formulation 12, ui-tools 5, ui-smoke 2, ui-stress 3 |
| 2026-08-07 | cursor/phone-mode-dense-production-05c0 (PR #1648) | 1091b17933beba655dac3e37f0e5c1bc4cdfb679 | Run PR sweep: CI fix + threads + drift | No action needed: PR required green, no unresolved review threads, not behind main. Only advisory Lighthouse job failing (never chased). | get_check_runs (PR required: success), get_review_comments (0 unresolved threads) |
| 2026-08-07 | cursor/tools-search-mockups-72e1 (PR #1653) | 1df72ba6119226aee92b203db8188f58851a6d3c | Run PR sweep: CI fix + threads + drift | No action needed: PR required green, no unresolved review threads, not behind main. Only advisory Lighthouse job failing (never chased). | get_check_runs (PR required: success), get_review_comments (0 unresolved threads) |
| 2026-08-07 | cursor/ship-first-redesign-mockups-2398 (PR #1654) | d6610b20a6b51bcfda266e1645fe695014c4b627 | Run PR sweep: CI fix + threads + drift | No action needed: PR required green, no unresolved review threads, not behind main. Only advisory Lighthouse job failing (never chased). | get_check_runs (PR required: success), get_review_comments (0 unresolved threads) |
| 2026-08-07 | cursor/settings-features-mockups-97ac (PR #1657) | 4670a6b7bf50bbfda2c601c05364ee5fb267a6c0 | Run PR sweep: CI fix + threads + drift | No action needed: PR required green, no unresolved review threads, not behind main. Only advisory Lighthouse job failing (never chased). | get_check_runs (PR required: success), get_review_comments (0 unresolved threads) |
| 2026-08-07 | cursor/clinician-workflow-mockups-2b63 (PR #1662) | ac5c91c7f8cf4c47f87bb85a4d107b018c8c1d73 | Run PR sweep: CI fix + threads + drift | No action needed: PR required green, no unresolved review threads, not behind main. Only advisory Lighthouse job failing (never chased). | get_check_runs (PR required: success), get_review_comments (0 unresolved threads) |
| 2026-08-07 | dependabot/npm_and_yarn/js-yaml-4.3.1 (PR #1668) | 7f69fb05fb569f2da34d916db7b4f4153dc676c3 | Run PR sweep: CI fix + threads + drift | Synced behind-but-clean branch via update_pull_request_branch (dependabot bot branch, no drift issues); no unresolved review threads. | git merge-tree (clean), update_pull_request_branch (success) |
| 2026-08-07 | cursor/privacy-live-signal-variants-bc81 (PR #1676) | f596f641867b4f16f5d512c792a43833ebad0f25 | Run PR sweep: CI fix + threads + drift | GitHub reported dirty/conflicting mergeable_state but git merge-tree and a real test merge in a worktree were clean (stale mergeability, main had advanced past a prior bot pass). Merged origin/main directly and pushed. No unresolved review threads (all PR comments were bot status noise). | git merge-tree (clean), real worktree merge (clean, no conflicts), npm run ledger:dedupe (no duplicates) |
| 2026-08-07 | cursor/site-testing-speed-08c1 (PR #1686) | ee58563208055cc5a610852b0f65e42ab5cb8118 | Run PR sweep: CI fix + threads + drift | Real merge conflict in docs/outstanding-issues.md resolved content-aware (kept both sides' entries, took main's newer text for one row that referenced a since-resolved issue); lighthouse-budget.json conflict resolved by taking main's regenerated baseline. Merge surfaced 2 real TS typecheck errors from main's stricter tsconfig (NODE_ENV missing in partial env objects; non-const array losing literal type for object indexing) in this PR's own new test files -- fixed both, verified via eslint clean + targeted vitest (25/25 passed). No unresolved review threads. | npm run check:outstanding-issues (passed), eslint on 3 fixed files (clean), vitest on 3 fixed files (25 passed), npm run ledger:dedupe (no duplicates) |
| 2026-08-07 | cursor/site-testing-speed-08c1 (PR #1686) | ee58563208055cc5a610852b0f65e42ab5cb8118 | Run PR sweep: CI fix + threads + drift (supersedes 2026-08-07) | Correction: prior row wrongly mentioned lighthouse-budget.json, which was not part of this PR's conflict. Real merge conflict in docs/outstanding-issues.md only, resolved content-aware (kept both sides' entries, took main's newer text for one row that referenced a since-resolved issue). Merge surfaced 2 real TS typecheck errors from main's stricter tsconfig (NODE_ENV missing in partial env objects; non-const array losing literal type for object indexing) in this PR's own new test files -- fixed both, verified via eslint clean + targeted vitest (25/25 passed). No unresolved review threads. | npm run check:outstanding-issues (passed), eslint on 3 fixed files (clean), vitest on 3 fixed files (25 passed), npm run ledger:dedupe (no duplicates) |
| 2026-08-07 | cursor/run-pr-sweep-ledger-d56c (PR #1698) | 45b2975ca1c99d4f8784e834caa0b37eb859c9ce | Run PR sweep: CI fix + threads + drift | GitHub reported dirty/conflicting mergeable_state but git merge-tree and a real test merge in a worktree were clean (stale mergeability). Merged origin/main directly and pushed. No unresolved review threads. Docs-only ledger-append PR. | git merge-tree (clean), real worktree merge (clean, no conflicts), npm run ledger:dedupe (no duplicates) |
| 2026-08-07 | codex/combined-wip-backups-20260807 (PR #1701) | d110f99e8eee87bf279c0eddd6a57837a8c64f5e | Run PR sweep: CI fix + threads + drift | NOT merged/synced -- aborted intentionally. Confirmed the CRITICAL Sentry privacy-leak finding (raw relatedDocuments, including unredacted labels/owner_id, sent to client via /api/search route's top-level relatedDocuments field and smartPanel.relatedDocuments instead of the already-computed clientRelatedDocuments projection) and replied with root-cause + fix location, but did not push a fix. While resolving this PR's docs/outstanding-issues.md conflict against main, found a second silent regression baked into the PR branch itself: scripts/outstanding-issues.mjs reverted to an old 10-cell row schema (vs current main's 7-cell schema), which produces NO merge conflict against main and would land invisibly. Given a 177-file diff (+3716/-14512) with two independent silent regressions already found, declined to push a partial fix and instead recommended the branch be rebuilt from current main per-commit rather than bulk-merged. Thread left open (blocker requires human decision on the branch). | raw branch-tip diff of scripts/outstanding-issues.mjs vs main (confirms schema revert, not merge-induced), git merge-tree (clean for the two files inspected, not exhaustively audited) |
| 2026-08-07 | cursor/fix-lighthouse-chrome-pin (PR #1703) | 621180854248fcc10982f3fd58762229fee999d0 | Run PR sweep: CI fix + threads + drift | GitHub reported dirty/conflicting mergeable_state but git merge-tree and a real test merge in a worktree were clean (stale mergeability). Merged origin/main directly and pushed. No unresolved review threads. | git merge-tree (clean), real worktree merge (clean, no conflicts) |
| 2026-08-07 | cursor/document-citation-landing-7bc3 (PR #1705) | 8e62183dea5e07ac5ee4671d8d358937263c5de4 | Run PR sweep: CI fix + threads + drift | Merged origin/main (clean, just behind). Fixed the real CI failure (ui-smoke 'document viewer content disclosures...'): jumpToSection set inspectRevealKey when navigating to source-text but never cleared it navigating away, so IndexedTextPanel's React-controlled open prop stayed true and, sharing the native exclusive accordion group, silently closed whatever section was just navigated to. Same root cause independently flagged by Sentry and CodeRabbit review threads on this PR -- fixed once, replied to both, resolved both plus a 3rd (already-fixed) copilot thread. Declined to fix a 4th P3 CodeRabbit nitpick (edit an existing ledger row) since the ledger is append-only; replied with reasoning and resolved. | eslint on DocumentViewer.tsx (clean); local Playwright build blocked by environment-wide missing tailwind-merge dependency (Node 24.13.0 vs jsdom's required >=24.15.0, npm ci blocked by engine-strict) -- relying on CI |
| 2026-08-07 | cursor/viewer-phase2c-rail-filmstrip-1db8 (PR #1707) | af52b592bd22794f5cf96cbca0fb27f2d6bbb3e3 | Run PR sweep: CI fix + threads + drift | Not behind main, no merge needed (mergeable_state 'blocked' was just the failing required check). Fixed the real Unit coverage CI failure: tests/document-image-filmstrip.dom.test.tsx still asserted the stale aria-current='true' after the component was already fixed to emit 'page' for an earlier a11y review finding -- exactly matched an unresolved CodeRabbit finding, applied its suggested fix. Also fixed an unresolved LOW-severity Sentry finding (image metadata line could start with a leading ' · ' separator when image_type is falsy) by collecting parts into an array and filter+join instead of individually prefixing. All 4 review threads now resolved (2 new fixes + 2 already-fixed-on-branch copilot threads). | eslint on both fixed files (clean); local vitest blocked by environment-wide missing tailwind-merge dependency -- relying on CI |
Loading