docs(issues): close #276, and record why the Lighthouse advisory is red repo-wide

[BigSimmo]

Summary

Docs-only, one file, two independent ledger edits.

• Closes #276. The fix shipped in PR fix(design-system): LinkAction refuses tone; correct #270, #118 and #269 by measurement #1720 (5c0504a40) but the row was still open — and still sitting at position 113 of the recommended execution queue, which is exactly how finished work gets picked up and done a second time. Archived with the outcome: LinkActionProps carries tone?: never, because Omit<BaseProps, "tone"> alone only closed the object-literal path — a spread still type-checked clean and rendered the accent. Verified with a focused tsc probe before the change (Omit accepted the spread with no diagnostic; tone?: never rejected it with TS2345), and pinned by a type-level contract test that stops compiling if the prop ever widens back.

• Records the measured cause of the red Lighthouse budget (advisory) job on #118. It is not a budget breach and not attributable to any one PR. The CI runner's Chromium moved 150 → 151 while lighthouse-budget.json's baselines were captured on 150, so run-lighthouse-budget.mjs refuses to grade across browser versions. All ten route/strategy pairs report baseline measured by a different browser … refresh with --update, and the job ends with Evidence incomplete. Nothing is graded from this run. The measurements themselves were at or better than baseline — mobile-root improved from LCP 3930 ms to 2304 ms.

  Worth writing down rather than re-diagnosing: it is repo-wide (every PR tripping ui_changed or build_changed shows this job red until baselines are refreshed), it recurs on every Chromium bump, and the refresh must come from CI artifact provenance because the script keys on the browser UA — a developer machine is rejected the same way. Refreshing also silently re-accepts whatever the current numbers are, which is why it stays a decision on #118 rather than a chore.

Verification

• npm run check:outstanding-issues — passed: 274 rows (130 open, 144 archived), unique ids, next-id=277 above the highest, no merge driver, no ids deleted from base 5c0504a40615. The open/archived split moves 131/143 → 130/144, which is the #276 closure and nothing else.
• npx prettier --check . — passed whole-tree: All matched files use Prettier code style!
• Both edits were made with npm run issues:done / issues:update, never by hand.
• No source, config or test file is touched, so no unit, lint, typecheck or browser gate applies to this diff.

Evidence for the Lighthouse claim is CI run 31248683948, job 93081470146, artifact lighthouse-budget-31248683948 (id 9019375154) — read from the job log, not inferred.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation
  • Updated the outstanding issues list to mark one issue as resolved.
  • Added details about a Chromium version mismatch and CI baseline refresh requirements.

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:30 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0fba9053-9f2f-4478-bd8f-2ef2cb1fcd4d

📥 Commits

Reviewing files that changed from the base of the PR and between 8ae8c48 and ecf293b.

📒 Files selected for processing (2)

• docs/branch-review-ledger.md
• docs/outstanding-issues.md

📝 Walkthrough

Walkthrough

The issue ledger updates #276 as resolved after documenting the LinkActionProps contract and moves it out of the execution queue. It also expands #118 with Chromium-version mismatch evidence and CI-only Lighthouse baseline refresh requirements.

Changes

Issue ledger maintenance

Layer / File(s)	Summary
Record LinkAction resolution docs/outstanding-issues.md	The ledger removes #276 from the recommended queue and unresolved archive. It records the tone?: never contract and associated type-level and render tests.
Document Lighthouse baseline constraints docs/outstanding-issues.md	The #118 entry documents Chromium-version mismatch evidence and CI-provenance refresh requirements.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• BigSimmo/Database#1720: Implements the related LinkAction unsupported-tone resolution documented here.

Suggested reviewers:claude, cursoragent

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The linked #276 issue concerns Supabase Cursor tooling, but this PR documents a LinkActionProps fix and a Lighthouse advisory instead.	Verify the issue number and link the correct issue, or update this PR to address the Supabase Cursor workspace configuration requirements.
Out of Scope Changes check	⚠️ Warning	The ledger edits about LinkActionProps and Lighthouse baselines are unrelated to the linked issue's Supabase Cursor tooling objectives.	Remove the unrelated ledger edits or link the issues that define the LinkActionProps and Lighthouse advisory work.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the two documentation changes: closing #276 and recording the repo-wide Lighthouse advisory cause.
Description check	✅ Passed	The description provides a detailed summary and verification evidence; omitted risk and governance sections are not applicable to this docs-only change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/ds-close-276

---

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:48f4ecfe6d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

docs/outstanding-issues.md (1)

315-316: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Preserve the existing #276 archive record.

This change deletes the prior archive entry and adds a replacement at Line 473. The archive contract at Line 319 says to keep records and not delete them. Use the /issues workflow to update or supersede the existing record without losing its prior unresolved history.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/outstanding-issues.md` around lines 315 - 316, Preserve the existing
`#276` archive record in the outstanding-issues archive instead of deleting it.
Use the repository’s /issues workflow to update or supersede that record while
retaining its prior unresolved history, and add the replacement only in the
established archive format.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/outstanding-issues.md`:
- Around line 315-316: Preserve the existing `#276` archive record in the
outstanding-issues archive instead of deleting it. Use the repository’s /issues
workflow to update or supersede that record while retaining its prior unresolved
history, and add the replacement only in the established archive format.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8dbcc71f-b4ff-4b33-9db0-0455bce48c8f

📥 Commits

Reviewing files that changed from the base of the PR and between 2069b1f and 8ae8c48.

📒 Files selected for processing (1)

• docs/outstanding-issues.md

[cursor]

PR #1724 review-and-fix summary

Tip:ecf293b73a180f5743f7a01ab90daf510bf5fa71 on claude/ds-close-276
Sync / merge-tree: behind 0 / ahead 4 of origin/main; git merge-tree --write-treeCLEAN. Merged origin/main once after #1725 conflicted on docs/outstanding-issues.md (preferred main’s shared queue + #277 / next-id=278, then re-applied this PR’s #276 archive and corrected #118 note).
Auto-merge: already armed (squash) by BigSimmo — no further pushes; merge left to you.

Fixed

• Codex P2 (#118 Lighthouse diagnosis): verified 4f1bbbb^ baselines are HeadlessChrome/151 and #1710 (4f1bbbb) overwrote them to 150 while #1716 (4a9d81d) already pinned the job to Playwright Chromium 151. Updated #118 via issues:update to record a stale 150 overwrite (prefer restore/compare the known 151 baseline) rather than a fresh CI-runner 150→151 bump. Thread resolved.
• Main sync conflict: resolved as above; #277 retained.

Dispositioned (no code change)

• CodeRabbit “preserve existing #276 archive”: false positive — #276 was never in the archive; issues:done correctly moved it from Open → Resolved/archive. No prior archive history to preserve.
• Bugbot: no Bugbot findings on this tip.

Required CI (this tip)

• PR requiredpass
• Static PR checkspass
• PR mergeabilitypass
• PR policypass
• Change scopepass
• Production UI not selected (docs-only / skipped) — expected

Earlier transient PR mergeability red on 7f1d46a0 was a GitHub 504 on metadata fetch, not a content conflict (gh rerun denied for this token).

Local proof

• npm run check:outstanding-issues — 275 rows (131 open, 144 archived), next-id=278 … no ids deleted from base d9b55d477062
• npx prettier --check docs/outstanding-issues.md docs/branch-review-ledger.md — pass
• npm run check:branch-review-ledger — pass
• No provider-backed gates

Residual

• PR body still carries the pre-correction Chromium narrative in places (body update blocked: not agent-managed); the ledger row #118 text is the source of truth.
• #118 Lighthouse half still needs an owner decision to restore/compare the known 151 baseline or refresh via the #1722 dispatch path — not done in this PR.
• Ledger row records merge parent 4baa9a1b inside tip ecf293b7 (folded; no ledger-only tip pushed).

Merge left to you.