Skip to content

Align prescribing smoke test with back-link accessible name - #1787

Merged
BigSimmo merged 2 commits into
claude/in-page-nav-pr-3-i6gi8nfrom
copilot/fix-copilot-issue
Aug 9, 2026
Merged

Align prescribing smoke test with back-link accessible name#1787
BigSimmo merged 2 commits into
claude/in-page-nav-pr-3-i6gi8nfrom
copilot/fix-copilot-issue

Conversation

CopilotAI commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • CI failed on tests/ui-smoke.spec.ts in the prescribing critical flow because the locator expected the visible label ("Medications") instead of the link’s accessible name ("Back to medications").
  • Change scope
    • Test-only fix: updated one failing locator assertion in the prescribing smoke test to match the in-page nav back-link accessibility contract.
    • No product/runtime behavior change: assertion alignment only.
// beforeawaitexpect(page.getByRole("link",{name: "Medications",exact: true}).first()).toBeVisible();// afterawaitexpect(page.getByRole("link",{name: "Back to medications"}).first()).toBeVisible();

Verification

  • npm run verify:pr-local

During development, use npm run verify:cheap as the faster iteration gate before the final PR-local preflight.

  • npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
  • npm run verify:release before release or handoff confidence claims

For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, verify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.

  • npm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.
  • npm run eval:rag -- --limit 15 + npm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)
  • npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
  • npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed

Verification not run: full PR template gates were not executed for this scoped test-assertion correction.

Risk and rollout

Complete this section for clinical, data, API, auth/privacy, workflow, dependency, build, or deployment changes.

  • Risk: Low; single test locator assertion update.
  • Rollback: Revert the single test-line change in tests/ui-smoke.spec.ts.
  • Provider or production effects: None

Clinical Governance Preflight

Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.

Not applicable: test-only change; no clinical or production data-path changes.

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

  • This unblocks the failing CI job by aligning the assertion with existing accessibility semantics rather than changing UI behavior.

@supabase

supabaseBot commented Aug 9, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

CopilotAI changed the title [WIP] Fix issue with Copilot in database actionsAlign prescribing smoke test with back-link accessible nameAug 9, 2026
CopilotAI requested a review from BigSimmoAugust 9, 2026 13:00
@BigSimmo
BigSimmo marked this pull request as ready for review August 9, 2026 13:07
@BigSimmo
BigSimmo merged commit 2a28b57 into claude/in-page-nav-pr-3-i6gi8nAug 9, 2026
2 of 3 checks passed
@BigSimmo
BigSimmo deleted the copilot/fix-copilot-issue branch August 9, 2026 13:07

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:dec736ecf1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

await expect(page).toHaveURL(/\/medications\/acamprosate$/, { timeout: 30_000 });
await expectSingleMedicationPage(page);
await expect(page.getByRole("link", { name: "Medications", exact: true }).first()).toBeVisible();
await expect(page.getByRole("link", { name: "Back to medications" }).first()).toBeVisible();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the mobile back-link locator as well

When verify:ui reaches the adjacent mobile prescribing case, it still queries the link as name: "Medications", exact: true at line 3441, while InPageNavHeader assigns aria-label="Back to medications" at every breakpoint. The critical desktop case will now pass, but the PR UI suite will fail in the mobile case before its touch-target and navigation assertions; update both locators and run the named mobile test as the smallest proof.

Useful? React with 👍 / 👎.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo