Add tappable iPhone suggestion ticker optimized for phone home composer - #1805
Conversation
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:43 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe search surface adds a tappable mobile suggestion ticker for home routes. The ticker pauses rotating examples during interaction, populates and focuses the search input, uses responsive styling, and has UI coverage for visibility and selection. ChangesPhone search suggestion ticker
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant SmartRotatingHint
participant UniversalSearchCommandSurface
participant SearchInput
User->>SmartRotatingHint: Tap suggestion ticker
SmartRotatingHint->>UniversalSearchCommandSurface: Select displayed example
UniversalSearchCommandSurface->>SearchInput: Set query and focus input
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:15c36ae932
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
BigSimmo
commented
Aug 10, 2026
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. The only repository destination is BigSimmo/Database, and the only branch destination is the pull request head branch codex/design-suggestion-ticker-for-iphone at starting commit 15c36ae; never publish fixes to a detached or synthetic work branch and never create a stacked pull request. Use the authenticated GitHub connector to commit each approved fix to BigSimmo/Database:codex/design-suggestion-ticker-for-iphone, then verify that the pull request head contains the published commit before reporting success. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. For a fixed thread, reply with as the first line and as the second line. For a no-code disposition, use followed by . These result markers authorize the workflow to close that exact thread only after it verifies a fixed commit is the pull request head; a local-only commit is not a fix. If publication or verification fails, do not use either result marker, do not claim success, and leave the thread open with the blocker. If human input or new authorization is required, do the same. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #9651 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Summary
Testing
|
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/globals.css`:
- Around line 1825-1828: Restore declaration spacing in the affected CSS blocks
by inserting an empty line between the preceding custom-property declaration and
each of the min-height, gap, and line-height declarations, including the
additional locations noted in the review.
- Around line 1825-1861: Replace the local ticker measurement custom properties
and hardcoded values in the smart-search phone ticker styles with shared
Tailwind 4 `@theme` tokens. Define any missing spacing or line-height tokens in
the existing `@theme` section, then reference those tokens from the ticker
container, .smart-search-phone-ticker-kicker, and
.smart-search-phone-ticker-query while preserving the current visual values.
In `@src/components/clinical-dashboard/master-search-header.tsx`:
- Line 1822: Update the showPhoneSuggestionTicker prop in the relevant header
component to pass showPhoneSuggestionTickerOnHome directly, removing the
isDesktopHomeComposer exclusion so standalone phone hero composers receive the
ticker while existing CSS controls desktop visibility.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8d32c6f1-458d-4fe8-9a67-98d1b667dd1d
📒 Files selected for processing (6)
src/app/globals.csssrc/components/clinical-dashboard/global-search-shell.tsxsrc/components/clinical-dashboard/master-search-header.tsxsrc/components/clinical-dashboard/universal-search-command-surface.tsxtests/helpers/style-contracts.tstests/ui-overlap.spec.ts
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/ClinicalDashboard.tsx`:
- Line 3353: Update the showPhoneSuggestionTickerOnHome prop in
ClinicalDashboard so the ticker is enabled only when showSharedHome or an
equivalent dedicated home-state predicate is true; remove the pathname === "/"
condition that also matches submitted, loading, answer, and error states.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4f693922-ee57-4ad1-bf5a-587bd679b37d
📒 Files selected for processing (3)
src/components/ClinicalDashboard.tsxsrc/components/clinical-dashboard/global-search-shell.tsxsrc/components/clinical-dashboard/master-search-header.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
- src/components/clinical-dashboard/global-search-shell.tsx
- src/components/clinical-dashboard/master-search-header.tsx
Uh oh!
There was an error while loading. Please reload this page.
f78ba92 to
e50e01eCompareUh oh!
There was an error while loading. Please reload this page.
BigSimmo
commented
Aug 10, 2026
Unblock snapshot for #1805 (final):
Residual risk: no remaining open required threads/check failures at merge time. |
Motivation
Description
SmartRotatingHintwithshowPhoneTickerandonPickExampleand rendering a phone-only button that inserts the suggestion into the composer. (seesrc/components/clinical-dashboard/universal-search-command-surface.tsx)showPhoneSuggestionTickerto theUniversalSearchCommandSurfacecall site inmaster-search-header. (seesrc/components/clinical-dashboard/master-search-header.tsx)src/app/globals.css)tests/ui-overlap.spec.ts)AGENTS.mdto keep the repo-generated header stable.src/components/clinical-dashboard/universal-search-command-surface.tsx,src/components/clinical-dashboard/master-search-header.tsx,src/app/globals.css,tests/ui-overlap.spec.ts,AGENTS.md.Testing
npm run workflow:design-sweep -- --write-evidenceandnpm run ensure, both completed successfully.npm run test:e2e:pr -- tests/ui-overlap.spec.ts --grep "smart search", which performed the build and executed the relevant Chromium tests; the targeted overlap tests passed (2 passed).npm run verify:phone-chrome -- --dry-runand the docs index checknode scripts/check-codebase-index-coverage.mjs, both reported OK for the scoped checks.npm run format(Prettier) and ran the repository docs/site-map update; documentation synchronization completed during the pre-commit task.artifacts/iphone-suggestion-ticker.png(390×844, deviceScaleFactor 3), which shows the new ticker on the iPhone layout.All automated checks above completed successfully in the local run; creating a remote PR/push was not performed from this environment (GitHub CLI was not authenticated here).
Codex Task
Summary by CodeRabbit
New Features
Bug Fixes