Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/branch-review-ledger.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -880,3 +880,4 @@ Records before 2026-07-28 were written by hand and had drifted: 146 lines carrie
| 2026-08-10 | cursor/smarter-meds-search-9c1b (PR #1785) | 5cb0e11e077a3aaf5b8e4ea37b26ac72b0328997 | PR #1785 unblock/fix | before: Production UI (3) failed on service-detail scroll endpoint (remaining 67px) at 38b3bd0c; GitHub DIRTY behind-but-clean vs #1791. after: merged origin/main + re-scroll toPass fix in ui-tools service-detail test; threads untouched; do not merge | CI Production UI (3) logs; git merge-tree clean; prettier ui-tools; product fix in same tip commit as this row |
| 2026-08-10 | PR #1800 / codex/enhance-search-function-with-fuzzy-matching | 93da84b063c9c3f956da7ef79710d2cd00159735 | PR #1800 babysit | Synced origin/main (merge-tree clean; GitHub DIRTY was staleness). Fixed CodeRabbit SSRI/SNRI fuzzy cross-match (floor 5 chars) in follow-on tip commit. Clinical Governance Preflight required for clinicalRisk body. Codex P2 field-aware/per-token fuzzy deferred. RAG surfaces untouched. | focused catalog-search+consumers 49 pass; pr-policy body local ok; merge-tree clean |
| 2026-08-10 | PR #1803 / claude/codex-m4b-shadow-tight-migration-53a8kn | b778a56e9c3fa7642a783dde85e1130559d71e24 | shadow-tight token migration onto the e1 elevation tier and alias retirement (#262 part 1) | Migrated all 150 var(--shadow-tight) occurrences across 71 files to var(--e1) (90 gated production sites across 48 files, 60 mockup); deleted all three alias declarations (:root, .dark, forced-colors); pinned legacyShadowAliases 220 to 127 with exact per-path counts, closing 3 aliases of re-accumulated slack; added a whole-stylesheet absence assertion (mutation-verified); updated GATES.md section 3 plus a new section 6, TOKENS.md section 6, design-system.md, both redesign direction docs, .design-sync/conventions.md and ledger #262. Verified in Chromium that the ckb-v2 tier override is picked up by the alias substitution, so the change is value-preserving; that check is recorded as a prerequisite for the remaining six aliases. | npm run verify:cheap (30 static gates plus lint plus typecheck green; design-system contract passed, legacy shadow aliases 127; unit suite 553/554 files, 6024 tests passed, 1 pre-existing root-permission failure in tests/pr-handoff-stop.test.ts reproduced on untouched base a16dd26); npm run format:check whole tree; targeted Chromium computed-style measurement. verify:ui not run, Playwright browser revision drift #255, delegated to CI Production UI. No provider-backed gates. |
| 2026-08-11 | claude/codex-m4c-retire-shadow-nliak3 | 448a0d084c4cd2cda6153dd7f03dcb67c43a8df0 | DS Track A2 (#261): retire --shadow-focus; composer focus onto sanctioned outline; contract guard; baseline ratchet; design-system docs + ledger | Approved — PR #1807. Token deleted in both themes; .chat-composer-shell-delta:focus-within uses outline 2px var(--focus) at offset 2px and no longer overrides box-shadow. Reach premise corrected: 0 of 37 production routes render the class (only /mockups/calculators-search). legacyShadowAliases 127->125, globals.css pin 3->1. | check:design-system-contract PASS; design-token-contract.test.ts PASS + mutation-verified both ways; verify:pr-local PASS except pre-existing tests/pr-handoff-stop.test.ts failure baselined on untouched base e8b61d8; build PASS; check:rag:fixtures PASS (36 cases); Chromium look both themes on the mockup route (inspection only, rev 1194 vs pinned 1234 #255); verify:ui/verify:phone-chrome NOT run — delegated to CI |
3 changes: 2 additions & 1 deletion docs/design-system.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -153,7 +153,8 @@ Icon **glyphs** use the parallel `--spacing-icon-*` scale in `@theme`:
- The surviving role names are **aliases onto tiers**, not independent values:
`--shadow-card` / `--shadow-soft` → `--e2`; `--shadow-hover` → `--e3`; `--shadow-elevated` /
`--shadow-lux` → `--e4`. `--shadow-tight` is retired — the resting hairline is `--e1` at the
call site. `--shadow-inset`, `--shadow-rail-active`, `--shadow-focus` and
call site. `--shadow-focus` is retired too — focus is an `outline: 2px solid var(--focus)`,
never a companion shadow ring. `--shadow-inset`, `--shadow-rail-active` and
`--glow-primary/soft` stay bespoke. All are removed under forced-colors, ladder included.
- No literal `box-shadow` values in components — reach for a tier
(`shadow-[var(--e2)]`, `hover:shadow-[var(--e3)]`) or a role alias.
Expand Down
19 changes: 11 additions & 8 deletions docs/design-system/GATES.md

Large diffs are not rendered by default.

11 changes: 11 additions & 0 deletions docs/design-system/HANDOVER-2026-08-07.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,17 @@
> conclusion: the ubuntu CI job already produces the only ones that count. They are still
> uncommitted — `#118` remains open, and `tests/__screenshots__/` holds only `README.md`
> until reviewed Linux PNGs are adopted.
> - **A2's "visible focus-state change on the search composer"** overstates the reach.
> Correction #2 below is right that `--shadow-focus` has a live consumer and that a
> `--include=*.tsx` grep misses it — but the consumer class reaches **no production
> route**. `.chat-composer-shell-delta` comes from `chatComposerShell`, imported only by
> `calculators/search-detail.tsx` and its mockup twin; the production `/calculators` page
> renders `chatComposerShellBase` + `answer-footer-search-pill` instead, and
> `CalculatorSearchHome` is reached only from two unrouted mockup exports. Measured
> 11 Aug 2026 by probing all **37** static production routes in Chromium: **zero**
> render the class; the single live render is `/mockups/calculators-search`. So A2 was a
> correctness fix to production CSS with no production pixel moving today — do the
> Chromium look on the mockup route, which is where it is visible. Retired in `#261`.
> - **`#270`'s "22 call sites pair a tap token with a dead numeric height"** does not
> survive re-measurement at all: **zero** same-variant pairs exist, and the 84 survivors
> are live cross-variant responsive step-downs rather than dead classes. The stated
Expand Down
6 changes: 3 additions & 3 deletions docs/design-system/SPEC.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -263,8 +263,8 @@ The ladder itself is gated against baked-in hairlines (**[verified:** contract t

`--shadow-inset` **stays the DS bevel**; `--shadow-well` is the recessed-well role. The
former v2 `--shadow-inset` overrides became `--shadow-well` in `59e4c3dfc`, with the
contract test's pin updated in the same commit (C1, done). Alias cleanup: `--shadow-focus` is deleted (it encodes a
companion focus ring the conventions forbid), `--shadow-lift` retires into the ladder, the
contract test's pin updated in the same commit (C1, done). Alias cleanup: `--shadow-focus` is deleted (done
11 Aug 2026 — it encoded a companion focus ring the conventions forbid), `--shadow-lift` retires into the ladder, the
three dead springs go — **retire aliases inside the recipes first**, or "never use an alias"
is unfollowable.

Expand DownExpand Up@@ -796,7 +796,7 @@ close this runtime concern; revisit before adoption puts them on a hot path.

| PR | Contents | Status |
| ------------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------- |
| PR 9 · Motion, stacking, edges | Wire `--duration-*`/`--ease-*`/`--z-*` to utilities + lint; `transform` for `Progress`, `LinkAction`, `ToggleSwitch`; edge-rule gate; `Quantity` off the retiring type step; delete `--shadow-focus`, `--shadow-lift`, dead springs | open |
| PR 9 · Motion, stacking, edges | Wire `--duration-*`/`--ease-*`/`--z-*` to utilities + lint; `transform` for `Progress`, `LinkAction`, `ToggleSwitch`; edge-rule gate; `Quantity` off the retiring type step; delete `--shadow-focus`, `--shadow-lift`, dead springs | open — `--shadow-focus` deleted 11 Aug 2026 (`#261`); the rest of the row is untouched |
| PR 10 · Overlays | One `OverlayRoot`; mandatory `Sheet` name; portal by default; `Tooltip` composes child handlers; `Toast` splits tone/priority/persistence, pauses on hover and focus | **done** — component/publication contract and app-root mount; v2 style activation is unchanged |
| PR 11 · Print and documents | Print as a tokenised theme; `[data-print-hide]`; print primitives; `DocumentFrame` | open — COMPONENTS §6 |
| PR 12 · Design-sync integrity | Declarations generated from real types; manifest parity; direct tests for every registered component; preview state matrices; `tailwind-merge` or slot props; split `ui-primitives.tsx` | **publication slice done** — deterministic props, parity, previews and direct contract proof; override policy and module split remain deferred |
Expand Down
Loading
Loading