Skip to content

test: de-flake medication-page ui-smoke against transient Suspense duplicate#184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 1 commit into from
Jul 2, 2026
Merged

test: de-flake medication-page ui-smoke against transient Suspense duplicate #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions tests/ui-smoke.spec.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,18 @@ async function gotoApp(page: Page, path: string) {
await page.waitForLoadState("networkidle", { timeout: 15_000 }).catch(() => undefined);
}

async function expectSingleMedicationPage(page: Page) {
// The medication route renders inside GlobalMockupSearchShell, whose Suspense
// fallback and resolved client subtree both render `children`. During a
// navigation/hydration overlap the shared data-testid can transiently resolve
// to two <main> elements and trip Playwright strict mode. Wait for it to settle
// to exactly one before asserting visibility — a genuine permanent double-render
// still fails toHaveCount(1), so this does not mask a real regression.
const medicationPage = page.getByTestId("acamprosate-medication-page");
await expect(medicationPage).toHaveCount(1);
await expect(medicationPage).toBeVisible();
}

function visibleQuestionInput(page: Page) {
return page.locator('[aria-label^="Search indexed guidelines by question or keyword"]:visible').first();
}
Expand DownExpand Up@@ -1114,11 +1126,11 @@ test.describe("Clinical KB UI smoke coverage", () => {
await expect(acamprosateResult).toHaveAttribute("href", "/medications/acamprosate");
await acamprosateResult.click();
await expect(page).toHaveURL(/\/medications\/acamprosate$/, { timeout: 30_000 });
await expect(page.getByTestId("acamprosate-medication-page")).toBeVisible();
await expectSingleMedicationPage(page);

await gotoApp(page, "/mockups/medication-prescribing");
await expect(page).toHaveURL(/\/medications\/acamprosate$/);
await expect(page.getByTestId("acamprosate-medication-page")).toBeVisible();
await expectSingleMedicationPage(page);
});

test("document search mode lists matching documents and scope actions", async ({ page }) => {
Expand Down
Loading