fix(services): restore Services task navigation and remove walkthrough from results

[BigSimmo]

Summary

• Restores the task-based Services landing page unless a submitted search is present.
• Keeps service-group browsing, shortlist, comparison, and referral-link behaviour while removing the unintended in-results walkthrough.
• Canonicalises a non-empty legacy query when canonical q is empty or whitespace, so the shared search shell and Services results use the same search term.
• Resolves the branch conflict against current main while preserving the current-main branch-review ledger.

Verification

• npm run test -- tests/audit-content-services-regressions.test.ts — passed, 6 tests.
• npm run typecheck — passed.
• Browser verification at 390 × 844 confirmed service-group navigation remains present and the referral walkthrough is absent.
• Regression coverage now exercises legacy-query canonicalisation and clears Services filters through the stable filter-control test ID.
• All required GitHub checks on the final head are merge gates and must pass before merge.

Risk and rollout

• Risk is limited to /services route selection, Services home/navigation presentation, and its Playwright coverage.
• No database, schema, ingestion, provider, retrieval-ranking, authentication, or deployment configuration changes.
• Legacy query links remain supported and are redirected to canonical q only when q is not meaningful.
• Rollback is a single revert of the squash merge.

Clinical Governance Preflight

• Clinical content changed: No.
• Clinical decision-support logic changed: No.
• Retrieval, ranking, source-governance, privacy, or safety policy changed: No.
• The change is restricted to Services navigation and URL semantics.

Notes

• All inline review threads are resolved and no review is in a changes-requested state.
• The merge conflict was limited to docs/branch-review-ledger.md; current-main records were retained and the PR review record was appended.
• CI root causes repaired: inconsistent legacy/canonical query handling and a stale Playwright locator for the visible Clear filters action.

---

Codex task

[coderabbitai]

📝 Walkthrough

Walkthrough

The services route now validates search parameters before opening service navigation. The services home page uses shared mode-home rendering and default service selection. The referral workflow and related navigation state were removed, with UI tests updated accordingly.

Changes

Services UI flow

Layer / File(s)	Summary
Services route selection src/app/(search-app)/services/page.tsx	The route accepts q or query, trims the value, and renders navigation only when run=1 and the query is non-empty. The home page receives the default service slug.
Shared services home rendering src/components/services/services-home-page.tsx, tests/ui-tools.spec.ts	The home page builds shared task cards and pathway pills through ModeHomeTemplate. Registry content renders verification records or the existing registry notice. Tests verify that the referral workflow is absent.
Referral workflow removal and regression coverage src/components/services/services-navigator-page.tsx, tests/ui-tools.spec.ts	The navigator no longer derives referral stages or renders ServiceReferralFlow. Obsolete browsing, comparison, and mobile navigation tests were removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• BigSimmo/Database#890: Introduces the defaultServiceSlug flow used by this services home update.
• BigSimmo/Database#887: Refactors a mode home screen around the shared ModeHomeTemplate structure.
• BigSimmo/Database#1829: Added the referral-flow and shortlist-oriented services UI removed by this PR.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes restoring Services task navigation and removing the results walkthrough.
Description check	✅ Passed	The description includes all required sections and provides relevant verification, risk, rollout, and governance details.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/investigate-navigation-changes-in-services

---

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:a766250f63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[BigSimmo]

@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. The only repository destination is BigSimmo/Database, and the only branch destination is the pull request head branch codex/investigate-navigation-changes-in-services at starting commit a766250; never publish fixes to a detached or synthetic work branch and never create a stacked pull request. Use the authenticated GitHub connector to commit each approved fix to BigSimmo/Database:codex/investigate-navigation-changes-in-services, then verify that the pull request head contains the published commit before reporting success. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. For a fixed thread, reply with as the first line and as the second line. For a no-code disposition, use followed by . These result markers authorize the workflow to close that exact thread only after it verifies a fixed commit is the pull request head; a local-only commit is not a fix. If publication or verification fails, do not use either result marker, do not claim success, and leave the thread open with the blocker. If human input or new authorization is required, do the same. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 👍

Reviewed commit:a766250f63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/`(search-app)/services/page.tsx:
- Around line 17-22: Update the search query construction in the page component
to trim each q and query alias before applying nullish fallback, so
whitespace-only q values do not suppress a non-empty query value. Preserve the
existing submitted-search check and add a regression test for
/services?q=%20&query=13YARN&run=1.
In `@src/components/services/services-home-page.tsx`:
- Around line 20-44: Update buildTaskCards so the “Check catchment” task is
included only when defaultServiceSlug is non-null, and construct its detail href
using the existing route or catalog source from app-modes.ts, tools-catalog.ts,
or universal-search.ts rather than a hardcoded path. Preserve the other task
cards unchanged.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2155b148-7973-44ba-a988-698a72d55f5d

📥 Commits

Reviewing files that changed from the base of the PR and between bc00419 and 0b6750d.

📒 Files selected for processing (4)

• src/app/(search-app)/services/page.tsx
• src/components/services/services-home-page.tsx
• src/components/services/services-navigator-page.tsx
• tests/ui-tools.spec.ts

💤 Files with no reviewable changes (1)

• src/components/services/services-navigator-page.tsx

[github-actions]

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

• Production UI (3) — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
• PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #9889 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.