[WIP] Fix WebKit coverage for forms detail search - #186
Merged
Conversation
…c fills on detail pages The shell's mount effect unconditionally reset `query` to "" via requestAnimationFrame when the URL had no `q`/`query` param. On detail pages (e.g. /forms/transport-crisis-form) this raced with programmatic fills in WebKit, leaving the input empty and submit disabled. Now the effect only clears the query on mode home routes, preserving user/test input on detail pages. This keeps WebKit coverage for the forms detail search test without needing a test.skip. Closes#185 Agent-Logs-Url: https://github.com/BigSimmo/Database/sessions/f1cecad8-270c-4a3c-80fb-8082b6377543 Co-authored-by: BigSimmo <87357024+BigSimmo@users.noreply.github.com>
BigSimmo
marked this pull request as ready for review
July 2, 2026 14:41
BigSimmo
enabled auto-merge (squash)
July 2, 2026 14:41
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:d741fa3336
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:8703bf473c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
BigSimmo
disabled auto-merge
July 2, 2026 16:10
BigSimmo
enabled auto-merge (squash)
July 2, 2026 16:10
Uh oh!
There was an error while loading. Please reload this page.
4 tasks
10 tasks
BigSimmo added a commit
that referenced
this pull request
Aug 1, 2026
Resolve docs/error-tracking.md by keeping both the ingestion-worker section and main's Agent Monitoring wizard mapping. Resolve docs/outstanding-issues.md by keeping main's open rows, removing the blank line that orphaned #183/#186 outside the open table, renumbering this PR's npm lockfile issue to #204, and bumping issues:next-id to 205. Co-authored-by: Cursor <cursoragent@cursor.com>
11 tasks
CopilotAI
added a commit
that referenced
this pull request
Aug 12, 2026
fix#186 archive - Restore #156 (read-modify-write race + Update-branch corruption) from archive back to the open issues section with its original full text; the underlying allocation race is not resolved by the conservative architecture decision described in the previous commit. - Re-add #156 to the recommendations priority table as row 51 (between #101 and #172, consistent with its original ordering). - Correct #101 to credit only metadata and memory parallelisation (hydrateCandidatesWithMetadataAndMemory) from PR #1474; visual hydration (attachPageVisualEvidence) is still called serially after hydration on all six call sites and is explicitly listed as a remaining candidate. - Update #186 archive text to reflect that only metadata+memory were updated in #101, not visual hydration. Co-authored-by: BigSimmo <87357024+BigSimmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.