chore: sync main into PR 1864 branch - #1871
Conversation
…bar a job Rounds one and two settled the information architecture. This is craft, drawn on the formulation sheet because it stresses the layout hardest: two groups, sixteen options, and the longest title in the app. The segment bar now carries SCOPE, not a verb. Round two used it for "narrow these / start a new search", which is a mode set once and rarely changed — a poor use of the most valuable strip in the sheet. Here it is "These results 2 | All mechanisms 12" with live counts on both segments. That is a decision the reader makes constantly and which nothing in the product answers today: filtering two results by twelve domains is close to pointless, and the only route to the full set is clearing the query and losing it. It also makes the empty state recoverable — the commit button becomes "Show N in all mechanisms" rather than a dead end. Three defects the study documents, all verifiable in source: - Biological, Social and Cultural are offered as domain chips and match zero of the twelve mechanisms. Counts expose this on sight. - formulationDomainGroups already exists in src/lib/formulation.ts, with four themes each carrying a written description, and the sheet ignores it in favour of one flat ragged wrap of twelve chips. - formulationSearchPresets.slice(0, 4) of five leaves "If it is not perfect" unreachable from the filter. Three styles over one shared set of craft fixes: A refined clinical, B themed cards, C dense list. Counts here are intrinsic (how many mechanisms carry that domain) rather than the services study's "total if I added this". Domains are a single OR group, so the union contract reports the unchanged total for an empty domain — Cultural would read 7, indistinguishable from a full one. The commit button remains what predicts the outcome. The desktop specimen's min-width is gated at sm: unconditional, it propagated out of its scroll box into the grid track and scrolled the page 45px at 320px, the blocking narrow breakpoint. Measured, not assumed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011btGFwWKYFWDs5McQkqz9J
Written into AGENTS.md by next dev via node_modules/next/dist/server/lib/generate-agent-files.js, verified present. Left uncommitted it regenerates on every dev-server start and leaves a permanently dirty tree; committed here on its own rather than buried inside an unrelated design change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011btGFwWKYFWDs5McQkqz9J
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011btGFwWKYFWDs5McQkqz9J
…esign-mockups-x6sbjv
…ps-x6sbjv' into claude/filter-popup-design-mockups-x6sbjv
Another agent synced this branch from main as b34be0c while I was doing the same. Their conflict resolution dropped two append-only rows that were present on the branch at 442b709 and are not on main: 2f69b23... claude/filter-popup-design-mockups-x6sbjv — the PR #1846 record e34a617... 1846 — the full-PR-diff review record Both restored verbatim in their original position rather than re-appended, so the records keep their own SHAs and evidence rather than becoming new same-day rows. AGENTS.md: the ledger is append-only and syncs must not rewrite existing rows. Four other rows appeared in the diff as moved rather than lost — the union driver reorders on merge — and were verified present in main, their sync and mine before concluding anything about them. ledger:dedupe reports 865 unique rows, the guard passes, and my own redundant main merge was folded into their tip rather than stacked as a second sync. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011btGFwWKYFWDs5McQkqz9J
…ps-x6sbjv' into claude/filter-popup-design-mockups-x6sbjv
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
bcb39e5
into
codex/tools-results-mode-mockupUh oh!
There was an error while loading. Please reload this page.
BigSimmo
commented
Aug 12, 2026
Final review-and-fix summaryFinal state and integration
Findings, fixes, and ledger
Adversarial review and comments
Verification
Infrastructure residual and disposition
|
Mechanical late branch sync for #1864 after required CI completed. This merges the current
maintip intocodex/tools-results-mode-mockupso the reviewed PR is tested against the latest base. No independent product scope.