docs(issues): re-file the #210 correction lost in the inbox migration

[BigSimmo]

Summary

• Re-files the #210 correction as an inbox request. It was written directly into docs/outstanding-issues.md by PR fix(hooks): unblock verify:pr-local in web sessions; answer #248 offline half and correct #210 #1880, which landed while the inbox architecture was being introduced. No inbox request was created for it, so the correction never reached main and the canonical row still prescribes a fix that does not work.
• Why it matters: the row tells the next reader to drop .next/dev/types/**/*.ts from tsconfig.json. Next 16 emits that glob itself — getTypeDefinitionGlobPatterns adds both .next/types and .next/dev/types deliberately "to avoid tsconfig churn when switching between dev/build modes" — and writeConfigurationDefaults (lines 302–316) pushes any missing glob back into an existing include on every next dev / next build. Applying the row as written produces a change that silently reverts, and the evidence for that is currently recorded nowhere.
• The request also carries the half that is already fixed (npm run typecheck has used tsconfig.typecheck.json since 450690f, which excludes .next/**), the narrower remaining scope (scripts/run-playwright.mjs writes an isolated tsconfig with no include of its own, so it inherits the repo-root globs), and an explicit note that this remaining part is not proven end to end — reproducing it needs one verify:ui build before and after, because next build mutates that isolated config before typechecking.

Deliberately not included, to avoid churn rather than for completeness:

• No row for the SessionStart marker defect. It was fixed in PR fix(hooks): unblock verify:pr-local in web sessions; answer #248 offline half and correct #210 #1880 and is documented in the code comment and commit message at the point of change; adding it now would land an open row for finished work, which the ledger would then have to close.
• No re-append of the two docs/branch-review-ledger.md rows lost in the same merges. Both branches are merged, and the review protocol already skips branches merged into main, so the rows would be inert.

Verification

• npm run verify:pr-local

PR-local verification summary:
- completed: check:runtime, check:installed-lock-parity, format:changed, sitemap:check,
docs:check-index, docs:check-inventory, docs:check-scripts, docs:check-links,
check:branch-review-ledger, check:outstanding-issues, check:ledger-write-discipline
- failed: (none)
- not reached: (none)
Ledger write discipline passed for 2d270392f9cf..HEAD.

Selection was the recognised low-risk scope (lint, typecheck, full unit suite and RAG fixture scan skipped), confirmed with --dry-run before running. check:ledger-write-discipline is the relevant gate here and it passes: the change is one immutable inbox request and the canonical ledger is untouched.

UI verification not run: no UI, routing, styling or browser behaviour in this diff.

Risk and rollout

• Risk: None to the running system. The diff is a single new JSON request file under docs/outstanding-issues-inbox/; no source, config, schema or generated asset is touched. It changes documentation only, and only once npm run issues:reconcile applies it.
• Rollback: git revert the commit, or land an immutable cancellation request per the inbox README (node scripts/ledger-inbox.mjs cancel <uuid> --reason …) if it has already been reconciled.
• Provider or production effects: None.

Notes

• After this lands, npm run issues:reconcile on a dedicated branch will apply this request together with the 14 already queued — including the done #177 and done #180 requests from PR fix(therapies): stop the catalogue generator consuming its own output (#180) and serve aliases by rewrite (#177) #1886. Until that runs, the canonical ledger still shows #177 and #180 as open with their pre-fix text, even though both defects are fixed on main.
• No ## Clinical Governance Preflight and no RAG impact: line: classifyPullRequestFiles reports clinicalRisk: false, operationalRisk: false, ragRanking: false, ui: false for this path.

---

Generated by Claude Code

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:10 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e8b4f20b-5654-462e-8a0f-344be6cfb014

📥 Commits

Reviewing files that changed from the base of the PR and between eac9c4d and 9babc0d.

📒 Files selected for processing (2)

• docs/branch-review-records/768eb9c577b6057fbf79b8bfa70828b97833416d4dbfa1e821490d5d90b16df4.record.md
• docs/outstanding-issues-inbox/24586190-0756-488d-941e-70a970c13cce.json

---

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:cbc6966d86

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[BigSimmo]

Codex PR review-and-fix summary

Final state

• PR:docs(issues): re-file the #210 correction lost in the inbox migration #1924 — docs(issues): re-file the #210 correction lost in the inbox migration
• Final reviewed and pushed head:6e9992c039744d1096adb02df2c3297ae9907144
• Latest base:main at 984f42c07326d7561ebb3d992a8024173c02aaaa
• Branch state: 3 commits ahead and 1 commit behind latest main.
• Merge-tree: clean. GitHub generated synthetic merge commit 1d7d2c337f74e9a9505254715f1056355ab1c4dd with parents 984f42c07326d7561ebb3d992a8024173c02aaaa and 6e9992c039744d1096adb02df2c3297ae9907144.
• Sync decision: the head moved independently during review from cbc6966d86e2b884194898965369a80a7d1e5759 to 31ff86b2a66656e13838545613052e4e13f70d57 through an external merge of main; I paused and re-snapshotted. I did not add another base merge because the latest-base merge-tree is clean and no merge or required-CI blocker requires synchronisation.
• Auto-merge: squash auto-merge is armed and was left unchanged.

Issue fixed

• P2 — false execution model in the fix(eval): resolve tsx runtime from ancestor node_modules in worktrees #210 correction: the request said the isolated Playwright tsconfig.json was mutated by next build. This is false for Next 16.3 because writeConfigurationDefaults returns immediately when the parsed config contains extends or references, and this child config always contains extends.
• Updated the inbox request to state that the child config is not mutated, preserve only the narrower inherited-root-include/default-CLI-checker hypothesis, and require a focused before/after verify:ui build plus child-config hashes before treating that remaining hypothesis as proven.
• Added the matching immutable heavy-review record in the same fix commit. No ledger-only tip was created.

Scope and dispositions

• Final PR delta is exactly two documentation files: the corrected immutable inbox request and its immutable branch-review record.
• No source, runtime configuration, schema, generated asset, deployment, dependency, or clinical content changed.
• The canonical docs/outstanding-issues.md row remains unchanged until the inbox request is reconciled. That reconciliation and any later Playwright implementation are outside this PR.
• The underlying Playwright-build failure was not reproduced end to end, so the request now records that uncertainty instead of claiming a verified cause.

Independent adversarial review

• An independent Codex connector review identified the P2 finding.
• I independently validated it against scripts/run-playwright.mjs, the project’s pinned Next 16.3 behaviour, the default TypeScript CLI path, and an equivalent child-tsconfig probe before changing the repository.
• A distinct final manual adversarial pass checked correctness, scope creep, compatibility, security/privacy impact, schema validity, and the complete two-file patch. No further PR-introduced P0, P1, or reproducible P2 defects were found.
• CodeRabbit selected the final two files but did not complete a review because the organisation’s adaptive review limit and spending cap were reached. No CodeRabbit result is being claimed.

Review threads

• Actionable threads: 0 unresolved.
• The sole P2 thread was replied to with the fixed head SHA and resolved after the pushed bytes were verified.

Decisive verification

• Next 16.3 source audit confirmed the extends/references early return.
• TypeScript 5.8.3 child-config probe:
  • --showConfig confirmed inheritance of ../../.next/dev/types/**/*.ts.
  • --listFilesOnly confirmed inclusion of the root .next/dev/types/validator.ts.
  • Child-config SHA-256 before and after TypeScript inspection was identical: c3c05c93f43026189bc04d486b9dc82232c10ef482f411809d12245ce4c5f61f.
• Corrected request JSON parsed successfully.
• The content-addressed review-record path was generated and checked against the repository’s row-sanitisation and SHA-256 convention.
• The final remote head, both remote file blobs, and the complete PR patch were re-read after push and matched the reviewed commit.

Exact-head required CI

All applicable required evidence is attached to exact head 6e9992c039744d1096adb02df2c3297ae9907144:

• PR required: SUCCESS
• CI: SUCCESS
• Static PR checks: SUCCESS, including runtime alignment, installed-lock parity, branch-review ledger integrity, outstanding-issues integrity, ledger write discipline, documentation inventory/scripts/links, changed-file formatting, and sitemap checks
• SAST: SUCCESS
  • Semgrep ingestion gate: SUCCESS
  • Semgrep: SUCCESS
• Secret Scan: SUCCESS
  • Pinned-head Gitleaks scan: SUCCESS
• Pending required checks: none
• Missing required checks: none
• Failed required checks: none
• Production UI, Production UI critical, build, unit coverage, migration replay, safety/config, and container-image jobs were skipped as out of scope for this documentation-only change. They are not being described as passed.

Advisory checks

• Advisory UI, visual baselines, Lighthouse, and release-browser-matrix jobs were skipped by the documentation-only scope classifier.
• Supabase preview was ignored because the PR has no supabase/ changes.
• CodeRabbit review was unavailable due its external rate/spending-cap limitation.

Limitations and residual risk

• The environment had no repository checkout, gh, or matching Node 24/npm 11 toolchain, and external cloning was unavailable. I therefore could not create a real local worktree or rerun the complete repository gate locally. The focused probe was run in an isolated scratch directory, and the authoritative repository checks reran on GitHub against the exact pushed head.
• No full Next/Playwright verify:ui build was run. The remaining inherited-include hypothesis is explicitly unproven and requires that focused before/after build in its eventual implementation PR.
• The PR description still contains the superseded mutation wording; repository protocol does not permit title/body edits without explicit metadata authorisation. The committed request and this summary contain the corrected model.
• No hourly interval elapsed after readiness. Monitoring stopped at the configured stop condition: clean merge-tree, zero actionable threads, and all required checks green. Continued hourly monitoring is unavailable after this active execution ends.

The PR was not merged. Final merge is left to the user.