docs(issues): queue a capture for the four placeholders #291 deliberately left native

[BigSimmo]

Summary

• Queues one outstanding-issues inbox request recording the four unavailable-placeholder controls that PR fix(a11y): make unavailable placeholder buttons reachable by keyboard #1778 deliberately left on native disabled when it converted the other 25 and settled the encoding question (#291). They were written down only in that PR's description, so they would have been lost as soon as it scrolled out of view — which is the failure mode this ledger exists to prevent.
• Filed as an inbox request, not an edit to the canonical ledger. The id is allocated at reconciliation, so this cannot collide with a concurrent session's append — which was the exact reason the capture was deferred out of fix(a11y): make unavailable placeholder buttons reachable by keyboard #1778 in the first place.
• Each entry records why it was left, not a bare TODO, and all four were re-verified as still native against main at 2d27039 rather than trusted from the older PR text:
  • differentials/differential-presentation-workflow-page.tsx — four "not available in this comparison view" placeholders (216, 226, 607, 619) plus the Compact/Detailed density pair (798). They qualify, but the page is scheduled for a rewrite and tests/mobile-interaction-regressions.test.ts:80 still pins the density pair as native-only, so converting means editing that pin too.
  • document-viewer/document-image-filmstrip.tsx:45 — untouched because a parallel session owned that subtree.
  • DocumentViewer.tsxsummarizeTitle (907, used at 1215) — the only one needing a decision rather than an edit: it folds a persistent auth reason and a transient loading state behind one canSummarizeDocument flag, so it is half stated-reason and half transient. Split the flag before classifying it.
  • clinical-dashboard/search-pins-menu.tsx:453 — "Maximum N pins reached" states a reason but is a capacity state the user clears themselves; left native as transient, and recorded as a judgement call rather than an oversight.

Verification

• npm run verify:pr-local — completed: check:runtime, check:installed-lock-parity, format:changed, sitemap:check, docs:check-index, docs:check-inventory, docs:check-scripts, docs:check-links, check:branch-review-ledger, check:outstanding-issues, check:ledger-write-discipline, failed: (none), not reached: (none). Docs-only scope, so lint/typecheck/unit/build were selected out — confirmed with --dry-run first.
• npm run check:outstanding-issues — Ledger inbox check passed: 15 pending request(s), 0 applied. / Outstanding-issues guard passed: 310 rows (114 open, 196 archived), unique ids, next-id=313 above the highest.
• npm run check:ledger-write-discipline — Ledger write discipline passed for 2d270392f9cf..HEAD.
• npm run format run and committed; npx prettier --check . → All matched files use Prettier code style!

One verification note worth keeping. My first attempt edited docs/outstanding-issues.md directly with scripts/outstanding-issues.mjs, and check:ledger-write-discipline reported passing — because it compares base..HEAD commits and the edit was still uncommitted. It only failed once the change was committed, at the pre-push guard. So a green run of that gate against a dirty tree means nothing; it has to be re-run after committing. That is what caught the direct edit and sent this down the inbox path.

Risk and rollout

• Risk: None to product behavior. One added JSON file under docs/outstanding-issues-inbox/; the canonical ledger is byte-unchanged in this PR.
• Rollback: delete the request file, or node scripts/ledger-inbox.mjs cancel 38e25384-5dcb-463d-b1b7-e0caea60bb83 --reason "..." if it has already landed and should not apply.
• Provider or production effects: None.

Notes

• Run npm run issues:reconcile from a dedicated ledger branch after this lands to allocate the id and write the canonical row; this PR deliberately does not.
• Recorded for context, since it changed what was left to do here: items this capture was queued alongside are already resolved on main — PR fix(runtime): declare and enforce the Node 24.15 floor dependencies already require #1771 landed the Node ≥24.15.0 floor, PR fix(a11y): make unavailable placeholder buttons reachable by keyboard #1778 merged as ccbbb33, #291 is archived as RESOLVED, and the root-sensitive pr-handoff-stop case was fixed upstream by replacing the chmod trick with a directory at the marker path, which fails for root and non-root alike. That is a better fix than the uid-skip I had prepared, so I dropped mine.

🤖 Generated with Claude Code

https://claude.ai/code/session_018hT4qToXT5nr3hV4ENqRgS

---

Generated by Claude Code

Summary by CodeRabbit

• Documentation
  • Added review records documenting resolution and verification of an inbox-count discrepancy.
  • Recorded the status, validation, and CI checks for the related review.
  • Documented four controls using native disabled behavior, including conversion status and follow-up decisions.
  • Added versioned tracking for deferred control classification and superseded requests.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a214287e-c95b-4d2d-8108-938523259c64

📥 Commits

Reviewing files that changed from the base of the PR and between 8ca147d and 000271a.

📒 Files selected for processing (5)

• docs/branch-review-records/7049e97211368e04c1fc07fd352673e255d3c4d4a0aa91c2b6db41db4d685d2b.record.md
• docs/branch-review-records/e2d6c2ebdb0cc2cb0231773185242e7ab74d8cc487dd81ca3b47f1fce8bdb99f.record.md
• docs/outstanding-issues-inbox/1752caad-7fac-4089-a415-d20a26e5984a.json
• docs/outstanding-issues-inbox/38e25384-5dcb-463d-b1b7-e0caea60bb83.json
• docs/outstanding-issues-inbox/47ba09d2-64f6-47ab-8ad6-380fc3f93eee.json

---

📝 Walkthrough

Walkthrough

The PR adds versioned outstanding-issue inbox records for disabled-control follow-up work and cancellation. It also adds branch review records with PR metadata, corrected scope, validation results, and CI status.

Changes

Disabled-control follow-up

Layer / File(s)	Summary
Inbox task lifecycle docs/outstanding-issues-inbox/*.json	The records define the disabled-control follow-up task, its replacement request, and cancellation of the superseded request.
Review verification records docs/branch-review-records/*.record.md	The records document PR metadata, the corrected scope of four groups covering nine controls, completed validation, CI status, and resolved review threads.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score:⚪ Minimal · up to 00027

This documentation-only PR queues outstanding-issue records without changing product behavior or runtime configuration. The relevant checks pass, and no actionable merge-blocking risk remains beyond normal review.

Possibly related PRs

• BigSimmo/Database#1109: The inbox records use the same task-ledger and recommended-queue workflow.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the documentation change: queueing a capture for controls deliberately left native.
Description check	✅ Passed	The description is detailed and covers the change, verification, risk, rollback, and production effects, but its control count wording is inconsistent with the nine controls documented.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/disabled-button-accessibility-piclvr

---

_{Comment @coderabbitai help to get the list of available commands.}

[BigSimmo]

Codex final review summary

State

• Final reviewed head: ff48bab294994470892244c193244c67606f4d3d
• Latest base: 984f42c07326d7561ebb3d992a8024173c02aaaa
• Branch: 6 ahead, 1 behind.
• GitHub merge-tree commit: 3d55c7071cb05b8dde3654ecea21ab18f01d92bb, with the exact head and latest base as parents. The merge tree is clean.
• The branch had already incorporated an earlier main at 1988c762dfa763a38ec1b95cc9855b0db47f2054. No later sync was added because the current merge tree is clean and required CI passed.
• Squash auto-merge remains armed and unchanged.

Review result

• Fixed one PR-introduced P2 documentation error. The original record said “four controls”, but its evidence describes four follow-up groups containing nine controls.
• Applied the repository’s append-only supersession pattern. The original pending record is superseded by count-accurate request 47ba09d2-64f6-47ab-8ad6-380fc3f93eee, which is the sole active replacement during reconciliation.
• Added heavy-review record 7049e97211368e04c1fc07fd352673e255d3c4d4a0aa91c2b6db41db4d685d2b.record.md in the same fix series.
• No product code, dependencies, generated assets, or runtime behaviour changed.
• The underlying product-control conversions are pre-existing P3 follow-up work and remain outside this docs-only PR.

Independent review and threads

• A distinct manual adversarial pass checked the differential page, filmstrip, DocumentViewer, and search-pins evidence. It confirmed 4 + 2 + 1 + 1 + 1 = 9 and found no other actionable PR-introduced defect.
• CodeRabbit did not complete a review because the organisation review spending cap was exhausted. No CodeRabbit result is claimed.
• Unresolved actionable review threads: 0.

Verification

• Offline: JSON parse and schema/UUID validation; supersession-batch simulation confirming one active replacement; explicit count audit; SHA-256 validation of the review-record filename.
• Exact-head required CI: Change scopesuccess on attempt 2; Static PR checkssuccess; PR requiredsuccess.
• Static checks passed formatting, review-ledger integrity, outstanding-issues integrity, ledger write discipline, documentation inventory/scripts/links, codebase index coverage, and sitemap drift.
• Docs-only scoped checks recorded as skipped: Production UI, Production UI critical, build, unit coverage, migration replay, safety/config, and container checks.
• Advisory checks recorded as skipped: Advisory UI, visual baselines, Lighthouse budget, release browser matrix, and baseline refresh.
• Security checks passed: SAST, Semgrep, Secret Scan/Gitleaks, and GitGuardian.
• The first CI attempt ended during the workflow’s five-minute full-history checkout window. The unchanged-head rerun passed.
• No live-service, production, credential-dependent, paid, provider-backed, or Lighthouse execution was performed.

Limitations and residual risk

• This environment had no local checkout, GitHub CLI, or working direct GitHub network path. Hosted exact-head CI and focused offline contract checks are therefore the decisive evidence.
• The PR description still contains the original count wording. Repository review guidance leaves PR-body edits out of scope. The effective inbox batch and this summary contain the corrected scope.
• Product risk is negligible because the final delta is documentation/governance only.
• Continued hourly monitoring is unavailable after this active execution ends.

The PR was not merged. Final merge is left to the user.