Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
| 2026-08-13 | claude/design-issues-triage-wnr7k9 | 615893b24fa2be21e245ef1e47ae2fa1e2e12981 | docs/outstanding-issues-inbox — #210 correction | Corrected #210: typecheck half already fixed by tsconfig.typecheck.json; the prescribed tsconfig.json include edit is reverted by Next (type-paths.js:34-36 + writeConfigurationDefaults.js:305-315). Remaining Playwright-isolated-tsconfig half recorded as not proven end-to-end. Queued as immutable inbox request. | verify:pr-local (all 11 completed, 0 failed) |
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
{
"version": 1,
"id": "04470779-8c8d-4c90-ad04-bc6d613fd73a",
"createdOn": "2026-08-13",
"action": "update",
"payload": {
"id": "#210",
"summary": "npm run ensure's .next/dev types may still break the Playwright isolated tsconfig (typecheck half already fixed)",
"detail": "CORRECTED 2026-08-13 — the 2026-08-12 re-scope on this row was itself half wrong, and the fix it prescribed would have been silently reverted by Next. Two corrections, both verified against the installed tree. (1) The typecheck half is already fixed and was fixed before that re-scope was written: `npm run typecheck` runs `tsc -p tsconfig.typecheck.json` (package.json:38-39), which excludes `.next/**` outright, and that file's own header comment cites this row by number as the reason it exists. `npm run ensure` does NOT break repo-wide typecheck. (2) The prescribed fix — drop `.next/dev/types/**/*.ts` from tsconfig.json:28 `include` — does not hold. Next 16 emits that glob deliberately (node_modules/next/dist/lib/typescript/type-paths.js:34-36, \"to avoid tsconfig churn when switching between dev/build modes\") and writeConfigurationDefaults.js:305-315 pushes any missing type glob back into an existing `include` on every `next dev` / `next build`, so the edit comes straight back and the diff reads as churn. What genuinely remains is narrower: scripts/run-playwright.mjs:253-268 writes an isolated tsconfig setting only `extends: \"../../tsconfig.json\"` plus compilerOptions, so it inherits the root include globs including the dev-types one, and Next's own dev-types filter (getDevTypesPath, only called from runTypeCheck.js:37) is not reached because `experimental.useTypeScriptCli` defaults true (config-shared.js:257) and `next build` therefore shells to the TypeScript CLI. NOT PROVEN END-TO-END: nobody has reproduced the Playwright build failure since tsconfig.typecheck.json landed. Next: reproduce first — `npm run ensure`, confirm .next/dev/types/validator.ts exists, then run a Playwright production build; if it reproduces, give the isolated tsconfig its own `include` list, never an edit to the root config. Stop: do not remove typecheck from the gate (it was never the problem), and do not edit tsconfig.json's include (Next restores it). Provenance: PR #1880 reached both corrections independently on 2026-08-12 but its diff never touched this file, so the correction existed only in that PR body until this row was rewritten."
}
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
{
"version": 1,
"id": "9fded706-51d9-4d8f-9aa4-c57a6b0ac7aa",
"createdOn": "2026-08-14",
"action": "can\u0063el",
"payload": {
"requestId": "04470779-8c8d-4c90-ad04-bc6d613fd73a",
"reason": "Superseded by merged request 24586190-0756-488d-941e-70a970c13cce, whose reviewed detail includes the corrected Next 16.3 child-config early-return behavior and explicit before/after hash verification."
}
}
Loading