docs(issues): reconcile 17 queued ledger requests

[BigSimmo]

Summary

The canonical ledger transaction for the queue that had built up behind this session's four merges (#1982, #1983, #1984, #1985). Run from a fresh-base branch off 2e3ac494 and deliberately serialized, because issues:reconcile is the only writer of docs/outstanding-issues.md and the only allocator of row ids — that serialization is the whole point of the inbox design.

17 requests applied (3 carrying cancellation decisions), and every request keeps its immutable audit record under docs/outstanding-issues-inbox/applied/. Review found stale #265 measurements in the applied text and queued one immutable correction request, so the final branch state is 1 pending / 189 applied.

Six of the 17 are this session's:

• #163 and #164 closed. Both record what was already on main before their PR versus what the PR actually delivered — both rows were part-stale when picked up, and the next reader deserves to know which half was which rather than inheriting the same wrong impression.
• #265 updated, not closed. Gate 2 is closed; gates 7 and 8 remain, so this is issues:update. It carries the corrected debt figure (the row and GATES.md both said 27 conflicts across 15 files; the baseline said 25 across 12, and PR Re-land the --shadow-tight retirement and close three design-token debt rows #1942 had already paid the difference down) and the reason gate 8 was stopped rather than skipped.
• #339, #340, #341 allocated for follow-ups this session surfaced: the favourites Continue/Recent hard-coded demo timestamps, the comps-vs-contract disagreement about results-band weighting, and the remaining unguarded source-slice test windows.

The other 11 were queued by earlier sessions and are applied unchanged. That backlog is what #1980 had captured as its own row.

Verification

• npm run verify:pr-local

- completed: check:runtime, check:installed-lock-parity, format:changed, sitemap:check, docs:check-index,
docs:check-inventory, docs:check-scripts, docs:check-links, check:branch-review-ledger,
check:outstanding-issues, check:ledger-write-discipline
- failed: (none)
- not reached: (none)

The two that matter for this PR type:

Outstanding-issues guard passed: 341 rows (97 open, 244 archived), unique ids,
next-id=344 above the highest, no merge driver, no ids deleted from base 4c4cf4244835.
Ledger inbox check passed: 1 pending request / 189 applied.
Ledger write discipline passed for 4c4cf4244835..HEAD.

check:ledger-write-discipline is the load-bearing one here: it rejects a canonical-ledger diff that does not exactly equal its recorded reconciliation transaction, so it proves this diff is the applied requests and nothing else — no hand-edited rows smuggled in alongside. no ids deleted from base covers the other failure mode, a row silently lost in a merge resolution (#324).

Also verified before running: all four merges landed by content, not just by ancestry — squash rewrites history, so git branch --merged is misleading. Each branch's own changed paths were compared against its squash commit, and the deliverables were asserted present on main individually (step-dot rail, favourites chip rail and live filter, the gate-2 detector and its flipped GATES.md row, the guarded source-contract helper, the retired nav module confirmed deleted).

Risk and rollout

• Risk: low but not zero — this is the one operation that rewrites the shared ledger, and a bad reconcile is annoying to unpick. The guards above are what make it safe: the transaction is content-checked against the requests, no ids can vanish, and every applied request keeps an immutable audit record. No product code changes.
• Rollback: revert the reconciliation and review-follow-up commits. The inbox requests return to pending and can be reconciled again; nothing is destroyed, because reconcile moves requests to applied/ rather than deleting them.
• Provider or production effects: None.

Notes

• RAG impact: no retrieval behaviour change — this PR edits docs/outstanding-issues.md` and moves inbox request files. No source, test, script, or fixture is touched.
• Review correction: the stronger detector measures 40 tap-floor findings across 16 production files, not 43/17; its branch alternatives removed three old false-positive counts from calculators/search-page.tsx. Gate 8 likewise measures 19 edge conflicts across 10 files, not 25/12. The merged baseline/GATES prose still permits the older figures, so request 7ad31d10-aeef-4635-863d-d6ce9340d916 is queued to correct Fix content access gaps for anonymous and public document users #265 and preserve the ratchet-tightening follow-up without mutating the applied audit record.

---

Generated by Claude Code

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:45 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 95c8dfcd-daea-4b59-8a89-fa8f32ca9ff5

📥 Commits

Reviewing files that changed from the base of the PR and between 4c4cf42 and a47c2a4.

📒 Files selected for processing (21)

• docs/branch-review-records/bc83ff5f4c4f9421ec32cf4351708e95ce45c035738a63aaa40ea6ca6afcfa3d.record.md
• docs/branch-review-records/fec8d16693dafc5f5c400815e091e8d8565e99f53e2979f061dd3cc68c012315.record.md
• docs/outstanding-issues-inbox/7ad31d10-aeef-4635-863d-d6ce9340d916.json
• docs/outstanding-issues-inbox/applied/0948fcd2-2e51-47bc-8990-7ec002934e43.json
• docs/outstanding-issues-inbox/applied/0a052268-97e1-4d4a-9ad7-033003aa486c.json
• docs/outstanding-issues-inbox/applied/0e5573e3-425d-4253-9b28-0c1c81a4f3fe.json
• docs/outstanding-issues-inbox/applied/1376cc64-a753-41a0-9c54-30a5cca7f896.json
• docs/outstanding-issues-inbox/applied/1da43f2b-4b52-4fb7-b39a-e5aa5bf7c7e7.json
• docs/outstanding-issues-inbox/applied/24408f86-38ff-4715-affa-55d6c7bc1bb7.json
• docs/outstanding-issues-inbox/applied/3156e1c9-82aa-46c3-84e6-0e119015acc6.json
• docs/outstanding-issues-inbox/applied/397a3588-b8cf-404b-a3d4-6060b84f7d60.json
• docs/outstanding-issues-inbox/applied/568597bd-fc9f-47d6-b582-443812115e67.json
• docs/outstanding-issues-inbox/applied/5cf244c3-1b68-4214-8097-767b11a49e13.json
• docs/outstanding-issues-inbox/applied/60fea622-a448-4e8f-a5d3-0122ab08b2d0.json
• docs/outstanding-issues-inbox/applied/6e354901-7694-40e0-b03d-8c398cec7b05.json
• docs/outstanding-issues-inbox/applied/8c133c4e-23e7-427f-b1b8-6d6a64dfd381.json
• docs/outstanding-issues-inbox/applied/c3622ee1-872f-4476-8b12-20e97057c5d5.json
• docs/outstanding-issues-inbox/applied/d194f4ec-568c-4689-a411-22447c59fb53.json
• docs/outstanding-issues-inbox/applied/d656dcb5-3228-4ab8-b40c-b0377e63cb94.json
• docs/outstanding-issues-inbox/applied/fd42e1f9-4012-4296-b7c2-102c7d199738.json
• docs/outstanding-issues.md

---

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Database/docs/outstanding-issues-inbox/applied/397a3588-b8cf-404b-a3d4-6060b84f7d60.json

Lines 5 to 8 in eb64eb0

	"action": "cancel",
	"payload": {
	"requestId": "c3622ee1-872f-4476-8b12-20e97057c5d5",
	"reason": "Superseded by the corrected forensic record: its sampled migration fingerprint does not cover every migration behind the absent-index inventory."

Replace the cancelled #248 update with corrected state

Cancelling this request without a replacement leaves open row #248 at its pre-forensics state: it still instructs the operator to obtain the migration fingerprint and retain both skipped-DDL and dropped-index hypotheses, while updated row #316 in this same commit records 14 executed statements, eliminates the skipped-DDL hypothesis, and explicitly keeps #248 open. Someone selecting #248 will therefore repeat completed provider work and reason from a disproven hypothesis; apply a narrowly corrected #248 update instead of only cancelling the overbroad request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[BigSimmo]

Codex review-and-fix summary

• Final reviewed head:a47c2a4063a9eafbc7ce2f4baaa04cc3bf6f679d
• Current base:4c4cf42448350b954f015a617a233df254b06d2c
• Branch update / merge tree: latest main was merged into the PR branch; ahead/behind is 5/0 and the merge tree is clean and byte-identical to the head tree.
• Issue fixed: review found a P2 ledger-correctness defect in the applied Fix content access gaps for anonymous and public document users #265 text. Exact-current measurements are 40 tap-floor declarations across 16 files and 19 edge conflicts across 10 files, not 43/17 and 25/12. Applied requests are immutable, so the safe fix is queued as request 7ad31d10-aeef-4635-863d-d6ce9340d916 for the next serialized reconciliation; the PR body was corrected to report 1 pending / 189 applied.
• Adversarial review: CodeRabbit was rate-limited and did not provide an independent result. A distinct manual high-risk queue/manifest pass checked the canonical transaction, applied/pending request identity, current analyzer output, per-path measurements, row allocation, cancellation handling, and final diff.
• Threads: one GitHub Codex thread requested a record for the record-commit tip. It was dispositioned invalid and resolved: the immutable record correctly names the reviewed code commit 2c0ca2c5…; chasing its child record commit would create an infinite ledger-only chain or require a forbidden self-referential SHA.
• Decisive offline checks: design-system contract (measured 40 tap-floor / 19 edge conflicts); outstanding-issues guard (341 rows, 97 open / 244 archived, 1 pending / 189 applied); ledger write discipline for 4c4cf4244835..HEAD; branch-review ledger; Prettier; docs links; git diff --check.
• Exact-head required CI:CI passed; Static PR checks and aggregate PR required are green. Docs scope correctly skipped product, unit, browser, build, migration, and provider jobs.
• Exact-head advisory CI:SAST and Secret Scan passed.
• Blockers: none.
• Residual risk: canonical Fix content access gaps for anonymous and public document users #265 still contains the old measurements until the queued immutable correction is reconciled; the pending request makes that debt explicit and merge-safe.

The PR was not merged. Final merge is left to the user.