feat(guide): pin guide chrome controls to shared scroll-hide behavior - #2007
Conversation
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:14 minutes Limit details: You’ve used all 1 included review currently available under your plan. You completed 93 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
Included review availability: 0 reviews are currently available. Based on recent review activity, included reviews refill at 1 per hour. 📝 WalkthroughWalkthroughGuideDialog now uses shared scroll-driven chrome collapse. Sheet supports hidden headers and bottom content. Mobile search moves into the footer dock. Tests cover visibility, accessibility, layout padding, transitions, and restoration. ChangesGuide Centre chrome
Merge Risk:⚪ Minimal · up to The PR is merge-ready after normal checks and review; no actionable merge-blocking risk remains. The final summary should include the decisive verification output line. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
CI triageCI failed on this PR. Automated classification of the 4 failed job(s):
Compared with main CI run #11238 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Static PR checks: format tests/guide-centre.dom.test.tsx (missing trailing newline). Unit coverage (design-sync-contract, design-sync-visual-exports): regenerate .design-sync/config.json - Sheet gained headerBottom, headerHidden, and headerRef props that were never synced. Unit coverage (guide-centre.dom.test.tsx): the shared useScrollHideReporter hook schedules an rAF-deferred hide-state reset on mount. A synchronous test scroll immediately after render could race that reset and silently revert the hide state between the footer and header assertions. Flush the pending frame before the first scroll, matching the pattern this file's own afterEach already uses. Production UI (ui-smoke.spec.ts): the pre-existing (PR-untouched) guide accessibility test scrolled 80px, clearing the old footer-only hide threshold but not the shared hook's 72px + 24px activation threshold now governing both header and footer. Bumped to 140px to match the PR's own new tests, and: - the tab-order check previously started from "Close guide", which now lives inside the header and is unfocusable while it's inert - swapped to a content control, matching the PR's own new guide-centre-chrome.spec.ts. - moving the guided-tour "Continue" action out of the scrollable body and into the fixed footer means the scroll body can render with no focusable descendant on some tour steps, tripping axe's scrollable-region-focusable rule. Added an opt-in bodyTabIndex prop to Sheet (default off, so no other Sheet consumer is affected) and set it for the guide dialog's scroll body. Note for follow-up (not blocking this PR): tests/guide-centre-chrome.spec.ts, also added by this PR, isn't matched by playwright.config.ts's testMatch allowlist and therefore never runs in CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HR7cnmJRWZyg2Q9MFV1SCs
…15' into codex/guide-search-chrome-20260815
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HR7cnmJRWZyg2Q9MFV1SCs
Summary
Checks
Summary by CodeRabbit
New Features
Bug Fixes
Tests