feat(design-system): tokenize mode-nav icons, guard source segment test windows, and add ledger replay tests (#332, #341, #GT8S2K)

[BigSimmo]

Summary

This PR implements Group 3 (Design Tokens, Source Contracts & Ledger Hardening) resolving issues #332, #341, and #GT8S2K / #325:

1. Production platform: deployment architecture, nightly eval canary, capacity review #332 (Mode-Nav Icon Glyphs onto Design System --spacing-icon-md Scale):

   • In src/components/mode-nav/mode-nav.tsx and src/components/mode-nav/nav-slot-ink.tsx, replaced non-standard h-[1.0625rem] w-[1.0625rem] (17px) literal classes with standard design-token utility size-icon-md (16px).

2. rag.ts decomposition — part 1: quote verification, source block, numeric verification, context selection #341 (Unguarded Source-Slice Test Windows Migration):

   • Migrated raw .slice(..., indexOf) patterns across 10 test suites to guarded sourceSegment and sourceFrom helpers from tests/helpers/source-contract.ts, converting silent -1 slice indexing failures into explicit throws with marker context:
     • tests/css-delivery-contract.test.ts
     • tests/site-map.test.ts
     • tests/document-viewer-pdf-reader-lazy.test.ts
     • tests/mobile-chrome-paint-contract.test.ts
     • tests/mode-nav-contract.test.ts
     • tests/search-route-ownership.test.ts
     • tests/indexing-v3-agent.test.ts
     • tests/ci-cache-safety.test.ts
     • tests/global-v2-activation.test.ts
     • tests/ckb-v2-token-contract.test.ts
     • tests/design-token-contract.test.ts

3. #GT8S2K / Universal search: fix core RAG search defects and federate medications/services/forms/differentials/tools into one cross-entity search #325 (Stale / Archived Row Rejection Coverage in Ledger Inbox):

   • Added unit regression tests in tests/repo-hygiene.test.ts ensuring applyRequest in scripts/ledger-inbox.mjs throws when done or update requests target archived or nonexistent issue records.

Verification

• npx vitest run tests/css-delivery-contract.test.ts tests/site-map.test.ts tests/document-viewer-pdf-reader-lazy.test.ts tests/mobile-chrome-paint-contract.test.ts tests/mode-nav-contract.test.ts tests/search-route-ownership.test.ts tests/indexing-v3-agent.test.ts tests/ci-cache-safety.test.ts tests/global-v2-activation.test.ts tests/ckb-v2-token-contract.test.ts tests/design-token-contract.test.ts tests/repo-hygiene.test.ts
• npm run check:design-system-contract
• npm run check:outstanding-issues
• npm run check:skills
• npm run typecheck:internal
• npm run lint:internal
• npm run format
• npm run verify:ui

Risk and rollout

• Risk: low; icon scale tokenization and test source window guard improvements.
• Rollback: revert the PR commit.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:40 minutes

Limit details: You’ve used all 1 included review currently available under your plan. You completed 95 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e886f6b3-c2d3-4e7f-b7a6-37ac4ba64017

📥 Commits

Reviewing files that changed from the base of the PR and between b5d2109 and 2dcda9c.

📒 Files selected for processing (14)

• src/components/mode-nav/mode-nav.tsx
• src/components/mode-nav/nav-slot-ink.tsx
• tests/ci-cache-safety.test.ts
• tests/ckb-v2-token-contract.test.ts
• tests/css-delivery-contract.test.ts
• tests/design-token-contract.test.ts
• tests/document-viewer-pdf-reader-lazy.test.ts
• tests/global-v2-activation.test.ts
• tests/indexing-v3-agent.test.ts
• tests/mobile-chrome-paint-contract.test.ts
• tests/mode-nav-contract.test.ts
• tests/repo-hygiene.test.ts
• tests/search-route-ownership.test.ts
• tests/site-map.test.ts

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

• Lighthouse budget — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
• PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #11344 (cancelled).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.