Skip to content

Add the usual send button to the Guide Centre search bar - #2038

Merged
BigSimmo merged 14 commits into
mainfrom
claude/search-bar-behavior-2g0vnq
Aug 17, 2026
Merged

Add the usual send button to the Guide Centre search bar#2038
BigSimmo merged 14 commits into
mainfrom
claude/search-bar-behavior-2g0vnq

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • The Clinical KB Guide Centre's "Search the guide" bar already reused the shared composer's shell/input/clear-button chrome (chatComposerShellBase, chatComposerInput, chatComposerIconButton), but it had no trailing submit/send button, unlike the app's standard search composer (MasterSearchHeader) shown on mode pages like Medication.
  • Added the same circular accent send-button chrome (chatSendButton, matching .chat-send-button in globals.css) as a trailing affordance in GuideSearch (src/components/clinical-dashboard/guide-dialog.tsx).
  • Per the button-wiring convention, the button isn't decorative: submitting the form (via click or Enter) now blurs the input, confirming the already-live-filtered query and dismissing the on-screen keyboard, in addition to the existing preventDefault().
  • Deliberately did not add the composer's "+" mode-actions button or the "Patient details" pill — neither has a meaningful action inside a help/guide panel, and this repo's button-wiring rule forbids a non-functional button.
  • The Guide Centre remains a modal overlay with its own local, in-panel search (no real search submission/navigation) — it does not mount a second MasterSearchHeader/GlobalSearchShell instance, respecting this repo's "one composer per page" rule.

Verification

  • node scripts/run-vitest.mjs run --reporter=dot tests/guide-centre.dom.test.tsx tests/guide-centre-design-contract.dom.test.tsx — 2 files / 11 tests passed, including new assertions that the send button renders with chat-send-button chrome and that submitting keeps the user on the same filtered results.
  • npx tsc --noEmit — no errors in guide-dialog.tsx.
  • Verification not run: npm run verify:ui / npm run verify:phone-chrome — no composer ownership, placement, phone dock reserve, or scroll-hide logic changed; only chrome inside the existing owned search pill, so the focused DOM tests above are the appropriate proof for this scope.

Risk and rollout

  • Risk: Low — isolated to GuideSearch's markup inside the Guide Centre modal; no routing, ownership, or shared-composer instance changes.
  • Rollback: Revert this commit; no schema/data/deploy changes.
  • Provider or production effects: None.

Notes

  • Screenshots provided by the user showed the Guide Centre bar (missing the send affordance) vs. the Medication mode list's standard composer (with send button, "+" button, and a "Patient details" pill). Scope was narrowed with the user beforehand to a visual-chrome-only match, omitting the "+" button and patient pill as out of context for a help panel.

Generated by Claude Code

The Guide Centre's "Search the guide" pill already reused the shared
composer's shell/input/clear chrome but had no trailing submit
affordance, unlike the app's standard search composer. Add the same
circular send-button chrome, and give it real behaviour (confirms the
already-live-filtered query and dismisses the keyboard) rather than a
decorative no-op, per this repo's button-wiring convention.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@supabase

supabaseBot commented Aug 17, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:39 minutes

Limit details: You’ve used all 1 included review currently available under your plan. You completed 95 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d3157b1d-4c0f-4250-a4ee-5c1a5ad64439

📥 Commits

Reviewing files that changed from the base of the PR and between 9c660af and 87f4692.

📒 Files selected for processing (3)
  • docs/branch-review-records/cc198221bf69036be752da700eed8a71c9ebfd250389d79cc39d979515fa1494.record.md
  • src/components/clinical-dashboard/guide-dialog.tsx
  • tests/guide-centre.dom.test.tsx

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UI (1)needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #11488 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

@gitguardian

gitguardianBot commented Aug 17, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian idGitGuardian statusSecretCommitFilename
36221231TriggeredGeneric High Entropy Secretdf975d5tests/rag-adversarial-fixtures.test.tsView secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@BigSimmo
BigSimmo enabled auto-merge (squash) August 17, 2026 16:52
@BigSimmo
BigSimmo merged commit 2fee9b7 into mainAug 17, 2026
25 of 26 checks passed
@BigSimmo
BigSimmo deleted the claude/search-bar-behavior-2g0vnq branch August 17, 2026 18:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@claude