Add the usual send button to the Guide Centre search bar - #2038
Conversation
The Guide Centre's "Search the guide" pill already reused the shared composer's shell/input/clear chrome but had no trailing submit affordance, unlike the app's standard search composer. Add the same circular send-button chrome, and give it real behaviour (confirms the already-live-filtered query and dismisses the keyboard) rather than a decorative no-op, per this repo's button-wiring convention.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:39 minutes Limit details: You’ve used all 1 included review currently available under your plan. You completed 95 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #11488 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 36221231 | Triggered | Generic High Entropy Secret | df975d5 | tests/rag-adversarial-fixtures.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Uh oh!
There was an error while loading. Please reload this page.
Summary
chatComposerShellBase,chatComposerInput,chatComposerIconButton), but it had no trailing submit/send button, unlike the app's standard search composer (MasterSearchHeader) shown on mode pages like Medication.chatSendButton, matching.chat-send-buttoninglobals.css) as a trailing affordance inGuideSearch(src/components/clinical-dashboard/guide-dialog.tsx).preventDefault().MasterSearchHeader/GlobalSearchShellinstance, respecting this repo's "one composer per page" rule.Verification
node scripts/run-vitest.mjs run --reporter=dot tests/guide-centre.dom.test.tsx tests/guide-centre-design-contract.dom.test.tsx— 2 files / 11 tests passed, including new assertions that the send button renders withchat-send-buttonchrome and that submitting keeps the user on the same filtered results.npx tsc --noEmit— no errors inguide-dialog.tsx.npm run verify:ui/npm run verify:phone-chrome— no composer ownership, placement, phone dock reserve, or scroll-hide logic changed; only chrome inside the existing owned search pill, so the focused DOM tests above are the appropriate proof for this scope.Risk and rollout
GuideSearch's markup inside the Guide Centre modal; no routing, ownership, or shared-composer instance changes.Notes
Generated by Claude Code