Skip to content

docs(issues): stop the issues skills pointing at the retired visual register - #2125

Merged
BigSimmo merged 4 commits into
mainfrom
claude/post-reconcile-review-2026-08-18
Aug 18, 2026
Merged

docs(issues): stop the issues skills pointing at the retired visual register#2125
BigSimmo merged 4 commits into
mainfrom
claude/post-reconcile-review-2026-08-18

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • Ledger issue #338 retired the legacy ISSUES-LIST.html on 2026-08-18, making docs/outstanding-issues.md the sole canonical cross-platform register. Three instruction surfaces still told sessions to refresh the retired artifact; this removes all three.
    • .claude/skills/issues/SKILL.md carried a whole "Refresh the visual register" section built around an absolute-Windows-path PowerShell command, plus an issues list trigger that opened the retired HTML. Replaced with a short "the canonical ledger is the register" statement that names #338, so the retirement is not silently re-litigated by the next session.
    • AGENTS.md described reconciliation as refreshing the visual register.
    • .agents/skills/ledger/SKILL.md referenced it in step 6.
  • Queue one follow-up request (a5f073f9): the serialized issues:reconcile operation has no interlock, and two reconcile PRs were open simultaneously on 2026-08-18.

Why this is worth a PR rather than a comment. The stale instructions have a real, observed cost. A container session that follows them cannot run the Windows script, so it dutifully reports a "stale visual register" that no longer exists as a concept — which is exactly what happened during the 2026-08-18 evening reconciliation (PR #2120). The instruction was self-consistent and impossible to satisfy, so it produced a false caveat on an otherwise-correct handoff.

On the queued follow-up. PRs #2119 and #2120 were both open, both running the operation AGENTS.md requires to be serialized on one fresh-base branch. Both merged, and the ledger is correct — but only by luck of ordering: #2120 merged first with a superset of #2119's requests, so #2119's squash collapsed to a 1-line review record. Had they merged the other way round, #2120's recorded transaction would no longer have equalled the canonical diff, check:ledger-write-discipline would have gone red on a branch that must never be synced from main, and the documented recovery is to close the PR and redo the whole reconcile. The reconciler's own guards (stale base, dirty canonical file, cross-worktree lock) are all machine-local and cannot see a second reconcile branch already pushed. The request proposes a cheap pre-flight interlock over git ls-remote that needs no GitHub API call. Related to #292 but distinct: this is a serialization invariant on a single canonical file, not two sessions building the same feature.

Verification

  • npm run verify:pr-local -- --files <4 changed paths>AGENTS.md pulls in the workflow/policy contract set, so the selector chose 22 gates rather than the docs-only 11. All completed, none failed, none unreached:

    PR-local verification summary:
    - completed: check:runtime, check:installed-lock-parity, format:changed, sitemap:check,
    docs:check-index, docs:check-inventory, docs:check-scripts, docs:check-links,
    check:branch-review-ledger, check:outstanding-issues, check:ledger-write-discipline,
    check:github-actions, check:ci-scope, check:gitleaks-pinned, check:ci-triage,
    check:pr-policy, check:gate-manifest, check:skills, check:pr-mergeability,
    check:verification-plan, test:ci-workflows, check:codex-autofix-workflow
    - failed: (none)
    - not reached: (none)
    

    test:ci-workflows: Test Files 15 passed (15) · Tests 325 passed (325).

  • check:skills caught a real regression mid-change, and the fix is in this diff. The canonical .agents/skills/ledger/SKILL.md entry is word-budgeted at 220 words. The first replacement wording was longer than the line it replaced and pushed the file over, taking the gate from exit 0 to exit 1 (- Canonical skill exceeds 220 words: ledger); baseline was re-measured on a stash to confirm the failure was mine and not pre-existing. The canonical entry now reads Canonical Markdown changes only at reconciliation. — shorter than the original line — and the #338 rationale lives in the Claude skill, which has no such budget.

  • npm run format run over the whole tree and committed; format:changed passed on the pushed blob.

  • Lint, typecheck, the full unit suite, the RAG fixture scan, the build and the offline RAG checks were skipped by the selector as out of scope for a docs/instruction diff.

  • UI verification not run: no UI, routing, styling, browser, reduced-motion or forced-colors behaviour changed.

  • Provider-backed gates not run: no retrieval, ranking, ingestion, Supabase or deployment behaviour changed.

Risk and rollout

  • Risk: Low. Instruction text and one queued inbox request; no product code, schema, workflow or runtime configuration. The behavioural effect is on how future sessions act, and it removes a step that cannot succeed rather than adding one.
  • Rollback: git revert of the single commit restores all three instruction files and drops the queued request, which is inert until a reconciliation runs.
  • Provider or production effects: None.

Notes

  • Branch is behind main by the #2117 merge but git merge-tree --write-tree origin/main HEAD is clean, so it has deliberately not been synced — per the anti-churn rule, a behind-but-clean head does not need a merge.
  • The inbox is no longer empty. The 2026-08-18 evening reconciliation drained it to 0 pending, then #2117 queued 5 requests and this PR queues a 6th. They are six distinct UUID files that merge cleanly by design; a future serialized fresh-base branch should run npm run issues:reconcile once these have landed.
  • PR docs(issues): reconcile 74 queued requests into the outstanding-issues ledger #2119's merged title on main reads "reconcile 74 queued requests into the outstanding-issues ledger", but its squashed content is a single review record — the reconciliation itself landed in ed19e143 (docs(issues): reconcile queued ledger requests (remediation Phases 2–3, #2105 resolutions) #2120). Recorded here so the history is not misread later; no fix proposed, since rewriting a merged commit message is not worth the churn.

Generated by Claude Code

…egister
Ledger issue #338 retired the legacy ISSUES-LIST.html on 2026-08-18, making
docs/outstanding-issues.md the sole canonical cross-platform register. Three
instruction surfaces still told sessions to refresh the retired artifact:
- .claude/skills/issues/SKILL.md carried a whole "Refresh the visual register"
section with an absolute-Windows-path PowerShell command, plus an `issues
list` trigger that opened the retired HTML.
- AGENTS.md described reconciliation as refreshing the visual register.
- .agents/skills/ledger/SKILL.md referenced it in its step 6.
The stale instructions have a real cost: a container session that follows them
cannot run the Windows script, so it dutifully reports a "stale visual
register" that no longer exists as a concept. That happened during the
2026-08-18 evening reconciliation (PR #2120).
Replace the section with a short statement that the canonical ledger is the
register, naming #338 so the retirement is not silently re-litigated. The
canonical .agents entry is word-budgeted, so its line is shortened rather than
extended — check:skills enforces a 220-word ceiling and went red on a longer
replacement.
Also queue one follow-up: the serialized issues:reconcile operation has no
interlock, and two reconcile PRs (#2119, #2120) were open simultaneously.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C6WXAK931ZPgisknbCTnpR
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@supabase

supabaseBot commented Aug 18, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:24 minutes

Limit details: You’ve used all 1 included review currently available under your plan. You completed 101 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 25f9c36b-a6de-4bfd-94ec-887b54e36b03

📥 Commits

Reviewing files that changed from the base of the PR and between 53438ae and 155ac92.

📒 Files selected for processing (6)
  • .agents/skills/ledger/SKILL.md
  • .claude/skills/issues/SKILL.md
  • AGENTS.md
  • docs/branch-review-records/919dacc65e8ee47d9ce4c41758e474d87071283c5c52543e48b01b71fb1c7be6.record.md
  • docs/branch-review-records/e2220e1f5f8658b740f3154b9d6732135c8663968e76f3b6d90c02261583ca72.record.md
  • docs/outstanding-issues-inbox/a5f073f9-c82a-4d42-86af-0a36159a9403.json

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo merged commit 5d5ff89 into mainAug 18, 2026
24 checks passed
@BigSimmo
BigSimmo deleted the claude/post-reconcile-review-2026-08-18 branch August 18, 2026 14:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@claude