- Notifications
You must be signed in to change notification settings - Fork 0
docs: record that PR #2122 landed, and queue the ensure/verify:pr-local build-refusal conflict#2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+14
−0
Merged
docs: record that PR #2122 landed, and queue the ensure/verify:pr-local build-refusal conflict #2131
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
55c1e12
docs(ledger): record that PR #2122 landed correctly as squash 092633eb
claude c35ba04
docs(issues): queue the ensure/verify:pr-local build-refusal conflict
claude b95ed41
Merge branch 'main' into claude/therapy-compass-convergence-2iufoh
BigSimmo bdd63d5
Merge branch 'main' into claude/therapy-compass-convergence-2iufoh
BigSimmo edb7dce
Merge branch 'main' into claude/therapy-compass-convergence-2iufoh
BigSimmo acc2dd4
Merge branch 'main' into claude/therapy-compass-convergence-2iufoh
BigSimmo 7010ba4
Merge branch 'main' into claude/therapy-compass-convergence-2iufoh
BigSimmo 847ff29
Merge branch 'main' into claude/therapy-compass-convergence-2iufoh
BigSimmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1 ...ords/af4de581bea0990cd58f3886b76d98f595e149247e894caaa3f51c69d680dcf7.record.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| | 2026-08-18 | claude/therapy-mode-consistency-a466b0 | 092633eb7479b21796790a33b0ff7a3a7d4cf05c | prlanded | Landed correctly. PR #2122 squash-merged as 092633eb; verified by content, not ancestry: two-dot 'git diff --stat 092633eb 7733eb8c' is empty, so nothing was orphaned by the auto-merge race. The pre-merge sync of main into the branch was also proven clean — its tree hash equalled git merge-tree's automatic result exactly, so no hand resolution could have silently reverted content (the failure mode #324 describes). Branch reports 13 ahead of main, which is the squash artifact, not unlanded work. Remote head deleted by GitHub on merge; four inbox requests ride on main awaiting issues:reconcile. | git diff --stat <squash> <tip> empty; merge-tree hash equality on the pre-merge sync; post-merge verify:cheap green — Test Files 673 passed (673), Tests 7275 passed \| 4 skipped (7279), Design-system contract passed (784 production files), hosted migration-role guard passed | | ||
13 changes: 13 additions & 0 deletions
13 docs/outstanding-issues-inbox/9226626e-ad01-4504-a8bb-1287fa281f7b.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "9226626e-ad01-4504-a8bb-1287fa281f7b", | ||
| "createdOn": "2026-08-18", | ||
| "action": "add", | ||
| "payload": { | ||
| "pri": "P3", | ||
| "type": "issue", | ||
| "summary": "Two documented workflow steps conflict: npm run ensure guarantees verify:pr-local fails its build stage with BUILD_REFUSED_DEV_SERVER", | ||
| "detail": "Reproduced 2026-08-18 on branch claude/therapy-mode-consistency-a466b0. AGENTS.md requires npm run ensure before any browser/UI work, and docs/testing.md requires npm run verify:pr-local at PR handoff. Doing both in one session always fails, because the production build refuses to run while the project dev server holds its port: verify:pr-local exits with 'failed: build (exit 76)' and the note 'production build was refused while the Clinical KB dev server is running (BUILD_REFUSED_DEV_SERVER). This is a failed gate, not a skip.' The refusal itself is correct and should stay - a build sharing a port with a dev server is not trustworthy - but nothing in either doc warns that the two required steps are ordered, so the gate reads as a real failure. Workaround used: stop the dev server, rm -rf .next, re-run npm run build standalone (exit 0), then check:bundle-budget against the fresh output. Options: have verify-pr-local.mjs name the remedy in its own failure note, or document the ordering in the testing speed playbook. Stop rule: do not make the build stage soft-skip when a dev server is up; the existing fail-closed behaviour is the correct half of this.", | ||
| "issueUlid": "01M0ANYV88G4M3DV1JNG2DKHPR" | ||
| } | ||
| } |
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.