Skip to content

Claude/settings development section - #2141

Closed
BigSimmo wants to merge 2 commits into
mainfrom
claude/settings-development-section
Closed

Claude/settings development section#2141
BigSimmo wants to merge 2 commits into
mainfrom
claude/settings-development-section

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm run verify:pr-local

During development, use npm run verify:cheap as the faster iteration gate before the final PR-local preflight.

  • npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
  • npm run verify:release before release or handoff confidence claims

For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, verify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.

  • npm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.
  • npm run eval:rag -- --limit 15 + npm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)
  • npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
  • npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed

Risk and rollout

Complete this section for clinical, data, API, auth/privacy, workflow, dependency, build, or deployment changes.

  • Risk:
  • Rollback:
  • Provider or production effects: None / describe the explicitly authorized effect

Clinical Governance Preflight

Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

BigSimmoand others added 2 commits August 18, 2026 18:05
… Contact prototype
Settings gains a Development section at the bottom of the rail, holding the
in-progress surfaces while they are being built. Its first entry opens the
Caring Contact linked prototype.
- Gated on the same two conditions as `mockupsEnabled()` in src/lib/env.ts, read
from bundler-inlined values rather than by importing that module: no client
component imports the server env contract, and tests/client-secret-surface.test.ts
holds that boundary. In a production deploy that has not opted in, the section
does not render — which is exactly when /mockups/* would 404.
- The desktop rail is filtered from the same predicate, so it cannot advertise a
section the body does not render. The scroll-spy already reads section ids from
the DOM, so a hidden section cannot desync it.
- Navigation uses <Link> per docs/wiring-conventions.md and closes the sheet behind
it. The card states plainly that the prototype is synthetic-only.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Settings → Development now opens a real page rather than linking straight into a
prototype, so there is one place that lists what is being built.
- `/mockups/development` indexes the in-progress surfaces. Each carries a summary,
a primary button into it, and direct links to its key routes — for Caring Contact:
Today, Patients, Schedule, Templates and System states.
- It lives under `/mockups` on purpose: the namespace layout already applies
`mockupsEnabled()`, so the page inherits the production gate and 404s in a
production deploy exactly like the surfaces it links to, rather than needing a
second gate of its own.
- The page states plainly that everything on these surfaces is synthetic and that
none of it is validated clinical decision support.
- The Settings card now points at the page and is renamed accordingly.
Verified on the running app: `/mockups/development` and `/mockups/caring-contacts`
both return 200, the page renders its five outbound prototype links, and the
settings entry resolves to `/mockups/development`.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@supabase

supabaseBot commented Aug 18, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in:30 minutes

Limit details: You’ve used all 1 included review currently available under your plan. You completed 101 included PR reviews in the past 7 days; at that activity level, included reviews refill at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 23f0dd53-1c0d-4021-86a1-153f015424f2

📥 Commits

Reviewing files that changed from the base of the PR and between bc73e73 and 2e73256.

📒 Files selected for processing (4)
  • docs/site-map.md
  • src/app/mockups/development/page.tsx
  • src/components/clinical-dashboard/settings-dialog.tsx
  • tests/settings-dialog-actions.dom.test.tsx

Comment @coderabbitai help to get the list of available commands.

@BigSimmoClaude

Copy link
Copy Markdown
OwnerAuthor

Closing as fully superseded. Verified against current main: src/app/mockups/development/page.tsx, the Development section in settings-dialog.tsx, docs/site-map.md, and tests/settings-dialog-actions.dom.test.tsx are all byte-identical to this branch already (landed via #2109 and #2135). The only remaining difference is that this stale branch still carries the deprecated --shadow-soft token in settings-dialog.tsx, which main has since migrated to --e2 — so there's nothing left to merge, only something this branch would revert.


Generated by Claude Code

auto-merge was automatically disabled August 18, 2026 18:13

Pull request was closed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo