Close out PR #2143: prlanded record and two captured follow-ups - #2162
Conversation
Bookkeeping for the merged Dictionary browse header work, bundled into one PR because all three files are append-only immutable records. - prlanded review record for squash commit 333399f. The content diff between that commit and the branch tip was empty, so nothing was orphaned by the merge. - Captures that repeated main-merges on open PR branches cancel required CI. PR #2143 read red on five heads and was merged past it, but the job logs for the first and last runs both report "CANCELLED with no failing job" with zero failures — the browser gates actually passed on the first head. #95 correctly keeps a cancelled required job red, so the defect is whatever keeps minting heads, not the aggregate. - Captures that phone screenshots and DOM reads taken before the fixed phone chrome stack settles misreport every offset below it, which sent this session's header work down a wrong diagnosis and a reverted fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011jr2rJuYT4sdi2yDGBTkyd
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:37 minutes Limit details: You’ve used the included review currently available. Your 102 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Bookkeeping for the merged Dictionary browse header work (PR #2143), bundled into one PR because all three files are append-only immutable records with no shared state.
prlandedreview record for squash commit333399f7f5ebfb83c304bf7a0bbdbd71b6849238. Verified per.claude/skills/prlanded:git diff --stat 333399f 6bd0934(two-dot, against the squash commit) came back empty, and the browse header,dictionaryBrowseLetter, the new test and both mockup studies were each confirmed present onorigin/main. Nothing was orphaned by the merge.main-merges on open PR branches cancel required CI. PR Add Dictionary Browse header redesign study with three directions #2143 read red on five consecutive heads and was merged past it, but the job logs tell a different story from the check name: runs32170524256(first) and32178668323(last) both reportCANCELLED with no failing jobwith zero failures. On the first headUI_FAST_RESULTandUI_RESULTweresuccess— the browser gates passed on that diff — and onlylighthouse-budgetwas cancelled.#095deliberately keeps a cancelled required job red, which is correct, so the defect is whatever kept minting heads (origin/mainwas merged into that branch roughly every five minutes during one session), not the aggregate. Related to#CCZ4HB, which records the same churn exhausting the review-bot budget..phone-sticky-header-stackisposition: fixedand mounts collapsed, so a screenshot orevaluate()atnetworkidlecan readmainaty=72overlapped by the mode-nav rail when the settled layout has it aty=121with no overlap. Measured on/dictionary/browse: unsettledh1aty=88, settled aty=161, and the page both before and after the redesign settled to the samey=161. This cost a wrong diagnosis and a reverted "fix" during PR Add Dictionary Browse header redesign study with three directions #2143.No code, route, or behaviour changes.
Verification
npm run verify:pr-localThe risk router classified this as recognised low-risk documentation scope and ran the focused contract set —
check:runtime, check:installed-lock-parity, format:changed, sitemap:check, docs:check-index, docs:check-inventory, docs:check-scripts, docs:check-links, check:branch-review-ledger, check:outstanding-issues, check:ledger-write-discipline— withfailed: (none). Lint, typecheck, the unit suite, RAG fixture scan and build were skipped by the router as out of scope for append-only record files;build skipped: no build-affecting changes detected.check:ledger-write-disciplineinitially refused to report a verdict because the two inbox requests were untracked — that gate compares two committed refs, so it fails closed rather than passing meaninglessly. Committing first and re-running cleared it.UI verification not run: no UI, routing, styling, or browser behaviour changed.
Risk and rollout
docs/branch-review-records/anddocs/outstanding-issues-inbox/; the canonicaldocs/outstanding-issues.mdis untouched, as the inbox contract requires.Notes
npm run issues:reconcile, per the inbox contract — this PR deliberately does not editdocs/outstanding-issues.md.origin/mainafter PR Add Dictionary Browse header redesign study with three directions #2143 merged, per the merged-PR rule inAGENTS.md; this is a new PR, not a reuse of the merged one.Generated by Claude Code