Skip to content

feat(hardening): safe workflow guards, worktree pruning, and motion contracts bundle#2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 15 commits into from
Aug 19, 2026
Merged

feat(hardening): safe workflow guards, worktree pruning, and motion contracts bundle #2183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
95ec89c
feat(hardening): implement safe tooling, ui layout, and workflow guar…
BigSimmo Aug 19, 2026
98601bf
style: format changed files with Prettier and clean up unused imports
BigSimmo Aug 19, 2026
e659782
feat(hardening): safe workflow guards, worktree pruning, and motion c…
BigSimmo Aug 19, 2026
c430e8d
Merge remote-tracking branch 'origin/main' into gemini/safe-tooling-u…
BigSimmo Aug 19, 2026
5ad1f0d
fix(tooling): cross-platform drive regex and test cleanup bounded ret…
BigSimmo Aug 19, 2026
9e7cc31
Merge branch 'main' into gemini/safe-workflow-guards-and-motion-contr…
BigSimmo Aug 19, 2026
a8646e5
Merge remote-tracking branch 'origin/main' into gemini/safe-workflow-…
BigSimmo Aug 19, 2026
7c77cdc
Merge branch 'main' into gemini/safe-workflow-guards-and-motion-contr…
BigSimmo Aug 19, 2026
c4c12d0
fix(lint): resolve eslint errors and warnings blocking Static PR checks
BigSimmo Aug 19, 2026
6656ca5
docs: bump scripts-index count to 249 after adding audit-source-gover…
BigSimmo Aug 19, 2026
9e374a3
fix(ui): align loading skeleton min-height with real content on mobil…
BigSimmo Aug 19, 2026
aa0e5bc
Merge branch 'main' into gemini/safe-workflow-guards-and-motion-contr…
BigSimmo Aug 19, 2026
976dfee
Merge branch 'gemini/safe-workflow-guards-and-motion-contracts' of ht…
BigSimmo Aug 19, 2026
f5eb85c
fix(review): resolve PR #2183 review feedback
BigSimmo Aug 19, 2026
688c42c
Merge remote-tracking branch 'origin/main' into gemini/safe-workflow-…
BigSimmo Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/clinical-dashboard/favourites-command-library-page.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -269,6 +269,7 @@ function filterAndSortItems(
const effectiveSort: SortMode = viewMode === "recent" ? "last-used" : sortMode;

return items
.filter((item) => viewMode !== "recent" || lastUsedScore(item.lastUsed) > 1000)
.filter((item) => selectedTypeIds.size === 0 || selectedTypeIds.has(item.tabId))
.filter((item) => selectedSetTitles.size === 0 || selectedSetTitles.has(item.set))
.filter((item) => !pinnedOnly || item.pinned === true)
Expand Down
2 changes: 1 addition & 1 deletion src/components/clinical-dashboard/global-search-shell.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,7 +160,7 @@ export function GlobalSearchShell(props: GlobalSearchShellProps) {
// fallback and resolved content briefly coexisted. A route-agnostic mode-home
// skeleton (the same one `loading.tsx` shows during navigation) reserves the
// layout so the first frame reads as "loading" instead of a blank background.
<div className="min-h-dvh bg-[color:var(--background)] text-[color:var(--text)]">
<div className="min-h-0 bg-[color:var(--background)] text-[color:var(--text)] sm:min-h-dvh">
<ModeHomeRouteLoading />
</div>
)
Expand Down
2 changes: 1 addition & 1 deletion src/components/mode-home-page-skeleton.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,7 @@ export function ModeHomeRouteLoading() {
return (
// Match ModeHomeMain startOnPhone: top-align on phones, centre from sm up.
// A phone-centred skeleton jumped when content-rich homes mounted top-aligned.
<div className="grid min-h-[calc(100dvh-var(--shell-header-h))] items-start justify-items-center bg-[color:var(--background)] pt-3 sm:items-center sm:pt-0">
<div className="grid min-h-0 items-start justify-items-center bg-[color:var(--background)] pt-3 sm:min-h-[calc(100dvh-var(--shell-header-h))] sm:items-center sm:pt-0">
<ModeHomePageSkeleton />
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion tests/helpers/phone-scroll.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ export function forceCompiledStandalonePhoneCss(page: Page): Promise<number> {
}
const style = document.createElement("style");
style.dataset.testid = "forced-standalone-phone-css";
style.textContent = `@layer components { ${standaloneRules.join("\n")} }`;
style.textContent = standaloneRules.join("\n");
document.head.append(style);
window.dispatchEvent(new Event("resize"));
return standaloneRules.length;
Expand Down
10 changes: 10 additions & 0 deletions tests/ui-phone-scroll-routes.spec.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -170,3 +170,13 @@ test("phone forms search hides header and footer after submit without stale focu
);
expect(Number.parseFloat(afterHide.reservePb) || 0, "hidden reserve releases the bottom rail").toBeLessThanOrEqual(1);
});

test("phone route flips under reducedMotion: 'reduce' preserve layout and scroll owner", async ({ page }) => {
await page.emulateMedia({ reducedMotion: "reduce" });
await page.setViewportSize(phoneViewport);
await gotoPhoneSurface(page, "/calculators");
await addPhoneScrollRunway(page);
const initial = await readGeometry(page);
expect(initial.scrollOwner, "browser route uses document scrolling").toBe("document");
expect(initial.headerHidden, "header visible at top").toBe(false);
});
Loading