Skip to content

docs: correct Gate E PR state and backfill missing review records - #2248

Merged
BigSimmo merged 1 commit into
mainfrom
claude/database-docs-corrections-zyr7wh
Aug 21, 2026
Merged

docs: correct Gate E PR state and backfill missing review records#2248
BigSimmo merged 1 commit into
mainfrom
claude/database-docs-corrections-zyr7wh

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm run verify:pr-local — run scoped to the changed files (-- --files docs/rag-improvement/HANDOVER.md,docs/branch-review-records/d021712c...record.md,docs/branch-review-records/f97d90d5...record.md); classified as recognised low-risk docs scope, so lint/typecheck/full unit suite were skipped by design. Result:
    PR-local verification summary:
    - completed: check:runtime, check:installed-lock-parity, format:changed, sitemap:check, docs:check-index, docs:check-inventory, docs:check-scripts, docs:check-links, check:branch-review-ledger, check:outstanding-issues, check:ledger-write-discipline
    - failed: (none)
    - not reached: (none)
    Skipping build: no build-affecting source, config, package, or container changes detected.
    
  • npm run check:branch-review-ledgerBranch review ledger guard passed: 880 live table records + 1206 archived + 438 immutable (880 under the 2026-07-29 machine-readable contract), immutable review writes, six cells each, no conflict markers, mojibake, heading records, or duplicates.
  • npm run check:ledger-write-disciplineLedger write discipline passed for 65393e4402ac..HEAD.
  • npm run verify:ui — not run: no UI, routing, or styling changed.
  • npm run verify:release, eval/production-readiness gates — not run: docs-only change, no retrieval/answer/clinical/deployment behaviour touched, and these are provider-backed.

Risk and rollout

  • Risk: Low. Documentation and immutable review-record additions only; no src/, worker/, or supabase/ paths touched.
  • Rollback: git revert the single commit.
  • Provider or production effects: None.
  • RAG impact: no retrieval behaviour change — documentation correction only.

Clinical Governance Preflight

Not applicable: this diff touches only docs/rag-improvement/HANDOVER.md and docs/branch-review-records/**. No ingestion, answer-generation, search/ranking, source-rendering, document-access, privacy, production-env, or clinical-output behaviour changed.

Notes

  • Still owed: an uncommitted prlanded review-record file (docs/branch-review-records/0265c1cb….record.md) was left in the separate main checkout at D:/Repos/Database. This session did not touch that checkout (other sessions have work in progress there); flagging it here so it isn't lost. It should be committed and pushed from that checkout in a follow-up.
  • Scope note: docs/outstanding-issues.md was not edited and issues:reconcile was not run, per this task's authorization boundary.

Generated by Claude Code

- HANDOVER.md §2 Gate E row cited "(this PR)" for its PR cell; the
tooling actually merged as PR #2208 (squash 588191c). Set PR to
#2208 and state to merged with that squash, verified from git log.
- PRs #2218 and #2228 merged without a branch-review-records entry.
Added both via ledger:append, backfilled from the merged diffs and
each PR's own stated verification.
RAG impact: no retrieval behaviour change — documentation correction only.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TCueqEdTotPef4zdJ4oZDn
@coderabbitai

coderabbitaiBot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in:8 minutes

Limit details: You’ve used the included review currently available. Your 86 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d20237bc-1861-47bf-b116-1c6947751de7

📥 Commits

Reviewing files that changed from the base of the PR and between 65393e4 and bd53aea.

📒 Files selected for processing (3)
  • docs/branch-review-records/d021712c69d85d2e42499fadabae91ada5396e3de2eb4652d748b09fae84ba8c.record.md
  • docs/branch-review-records/f97d90d561a026c4d126c174fc5ab7882423a4f351a6158170f0ad2fa240c3c3.record.md
  • docs/rag-improvement/HANDOVER.md

Comment @coderabbitai help to get the list of available commands.

@supabase

supabaseBot commented Aug 21, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo marked this pull request as ready for review August 21, 2026 18:01
@BigSimmo
BigSimmo enabled auto-merge (squash) August 21, 2026 18:03
@BigSimmo
BigSimmo merged commit 70a0507 into mainAug 21, 2026
29 of 44 checks passed
@BigSimmo
BigSimmo deleted the claude/database-docs-corrections-zyr7wh branch August 21, 2026 18:04

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:bd53aea9bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1 @@
| 2026-08-21 | claude/issues-reconcile-post-2206 | 02d1bcaab01f933b8af3eefa3a7f085e95aac661 | docs(issues): reconcile the queued inbox batch into the canonical ledger (#2218) | Backfilled record — PR #2218 merged 2026-08-21 (squash 02d1bcaab01f933b8af3eefa3a7f085e95aac661) with no review record captured at the time. Diff inspected post hoc: 29 immutable inbox requests applied verbatim into docs/outstanding-issues.md plus 2 closures (#VZN8G3 dup of #BSBE9B, #Q5JHBJ archived) verified against the ledger by the PR author; docs-only, classifyPullRequestFiles clinicalRisk:false, no RAG/src/worker/supabase paths touched. Approved by content. | PR-reported: reconciler applied 29/29 requests cleanly; pre-push guard ran check:ledger-write-discipline on pushed commit 42dc0e0f4 with no rejection; Prettier clean on changed markdown; CI static-pr required checks green (merged). Not independently re-run in this session — docs-truth backfill only. |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Record the PR head instead of the squash commit

When ledger:lookup is run for either feature branch, it resolves the branch's pre-merge PR head and requires both the ref and HEAD to match; these two backfills instead pair the branch refs with merge squash SHAs (02d1bca… and 1fe3c60…). Reproducing the documented lookup therefore returns NOT REVIEWED and reports the record only as belonging to a different HEAD, defeating review throttling. Append superseding records using each PR's actual reviewed head SHA rather than its squash commit.

AGENTS.md reference: AGENTS.md:L147-L147

Useful? React with 👍 / 👎.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@claude