docs(ledger): supersede the Phase 5 review record with the verbatim gate output - #2258
Conversation
…ate output CodeRabbit (PR #2250, comment 3833079990) correctly flagged that the original record summarised `verify:pr-local` as "(11/11, failed: none)", which paraphrases the gate rather than pasting its decisive line — the one thing AGENTS.md says is never compressed. Review records are immutable and content-addressed, so this appends a superseding record rather than editing the original, per the review-ledger contract. No finding changed; the outcome is still self-review with no blocking findings. The remaining four findings from that review needed no action here: the fenced-block languages, the D4 "separate db push" line, the Perth/UTC dating convention, and the qualification of the "never reset" statistics claim are all already correct on main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:36 minutes Limit details: You’ve used the included review currently available. Your 89 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
Summary
Follow-up to #2250, addressing the one CodeRabbit finding from that review that was still outstanding after the merge.
verify:pr-localas(11/11, failed: none)— a paraphrase, where AGENTS.md requires the decisive line be pasted. The superseding record now carries the actual- completed: …/- failed: (none)/- not reached: (none)lines, plus the verbatimREADY: no blocking production-readiness failures.and the three decisivelive-driftlines from run32514326022.The other four findings from that review needed no change here — each was verified against
mainand is already correct:maintextdb push"live-drift2026-08-22 Perth = 2026-08-21 UTCpg_stat_reset_single_table_counters(oid)as an invisible per-relation reset, and calls the conclusion strongly supported rather than provenThat last one was a genuinely sharp catch and is worth keeping visible: production runs PostgreSQL 17.6, and
pg_stat_all_indexes.stats_reset— which would settle it per index — only exists from PostgreSQL 18, so the question cannot be closed on this database today.Verification
Ledger-record-only change, so the two gates that actually cover it were run directly rather than the full PR-local sweep (which is currently timing out on cross-worktree lock contention, not on this diff).
npm run check:branch-review-ledgernpm run check:ledger-write-disciplinenpx prettier --checkon the new recordVerification not run — lint, typecheck, unit suite, build, browser, and every eval: no executable scope. This diff adds one Markdown review record and changes nothing else.
Risk and rollout
git revertremoves the record. The superseded original stays valid on its own terms, so nothing depends on this landing.Notes
3833079990. The remaining four threads on that PR were replied to and resolved as already-addressed rather than carried here.