Skip to content

docs(ledger): supersede the Phase 5 review record with the verbatim gate output - #2258

Merged
BigSimmo merged 2 commits into
mainfrom
claude/phase5-review-followup
Aug 21, 2026
Merged

docs(ledger): supersede the Phase 5 review record with the verbatim gate output#2258
BigSimmo merged 2 commits into
mainfrom
claude/phase5-review-followup

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

Follow-up to #2250, addressing the one CodeRabbit finding from that review that was still outstanding after the merge.

  • Supersedes the Phase 5 review record with the gate's verbatim output. The original record summarised verify:pr-local as (11/11, failed: none) — a paraphrase, where AGENTS.md requires the decisive line be pasted. The superseding record now carries the actual - completed: … / - failed: (none) / - not reached: (none) lines, plus the verbatim READY: no blocking production-readiness failures. and the three decisive live-drift lines from run 32514326022.
  • Appended, not edited. Review records are immutable and content-addressed, so the review-ledger contract requires a superseding record rather than a rewrite. No finding changed: the outcome is still self-review, no blocking findings.

The other four findings from that review needed no change here — each was verified against main and is already correct:

FindingState on main
MD040 — fenced blocks need a languageFixed: all four blocks carry text
D4 — "every future migration needs its own db push"Fixed: the requirement is gone, replaced by approved-window + green live-drift
Perth vs UTC dating across the close-out recordsFixed: the section states the convention explicitly and the table header reads 2026-08-22 Perth = 2026-08-21 UTC
"counters have never been reset" overstatedFixed: the text now says the NULL proves only that no database-wide reset was recorded, names pg_stat_reset_single_table_counters(oid) as an invisible per-relation reset, and calls the conclusion strongly supported rather than proven

That last one was a genuinely sharp catch and is worth keeping visible: production runs PostgreSQL 17.6, and pg_stat_all_indexes.stats_reset — which would settle it per index — only exists from PostgreSQL 18, so the question cannot be closed on this database today.

Verification

Ledger-record-only change, so the two gates that actually cover it were run directly rather than the full PR-local sweep (which is currently timing out on cross-worktree lock contention, not on this diff).

  • npm run check:branch-review-ledger
Branch review ledger guard passed: 880 live table records + 1206 archived + 443 immutable
(880 under the 2026-07-29 machine-readable contract), immutable review writes, six cells each,
no conflict markers, mojibake, heading records, or duplicates.
  • npm run check:ledger-write-discipline
Ledger write discipline passed for a82625a6c013..HEAD.
  • npx prettier --check on the new record
All matched files use Prettier code style!

Verification not run — lint, typecheck, unit suite, build, browser, and every eval: no executable scope. This diff adds one Markdown review record and changes nothing else.

Risk and rollout

  • Risk: Negligible. One new immutable Markdown record; no product code, no schema, no configuration, no RAG surface.
  • Rollback:git revert removes the record. The superseded original stays valid on its own terms, so nothing depends on this landing.
  • Provider or production effects: None. No hosted call was made for this change.
  • RAG impact: no retrieval behaviour change — a documentation review record only; no ranking, selection, or ordering surface touched

Notes

…ate output
CodeRabbit (PR #2250, comment 3833079990) correctly flagged that the original
record summarised `verify:pr-local` as "(11/11, failed: none)", which
paraphrases the gate rather than pasting its decisive line — the one thing
AGENTS.md says is never compressed.
Review records are immutable and content-addressed, so this appends a
superseding record rather than editing the original, per the review-ledger
contract. No finding changed; the outcome is still self-review with no
blocking findings.
The remaining four findings from that review needed no action here: the
fenced-block languages, the D4 "separate db push" line, the Perth/UTC dating
convention, and the qualification of the "never reset" statistics claim are
all already correct on main.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@supabase

supabaseBot commented Aug 21, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitaiBot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in:36 minutes

Limit details: You’ve used the included review currently available. Your 89 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a4b854d6-53ef-4d70-91bf-4de4ebc55c12

📥 Commits

Reviewing files that changed from the base of the PR and between 226bd32 and b5c6786.

📒 Files selected for processing (1)
  • docs/branch-review-records/4dd785f6a227e847467c76e68e4c08df2fc9394343295e0985c70bd306ab2861.record.md

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo enabled auto-merge (squash) August 21, 2026 20:42
@BigSimmo
BigSimmo merged commit 63ee8d1 into mainAug 21, 2026
24 checks passed
@BigSimmo
BigSimmo deleted the claude/phase5-review-followup branch August 21, 2026 20:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@BigSimmo