docs(issues): record four session findings and close the Dev Drive fleet inventory - #2284
docs(issues): record four session findings and close the Dev Drive fleet inventory#2284BigSimmo wants to merge 8 commits into
Conversation
… close the Dev Drive inventory Four immutable inbox requests plus one update, all queued for a later reconcile; no canonical ledger edit here. - verify:phone-chrome can exit 0 having run no browser tests at all when its changed-file selector resolves to nothing phone-chrome-affecting. Caught while running the A2 gates: the bare invocation reported success having executed only two docs checks. - tests/gate-receipts.test.ts carries two chmod-based assertions that cannot pass on the Windows ReFS Dev Drive, so every local npm run test is permanently two-red and verify:pr-local stops before build. - The Claude push-format-guard hook blocks all pushes from linked worktrees, because it compares core.hooksPath against the worktree root rather than the common git dir, then fails on a git-ignored file. - Seven registered worktree directories are empty while remaining the cwd of seven live sessions. #6GW95D is updated with the completed fleet inventory: 208 checkouts, 92 registered worktrees and 116 separate clones across eight roots, 9.30 GB of landed candidates. Cleanup is deferred indefinitely by owner decision after a removal pass was halted and fully reverted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in:57 minutes Limit details: You’ve used the included review currently available. Your 90 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Comment |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #13186 (failure). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:13e62ef703
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This PR adds five immutable inbox request records but did not regenerate data/outstanding-issues-snapshot.json, so npm run check:outstanding-issues (the "Outstanding-issues ledger integrity" required static-pr job) failed with counts.pending: committed 32 vs regenerated 37. Fixed by running node scripts/generate-outstanding-issues-snapshot.mjs, which is the exact command check-outstanding-issues-snapshot.mjs's own failure message names. No canonical ledger edit (docs/outstanding-issues.md is untouched, as intended -- these five requests still reconcile later via npm run issues:reconcile from a dedicated ledger branch). Verified: npm run check:outstanding-issues passes end to end, snapshot now "in step with data/outstanding-issues-snapshot.json (78 open, 37 pending)". npx prettier --check data/outstanding-issues-snapshot.json passes. No executable code changed, so no lint/typecheck/test/build gate applies to this change specifically. RAG impact: none. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…into claude/session-findings-2270-a
BigSimmo
commented
Aug 22, 2026
Final head SHA: Blocker found and disposition
Fix: ran Sync / merge-tree statusWhile preparing the fix, the branch's remote head moved (the PR owner merged Targeted verification performed
No provider-backed checks run. Required-CI status (at this exact head)Run 32575061565 — green so far: Review-thread status3 unresolved threads found, all from the automated Codex reviewer:
Residual risk / required human action
Merge left to the user. UNBLOCKED — CI PENDING Generated by Claude Code |
BigSimmo
commented
Aug 22, 2026
Closing this in favour of a clean re-do. The content is wanted; this branch is not salvageable at reasonable cost. Why. Three agents pushed to this branch in parallel — the original session, a Codex autofix pass, and a second Claude session — and the result is wrong in ways that matter for a permanent ledger:
Publishing either statement into Two structural problems this exposed, which will recur.
Replacement: same five findings plus the snapshot-collision one, re-derived from Generated by Claude Code |
Pull request was closed
…close the Dev Drive inventory Six immutable inbox requests plus one update, queued for a later reconcile; no canonical ledger edit here. Replaces PR #2284, which was closed after three agents pushed to it in parallel and two of the resulting 'fixes' were factually wrong. - verify:phone-chrome can exit 0 having run no browser tests at all when its changed-file selector resolves to nothing phone-chrome-affecting. Caught while running the A2 gates: the bare invocation reported success having executed only two docs checks. - tests/gate-receipts.test.ts carries two chmod-based assertions that cannot pass on the Windows ReFS Dev Drive, so every local npm run test is permanently two-red and verify:pr-local stops before build. - The Claude push-format-guard hook blocks all pushes from linked worktrees, because it compares core.hooksPath against the worktree root rather than the common git dir, then fails on a git-ignored file. - Seven .claude/worktrees directories are empty and NOT registered worktrees, while remaining the cwd of seven live sessions. The repair command is recorded as verified by execution: the plain unforced worktree add succeeds, exit 0. An earlier review comment and an automated fix both asserted a forced add was required; it is not, and -f would disable the branch-already-checked-out guard. - data/outstanding-issues-snapshot.json is generated, must be regenerated by every inbox PR, and therefore conflicts whenever any other ledger PR lands first. That is what killed #2284 twice in an hour. registered worktrees and 116 separate clones across eight roots, 9.30 GB of landed candidates, and the leftover-directory arithmetic stated explicitly as 18 = 11 + 7. Cleanup is deferred indefinitely by owner decision after a removal pass was halted and fully reverted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Summary
Five immutable inbox requests from the issue #2270 Part A session — four new findings and one update. No canonical ledger edit;
docs/outstanding-issues.mdis untouched and these reconcile later.verify:phone-chromecan exit 0 having run no browser tests at all (P2). Invoked bare on a cleanmain, its changed-file selector found nothing phone-chrome-affecting, printed a note to that effect, ran two docs checks and exited 0 — indistinguishable from a full pass. Caught while running the A2 gates for Local-only follow-ups after #2253 / #2266 / #2268 — browser gates, orphaned commits, dead reconcile branches, Dev Drive #2270; reporting it as green would have been a false green of exactly the kindAGENTS.mdwarns about.tests/gate-receipts.test.tsis permanently two-red on the Windows workstation (P3). Two caseschmodSync(path, 0o755)and assert the working-tree mode changes the signature. On this ReFS Dev Drivecore.fileModeisfalseandchmodis a no-op, so they cannot pass. Reproduced on unmodifiedmainat73b1e71a0. This also stopsverify:pr-localbefore it reachesbuild,check:bundle-budgetand the RAG fixture checks.push-format-guardhook blocks every push from a linked worktree (P3). It comparescore.hooksPathagainst the worktree root instead of the common git dir, concludes the repository pre-push hook is unwired when it is in fact wired and running, then fails a whole-tree Prettier check on a git-ignored file that could never be part of the push.#6GW95Dupdate — the fleet inventory this row asked for is complete, and the cleanup is deliberately deferred. Eight roots scanned: 208 checkouts of this repository, of which 92 are registered worktrees and 116 are separate full clones with their own object databases — and none of those 116 is covered byscripts/clean-worktree.mjsat all, which is the finding that matters for future sweeps. Zero unregistered worktrees, zero stale gitdir pointers.clean:worktree --merged --squashed --dry-runidentified 23 landed candidates totalling 9.30 GB. Capacity is no longer the driver:D:is 80 GB with 53 GB free.The owner halted the removal pass mid-run and all 13 removed worktrees were restored — branch, head and clean tree verified individually, dependencies restored by byte-identical copy. Five live chats had had their working directory deleted underneath them. Two process lessons are recorded on the row: a
git refused/EPERMremoval means a live process holds that directory and is a stop, never something to retry on a later pass; and the candidate list must be shown and approved before any deletion.Verification
npm run verify:pr-localDocumentation-only scope: the five added files are immutable JSON request records under
docs/outstanding-issues-inbox/, which the repository treats as append-only and merge-safe.npx prettier --check docs/outstanding-issues-inbox/*.jsonreportsAll matched files use Prettier code style!, andscripts/ledger-inbox.mjsvalidated each request against its schema at creation time — an invalid payload cannot be written.Verification not run: the executable gates (
lint,typecheck,test,build) were not run for this change, because it adds no executable code, no test, and no configuration — there is no plausible failure path for them to detect. The full local suite was run earlier in the same session against the same base and is two-red for the pre-existing Windowschmodreason described above, which is one of the findings filed here.Risk and rollout
git revertthis single commit.Notes
Run
npm run issues:reconcilefrom a dedicated fresh-base branch once this lands, to apply the five requests todocs/outstanding-issues.md.