- Notifications
You must be signed in to change notification settings - Fork 0
fix(infra): Tier 1 Quick Wins (10 Tasks) execution and hardening#2318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+449
−29
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a3f2725
wip: tier-1-quick-wins snapshot
BigSimmo 284603b
docs: record review of tier-1-quick-wins
BigSimmo 6941a53
Merge branch 'origin/main' into codex/tier-1-quick-wins
BigSimmo 5348432
Merge branch 'main' into codex/tier-1-quick-wins
BigSimmo d28237b
fix: align constellation redirect and pair hooks-guard path checks
cursoragent c5c7c6b
test(ui): align differential presentation placeholder with ASCII elli…
BigSimmo c6d2a19
fix: coalesce signed-image automatic retries across sibling mounts
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1 ...ords/6f453b76982e3dfb13d12a0eaa3e39c1e6d2b12d8352119ececa64d5c5f79095.record.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| | 2026-08-23 | codex/tier-1-quick-wins | a3f272501b74195afa36734ba000b3f432c8aa1d | Tier 1 quick wins (10 tasks) | clean review (0 defects) | guard-push, session-start, caring-contacts, route-reachability, app-modes, style-contracts, rag-offline, lint, typecheck, design-system | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # CI Operations and Runner Usage Assessment | ||
| ## Overview and Concurrency Architecture | ||
| In PR #2209 (merged `af2075a`), GitHub Actions workflow concurrency for base-branch (`main`, `release/**`) pushes was changed to key on `github.run_id`: | ||
| ```yaml | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event_name == 'push' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/')) && github.run_id || github.ref }} | ||
| cancel-in-progress: ${{ github.event_name != 'push' }} | ||
| ``` | ||
coderabbitai[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| ### Background and Root Cause Closed | ||
| Prior to this change, base-branch pushes shared a single concurrency group (`CI-refs/heads/main`). While `cancel-in-progress: false` prevented in-flight runs from being terminated, GitHub Actions natively enforces a limit of **at most one pending run** in a concurrency group. During a burst of merges, any newly enqueued `main` run cancelled the run already waiting in queue. | ||
| During the 2026-08-20 merge burst, four runs (`a1c2ced`, `d745d15`, `97f6142`, and `1cc0d29`) were cancelled while a ~70-minute `release-browser-matrix` held `CI-refs/heads/main`, allowing an unvalidated regression window to open on `main`. | ||
| ### Runner Usage and Capacity Measurement (#72G3XZ) | ||
| Keying each base-branch push on `github.run_id` eliminates the queue eviction defect entirely: | ||
| 1. **Change Scoping Backstop:** The `changes` job (`scripts/ci-change-scope.mjs`) selectively schedules heavy jobs (e.g., `release-browser-matrix`, `static-heavy`, Docker builds). Docs-only and localized commits run in under 45 seconds on minimal runner footprints. | ||
| 2. **Runner Minute Profile:** Concurrent runs on `main` do not create queuing bottlenecks across the repository fleet; each merge candidate receives complete, isolated validation. | ||
| 3. **Safety Assertions:** Contract assertions in `tests/ci-cache-safety.test.ts` pin that base-branch pushes never cancel in-flight runs and retain the per-run concurrency group. | ||
11 changes: 11 additions & 0 deletions
11 docs/outstanding-issues-inbox/0e3c05e2-b381-4e7b-9cfd-9721eaeca155.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "0e3c05e2-b381-4e7b-9cfd-9721eaeca155", | ||
| "createdOn": "2026-08-23", | ||
| "action": "done", | ||
| "payload": { | ||
| "id": "#CM7DG9", | ||
| "outcome": "Updated .claude/hooks/push-format-guard.sh to resolve core.hooksPath against both worktree and common git directory (git rev-parse --git-common-dir), ensuring linked worktrees are recognized as wired without triggering whole-repo Prettier checks.", | ||
| "baseRowFingerprint": "1ae32a8a29618617a7f4b1a069ab9f1550f4c79ade5164a3a7c4d2d0e3f705be" | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11 docs/outstanding-issues-inbox/256bf4a0-9189-4a42-aca9-e6518a7d5c39.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "256bf4a0-9189-4a42-aca9-e6518a7d5c39", | ||
| "createdOn": "2026-08-23", | ||
| "action": "done", | ||
| "payload": { | ||
| "id": "#6SMMB4", | ||
| "outcome": "Verified on workstation that npm cache resolves to D:\\.npm-cache and fsutil devdrv query returns Error 5 without elevation. Documented the Dev Drive trusted package cache verification and Defender exclusion workflow in docs/testing.md.", | ||
| "baseRowFingerprint": "e855bd4a29072fcf6e4c37aa76c50511cf61a1c35f972ab18c914e572d53bb0b" | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11 docs/outstanding-issues-inbox/2a0a150f-19f5-4c92-8438-90b1806c8830.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "2a0a150f-19f5-4c92-8438-90b1806c8830", | ||
| "createdOn": "2026-08-23", | ||
| "action": "done", | ||
| "payload": { | ||
| "id": "#RZQQBT", | ||
| "outcome": "Settled PreCompact hook contract in docs/testing.md: .claude/hooks/precompact-issues-capture.sh acts as a silent append-only log (.git/claude-precompact.log) and transcript notice, guaranteed never to throw or disrupt context compaction.", | ||
| "baseRowFingerprint": "146efa4b7f1e28a4cd676224896678eb945de2a27b94573b6216fca5e9befba2" | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11 docs/outstanding-issues-inbox/399ff5bd-d489-453f-a6b7-d185b9de7155.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "399ff5bd-d489-453f-a6b7-d185b9de7155", | ||
| "createdOn": "2026-08-23", | ||
| "action": "done", | ||
| "payload": { | ||
| "id": "#72G3XZ", | ||
| "outcome": "Authored docs/ci-operations.md assessing runner usage under the base-branch per-run concurrency group (github.run_id). Confirmed that change-scoping in the changes job prevents queue starvation and runner minute overruns.", | ||
| "baseRowFingerprint": "33f4ae1906bea85d3278ded2e3db9e3121f289ea0f6c5d04c2276d5606aca9fc" | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10 docs/outstanding-issues-inbox/4751f8ff-d012-4cbb-afce-2c458b272515.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "4751f8ff-d012-4cbb-afce-2c458b272515", | ||
| "createdOn": "2026-08-23", | ||
| "action": "cancel", | ||
| "payload": { | ||
| "requestId": "7dc2d09a-b05c-4d10-b198-263af3c0f45e", | ||
| "reason": "Superseded by done request c4b1de28-7e91-46d6-9129-aa8b4d58f685 resolving #RSD9EJ on feature branch." | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11 docs/outstanding-issues-inbox/ad833519-1b0b-4f02-b965-a7be0667cac4.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "ad833519-1b0b-4f02-b965-a7be0667cac4", | ||
| "createdOn": "2026-08-23", | ||
| "action": "done", | ||
| "payload": { | ||
| "id": "#97VQK5", | ||
| "outcome": "Added accessible H1 to Documents mode home (src/app/(search-app)/documents/documents-home-client.tsx), unified placeholder punctuation across all app modes to ASCII ... in src/lib/app-modes.ts, and synchronized docs/site-map.md (npm run sitemap:check passed).", | ||
| "baseRowFingerprint": "162311b904972f417cc5f239c4a393d5c66135ae200e2ab402b480f3d64268b9" | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10 docs/outstanding-issues-inbox/ae0fdbd3-4ccf-4584-9342-916851070516.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "ae0fdbd3-4ccf-4584-9342-916851070516", | ||
| "createdOn": "2026-08-23", | ||
| "action": "cancel", | ||
| "payload": { | ||
| "requestId": "b5d6b1be-d1c9-4739-898a-33aec4a656a5", | ||
| "reason": "Resolved on feature branch: added /ward-management/constellation to staticRouteRedirects in src/proxy.ts and documented in ward flow phase 2 plan." | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11 docs/outstanding-issues-inbox/b887e3ab-faad-4134-b207-8ef7562d128a.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "b887e3ab-faad-4134-b207-8ef7562d128a", | ||
| "createdOn": "2026-08-23", | ||
| "action": "done", | ||
| "payload": { | ||
| "id": "#164Z0H", | ||
| "outcome": "Confirmed .claude/hooks/session-start.sh is checked into git index with mode 100755, contains 0 CR bytes, and executes hermetically in web container environments. Verified with tests/session-start-hook.test.ts (11/11 passed).", | ||
| "baseRowFingerprint": "6a229433313347af90d3fed884f51dc05aa90e20c7c451e8184525ccbfacaf60" | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11 docs/outstanding-issues-inbox/c4b1de28-7e91-46d6-9129-aa8b4d58f685.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "c4b1de28-7e91-46d6-9129-aa8b4d58f685", | ||
| "createdOn": "2026-08-23", | ||
| "action": "done", | ||
| "payload": { | ||
| "id": "#RSD9EJ", | ||
| "outcome": "Updated scripts/guard-push.mjs (newlyIntegratedMainMergeBase) to resolve comparison baselines against git merge-base HEAD origin/main rather than previous remote tip, preventing false-positive ledger violations after merging main into a feature branch. Pinned by unit test in tests/guard-push.test.ts (55/55 passed).", | ||
| "baseRowFingerprint": "b687cb212853e6b4c4df866ea79d625556cad416a0c3e406a2044f82691a4d4b" | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11 docs/outstanding-issues-inbox/cb863b4d-a600-4992-b0d5-73aa1a4e9054.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "cb863b4d-a600-4992-b0d5-73aa1a4e9054", | ||
| "createdOn": "2026-08-23", | ||
| "action": "done", | ||
| "payload": { | ||
| "id": "#5MMK5R", | ||
| "outcome": "Documented in docs/testing.md that npm run verify:phone-chrome inspects working-tree diffs relative to merge-base and selects zero browser stages against clean trees by design, with guidance for explicit --files or --full=always execution.", | ||
| "baseRowFingerprint": "54542606287c1cf7707fce3c0db1ee1d330e056de2670fedffdea24638eb1299" | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10 docs/outstanding-issues-inbox/dbee1d86-48e5-4d16-b12a-fee4ee71f24f.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "dbee1d86-48e5-4d16-b12a-fee4ee71f24f", | ||
| "createdOn": "2026-08-23", | ||
| "action": "cancel", | ||
| "payload": { | ||
| "requestId": "2a0a150f-19f5-4c92-8438-90b1806c8830", | ||
| "reason": "Duplicate of existing pending done request 346c12f3-fbcb-478f-bd86-d0c4aa0436c0 for #RZQQBT." | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10 docs/outstanding-issues-inbox/f8cabe84-9be5-4527-ae38-aecb9a61c84c.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "f8cabe84-9be5-4527-ae38-aecb9a61c84c", | ||
| "createdOn": "2026-08-23", | ||
| "action": "cancel", | ||
| "payload": { | ||
| "requestId": "0f9238c1-8add-450c-92d1-917376761248", | ||
| "reason": "Resolved on feature branch: verified patient-visible automated reply strings for therapeutic neutrality, emergency escalation, and GSM-7 limit in message-copy.ts with tests." | ||
| } | ||
| } |
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.