Skip to content

Mockup: Dictionary Filter band always, Terms and A–Z under it - #2322

Closed
BigSimmo wants to merge 13 commits into
mainfrom
cursor/dictionary-heading-controls-mockup-4ee0
Closed

Mockup: Dictionary Filter band always, Terms and A–Z under it#2322
BigSimmo wants to merge 13 commits into
mainfrom
cursor/dictionary-heading-controls-mockup-4ee0

Conversation

@BigSimmo

@BigSimmoBigSimmo commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • /mockups/dictionary-trailing-toolbar keeps the original Filter search-band on browse and search (count, optional query, Filter).
  • Compact Terms / Abbreviations and A–Z sit under that band on the right.
  • Topics live inside the Filter sheet, not on the title row.
  • Live /dictionary/search is unchanged.

Browse and search frames with Filter band always under the title
Filter sheet with Topics inside
dictionary_persistent_filter_band_demo.mp4

Verification

  • npx prettier --write on the owned mockup files
  • npm run typecheck[gate-receipts] recorded a pass for "typecheck:internal" (5183 input files). (arbiter: RUN typecheck — ui scope never defers)
  • Visual QA at http://localhost:4461/mockups/dictionary-trailing-toolbar — browse Filter band is count + Filter; search band adds query + clear; Terms/Abbreviations and A–Z sit under the band
  • Verification not run: npm run verify:pr-local — mockup + documentation only; typecheck covers the compile failure class
  • Verification not run: npm run verify:ui — design-scratch mockup, production catalogue unchanged
  • Verification not run: npm run verify:release
  • Verification not run: npm run eval:retrieval:quality — no retrieval change
  • Verification not run: npm run eval:rag / eval:quality
  • Verification not run: npm run check:production-readiness
  • Verification not run: npm run check:deployment-readiness

Risk and rollout

  • Risk: none for production catalogue behaviour; mockups 404 in production
  • Rollback: revert this PR
  • Provider or production effects: None
  • RAG impact: none

Clinical Governance Preflight

Not required: design-scratch mockup only.

Notes

Live Dictionary is unchanged until a direction is chosen.

To show artifacts inline, enable in settings.

Open in WebOpen in Cursor

Study whether Dictionary can put Filter on the results ribbon while
the Terms / Abbreviations toggle and A–Z sit next to the page title.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@coderabbitai

coderabbitaiBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
auto_review:
drafts: true

Comment @coderabbitai help to get the list of available commands.

@supabase

supabaseBot commented Aug 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@github-actions

github-actionsBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Static PR checksneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #13568 (failure).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

…ons.
Keep the browse stack from image two (title, then Terms / A–Z) and try four
ways to show a two-word query without jamming it into the count.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursorcursorBot changed the title Mockup: Dictionary Filter in the bar, Terms and A–Z beside the titleMockup: Dictionary query bar under the Terms buttonsAug 24, 2026
cursoragentand others added 2 commits August 24, 2026 08:34
It currently stands down with the query, matching production. Four frames
keep it beside the toggle, in the query row, next to the title, or inside
Filter.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Abbreviations move into the Filter sheet as a Show lens. A–Z is tried
beside the title, beside Filter in the results band, or inside Filter.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursorcursorBot changed the title Mockup: Dictionary query bar under the Terms buttonsMockup: Dictionary original Filter with three A–Z homesAug 24, 2026
A–Z sits by the title while browsing and stands down during search, when the original Filter occupies the results band.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursorcursorBot changed the title Mockup: Dictionary original Filter with three A–Z homesMockup: Dictionary browse vs search Filter splitAug 24, 2026
cursoragentand others added 2 commits August 24, 2026 09:30
The title stays a title; the two list controls sit together on the right. Search still hides A–Z and keeps Filter in the results band.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
The title stays on the left. Browse groups the compact Terms / Abbreviations toggle with Topics and A–Z; search hides A–Z and keeps the original Filter in the results band.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursorcursorBot changed the title Mockup: Dictionary browse vs search Filter splitMockup: Dictionary compact trailing toolbarAug 24, 2026
cursoragentand others added 4 commits August 24, 2026 09:58
At 390 px the compact Terms / Abbreviations, Topics, and A–Z cluster sits under a full Clinical terms heading when the row cannot hold both.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Topics stays on the heading row. The compact Terms / Abbreviations toggle and A–Z sit on the next line, right-aligned, instead of crowding the title.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
The trailing-toolbar mockup now always shows the original search-band Filter
control. Compact Terms / Abbreviations and A–Z sit underneath on the right.
Topics move into the Filter sheet.
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursorcursorBot changed the title Mockup: Dictionary compact trailing toolbarMockup: Dictionary Filter band always, Terms and A–Z under itAug 24, 2026
cursoragentand others added 2 commits August 24, 2026 10:44
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
BigSimmo added a commit that referenced this pull request Aug 24, 2026
Records the Run PR maintenance sweep across three open draft/ready PRs:
synced #2322 and #2316 from a stale main behind-state via a clean
fast-forward update; resolved a real merge conflict on #2321 isolated to
generated docs/site-map.md and regenerated it via npm run sitemap:update.
No CI failures or unresolved review threads required action on any of the
three PRs.
Claude-Session: https://claude.ai/code/session_01C4RHy24AtgPobEQQwrj7u1
Co-authored-by: Claude <noreply@anthropic.com>
@cursor

cursorBot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Superseded by #2341, which now carries the approved live Dictionary catalogue (title off, original search at the top, persistent Filter band). This mockup PR is being closed so the task has a single PR.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo@cursoragent