fix(a11y): bump answer-support sheet footer taps to 48px (min-h-12) - #233
Merged
Conversation
Footer Source/Copy/Add controls were min-h-11 (44px) and dipped to ~43.2px via getBoundingClientRect sub-pixel rounding deep in scrolled sheets, flaking the required ui-smoke touch-target assertion. min-h-12 clears the 44px floor deterministically. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The two answer-support sheet footer action rows (Source / Copy / Add) — in
ClinicalNotesChecklistPanel(evidence-panels.tsx) andMobileEvidenceSheetContent(ClinicalDashboard.tsx) — weremin-h-11(44px). Bumped tomin-h-12(48px).Why
The required
ui-smokecheck (chromium) flakily failedexpectMinTouchTargeton these controls (e.g.answer support popups adapt at near sheet breakpointmeasuring 43.18px,…at tablet43.93px), intermittently blocking unrelated PRs.Root cause traced empirically (instrumented the helper +
--repeat-eachon chromium): the controls are genuinely 44px in CSS (min-height: 44px,height: 44px,transform: none, dpr 1, root font 16px — not an animation artifact; both sheets setmotion-safe:animate-none). The shortfall isgetBoundingClientRect()sub-pixel rounding: sitting deep in a scrolled sheet at fractional Y (~738–980px), the measured rect rounds down to ~43.85px locally / ~43.18px in CI, straddling the helper's effective 43.5px floor (44 − 0.5 tolerance). Controls near the top of the sheet stay pinned at 44.0 and were never at risk.min-h-12(48px) rounds to ~47–48px, clearing the 44px floor deterministically — and is a genuine tap-target improvement.Scope
ClinicalDashboardmonolith is touched solely in those 4 footer lines.Verification
--repeat-each=3on chromium (near-sheet + tablet): footer controls now render 48px and no longer dip below 44.npx playwright test tests/ui-smoke.spec.ts -g "answer support popups": all chromium + firefox cases pass. (WebKit cases fail atwaitForDemoDashboardReady— the pre-existing, non-blockingssr:falsedashboard-ready race inrelease-browser-matrix, unrelated to this change.)🤖 Generated with Claude Code