fix(ward-flow): remove the fabricated Mental Health Act figure

[BigSimmo]

Summary

• Removes a fabricated Mental Health Act figure from the Ward Flow prototype.main carried FORM_1A_REFERRAL_EXPIRY_MINUTES = 7 * 24 * 60, doc-commented as "the Mental Health Act's seven-day outer limit". No product owner supplied that figure; an assistant wrote it from its own recollection. It is the third invented statutory figure this prototype has produced, and the second attributed to the Act in a doc comment.
• It was not dead code, and it reached the screen.RAISE_REFERRAL stamped it onto every newly raised Form 1A as a dueAt; the seeded fixture carried authored dueAt values on Form 1A movements; ward-management-console.tsx rendered · due <time>; ward-derivations.ts turned it into a "Legal timing breached" action-inbox item with a countdown; priority-queue.tsx and shortlist-panel.tsx rendered breach state from it. A user raising a referral saw a legal deadline that does not exist.
• A test was enforcing it.tests/ward-model-phase3.test.ts required every Form 1A to carry a dueAt, so the fabrication was pinned in place by a guard. That test now asserts the opposite, and keeps its non-vacuity floor so it still fails if the fixture stops containing 1As or 3Bs.
• The correction is the product owner's own, recorded verbatim in the code. Asked directly on 2026-08-23, his instruction was narrower than a corrected figure — "please can you leave the legal part and just start a clock once the patient arrives to ED. Keep it simple for now." Neither a Form 1A nor a Form 3B carries a dueAt in this model any longer. The forms record that they exist, never when they lapse. This change supplies no figure and corrects none. Removal is the only direction it moves in.
• Corrects the prose claim as well as the number. The LegalForm doc comment asserted that a Form 1A "always carries a real statutory examination window, so it always carries a dueAt" — the same fabrication in words. Separately, "— no statutory deadline" now reads "no deadline recorded": the first states what the Act requires with the same unearned confidence as the countdown being deleted, the second states what the record holds, which is the only claim this prototype is entitled to make. The same unattributed claim is brought into line at five further sites.
• Adds tests/ward-legal-figure-guard.test.ts against a fourth recurrence. Two independent halves, both fail-closed by construction rather than by guessing what a bad name looks like:
  • Part 1 walks the reducer through every event type, against a Form 1A and a Form 3B, asserting each event is genuinely accepted rather than refused, and that no legal form of any code carries a dueAt except an allowlist — 4A "Transport order" and 4C "Transfer between authorised hospitals" — each with a recorded reason for legitimately carrying an operational deadline.
  • Part 2 requires recorded provenance for every exported declaration in ward-model.ts whose initializer contains a numeric literal, naming who supplied the figure and when. ED_ACCESS_TARGET_MINUTES qualifies: the clinician's instruction of 2026-08-22 was "change the 4 hour limit to 24 for patients in ED".
• Repairs three tests that had quietly stopped proving anything rather than leaving them honest-but-dormant: the action inbox's one-item-per-category guard, the ED pressure breach count, and the parallel-referral-cap case. Each was confirmed by re-running the exact regression it exists to catch.
• Deliberately out of scope, and unchanged: forms 4A and 4C, which carry real operational deadlines about moving a person rather than about the examination timeline; and formedAt on RAISE_REFERRAL, which is a separate question travelling with a later branch reconciliation.

Verification

Verification not run: npm run verify:pr-local — this change is confined to the Ward Flow prototype's model, fixture, components and its own tests. Ward Flow shares no code path with retrieval, ingestion or answer generation. The gates below cover it directly and were all run first-hand on the committed tree.

• npx tsc --noEmit -p tsconfig.json — clean, exit 0, zero output lines. tsconfig.json includes **/*.ts, so the Playwright spec edits are typechecked too.
• Ward unit suites, one invocation, 20 files — 228 passed.
• Ward Chromium journeys — ui-ward-coordinator, ui-ward-management, ui-ward-roles — 39 passed in 1.6 min, zero failures, against a warmed dev server on this worktree's own printed port.
• npx prettier --check on all 14 changed files — "All matched files use Prettier code style!"

Every test added or changed was mutation-tested: the mutation applied, the edited line read back from the file, the run watched to fail, then reverted and confirmed green. Four bypasses that defeated earlier drafts of the guard now fail, each verified this way — the constant under a different name (FORM_1A_REFERRAL_CLOCK), a post-construction dueAt in TRANSPORT_ACCEPTED, the same targeted specifically at a Form 1A, and three declaration shapes (object, arrow function, enum).

Known limits of the guard, stated in the file itself rather than implied: Part 1 exercises every event type against a 1A and a 3B, but not every guard condition inside each case; Part 2 governs ward-model.ts exported declarations only; and the meta-check that exclusions are justified is stage-sensitive, so a bogus exclusion entry is not itself rejected. These are recorded, not hidden — the file's own assertions pin its incompleteness so that quietly widening it goes red.

Risk and rollout

• Risk: Low, and lower than leaving it. The change only removes a value and the claims about it. Every consumer already handled an absent dueAt explicitly — that path was built in Task 6A for Form 3B, which has never carried one — so no surface gains an absence it was not already written for. The visible effect is that a Form 1A no longer displays a due time or a "Legal timing breached" item.
• Rollback: revert the single commit. No migration, no data change, no configuration change.
• Provider or production effects: None. No provider was contacted; no live database, OpenAI call, or hosted workflow is involved.
• RAG impact: none — this change touches no retrieval, ranking, selection, chunking, or answer-generation surface.

Clinical Governance Preflight

• Source-backed claims still require linked source verification before clinical use
• No patient-identifiable document workflow was introduced or expanded without explicit governance approval
• Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
• Service-role keys and private document access remain server-only
• Demo/synthetic content remains clearly separated from real clinical sources
• Source metadata, review status, and outdated/unknown-source behavior remain conservative
• Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

On the last item specifically: this change reduces decision-support surface rather than extending it. It removes a displayed legal deadline that no source supports. Ward Flow remains a synthetic prototype and is not clinical decision support; nothing here alters that classification.

Notes

• Ward Flow is a synthetic, offline prototype. It touches no live database, no patient data, and no OpenAI call. Sex is the only patient attribute the model carries.
• The same correction was made and reviewed on the branch codex/ward-management-design. That branch's own pull request (Codex/ward management design #2289) squash-merged on 2026-08-22 — before the correction was made there — which is why the fabrication is on main while that branch is clean. This pull request ports the reviewed correction so main stops carrying it, without waiting for the larger branch reconciliation that is still outstanding.
• Three test-local fixtures that constructed a Form 1A carrying a dueAt were relabelled to Form 4A "Transport order" rather than deleted: one of them is now the only positive proof that the breach-scoring path works at all, so removing them would have lost real coverage.

---

Note

Medium Risk
Touches Mental Health Act form timing on coordinator screens, inbox, and priority scoring. The change only removes an unsupported deadline and keeps 4A/4C operational clocks, but wrong legal copy here is still high-impact if it regresses.

Overview
Stops Form 1A (and already-empty Form 3B) from carrying a dueAt. The seven-day FORM_1A_REFERRAL_EXPIRY_MINUTES constant is deleted; RAISE_REFERRAL and the fixture no longer stamp a countdown onto examination forms. UI copy now says no deadline recorded instead of claiming what the Act requires.

Transport/transfer forms 4A and 4C still keep operational dueAts. Inbox, ED pressure, and priority scoring still treat a past dueAt as a breach, but the live fixture no longer has examination-form breaches.

Adds tests/ward-legal-figure-guard.test.ts: runtime allowlist for which form codes may have a deadline, provenance for numeric exports in ward-model.ts, and an AST denylist so invented statutory durations cannot return under a new name. Related tests that had become zero-only after the fixture change now inject 4A movements so .find() / hard-wired-zero regressions still fail.

^{Reviewed by Cursor Bugbot for commit e415ab2. Configure here.}

[coderabbitai]

Warning

Review limit reached

Next included review available in 29 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 101 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a553d133-26e1-4fb8-ad7a-3adba742d925

📥 Commits

Reviewing files that changed from the base of the PR and between 8da4c13 and b6b3890.

📒 Files selected for processing (14)

• src/components/ward-management/coordinator/shortlist-panel.tsx
• src/components/ward-management/ward-derivations.ts
• src/components/ward-management/ward-flow-reducer.ts
• src/components/ward-management/ward-management-console.tsx
• src/components/ward-management/ward-model.ts
• src/components/ward-management/ward-movements.ts
• tests/ui-ward-coordinator.spec.ts
• tests/ward-derivations.test.ts
• tests/ward-flow-reducer.test.ts
• tests/ward-legal-figure-guard.test.ts
• tests/ward-model-phase3.test.ts
• tests/ward-model.test.ts
• tests/ward-pressure.test.ts
• tests/ward-priority.test.ts

---

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[cursor]

Approved. Cursor Bugbot completed successfully with no findings that need human review, and no approval policy requires a human reviewer. No reviewers were assigned.

_{Sent by Cursor Approval Agent: Pull Request Router and Approver}