Skip to content

fix(a11y): bump shellChip tap target to 44px#235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 2 commits into from
Jul 3, 2026
Merged

fix(a11y): bump shellChip tap target to 44px #235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af3f0f9
fix(a11y): bump shellChip tap target to 44px (min-h-10 -> min-h-11)
BigSimmo Jul 3, 2026
1baba2b
Merge main into shellchip tap target
BigSimmo Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docs/redesign/09-ui-primitives-recipes.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -131,10 +131,11 @@ focus-visible:outline-offset-2 focus-visible:outline-[color:var(--focus)]` block
(`toolbarButton`, `chatSendButton`, icon buttons) have no press feedback.
3. ✅ **FIXED (2026-07-03).** Added `disabled:cursor-not-allowed disabled:opacity-50`
to `navPill`, `chatMicroAction`, `chatComposerIconButton`, `sidebarItem` — they now
honour the documented disabled state.
honour the documented disabled state, including the disabled
`chatComposerIconButton` in `applications-launcher-page.tsx`.
4. ✅ **FIXED (2026-07-03).** `shellChip` bumped `min-h-10` → `min-h-11` (40→44px) to
meet the WCAG tap minimum. (It still lacks `focus-visible` — add if it's used as a
focusable control at its call sites.)
meet the WCAG tap minimum — it's used on a real `<button>` filter ("All documents"
in `master-search-header.tsx`).
5. **Input focus uses `focus:` not `focus-visible:`** (`fieldControl`,
`commandInput`) — intentional for text fields (focus ring should show on
pointer focus too), but noted so it isn't "corrected" to `focus-visible:`.
Expand Down
Loading